Skip to content

Commit ea4c3fb

Browse files
committed
[INTERNAL] TestRunner: Use parseurl module instead of req.path
To be compatible with connect middleware APIs
1 parent ea77e20 commit ea4c3fb

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/middleware/testRunner.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ const fs = require("graceful-fs");
33
const readFile = promisify(fs.readFile);
44
const path = require("path");
55
const mime = require("mime-types");
6+
const parseurl = require("parseurl");
67
const log = require("@ui5/logger").getLogger("server:middleware:testRunner");
78

89
const testRunnerResourceRegEx = /\/test-resources\/sap\/ui\/qunit\/(testrunner\.(html|css)|TestRunner.js)$/;
@@ -31,7 +32,7 @@ function serveResource(res, resourcePath, resourceContent) {
3132
function createMiddleware({resources}) {
3233
return async function(req, res, next) {
3334
try {
34-
const pathname = req.path; // TODO: Other middlewares use the parseurl module here but I don't get why
35+
const pathname = parseurl(req).pathname;
3536
const parts = testRunnerResourceRegEx.exec(pathname);
3637
const resourceName = parts && parts[1];
3738

test/lib/server/middleware/testRunner.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function callMiddleware(reqPath) {
2323
const middleware = testRunnerMiddleware({resources: {}});
2424
return new Promise((resolve, reject) => {
2525
const req = {
26-
path: reqPath
26+
url: `http://localhost${reqPath}`
2727
};
2828
const res = {
2929
setHeader: function() {},

0 commit comments

Comments
 (0)