Skip to content

Commit 14fd133

Browse files
authored
fix(ui5-dynamic-page): remove aria-expanded from header element (#11895)
Removes non-compliant aria-expanded attribute from DynamicPage header element to conform with W3C ARIA specifications. Fixes #11633
1 parent ea6faee commit 14fd133

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

packages/fiori/src/DynamicPage.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,6 @@ class DynamicPage extends UI5Element {
282282
return this.hasHeading ? this._headerLabel : undefined;
283283
}
284284

285-
get headerAriaExpanded() {
286-
return this.hasHeading ? this._headerExpanded : undefined;
287-
}
288-
289285
/**
290286
* Defines if the header is snapped.
291287
*

packages/fiori/src/DynamicPageTemplate.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export default function DynamicPageTemplate(this: DynamicPage) {
1111
class="ui5-dynamic-page-title-header-wrapper"
1212
id={`${this._id}-header`}
1313
aria-label={this.headerAriaLabel}
14-
aria-expanded={this.headerAriaExpanded}
1514
onui5-toggle-title={this.onToggleTitle}
1615
>
1716
<slot name="titleArea"></slot>

packages/fiori/test/specs/DynamicPage.spec.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -417,8 +417,6 @@ describe("ARIA attributes", () => {
417417
// check ARIA attribute values
418418
assert.strictEqual(await headerWrapper.getAttribute("aria-label"), "Header Expanded",
419419
"aria-label value is correct");
420-
assert.strictEqual(await headerWrapper.getAttribute("aria-expanded"), "true",
421-
"aria-expanded value is correct");
422420
assert.strictEqual(await headerRoot.getAttribute("role"), "region",
423421
"header role is correct");
424422

@@ -452,8 +450,6 @@ describe("ARIA attributes", () => {
452450
// check ARIA attribute values
453451
assert.strictEqual(await headerWrapper.getAttribute("aria-label"), "Header Snapped",
454452
"aria-label value is correct");
455-
assert.strictEqual(await headerWrapper.getAttribute("aria-expanded"), "false",
456-
"aria-expanded value is correct");
457453

458454
assert.strictEqual(await titleFocusArea.getAttribute("aria-expanded"), "false",
459455
"aria-expanded value is correct");

0 commit comments

Comments
 (0)