Skip to content

Commit 1a28847

Browse files
authored
fix(ui5-shellbar-branding): improve logo spacing and RTL support (#11945)
- Replaced margin-right with margin-inline-end for better RTL compatibility - Added extra padding to the logo element - Increased spacing between the logo and the title Fixes #11897
1 parent 30fdb8e commit 1a28847

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

packages/fiori/src/themes/ShellBar.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ slot[name="profile"] {
159159
justify-content: center;
160160
height: 100%;
161161
overflow: hidden;
162-
margin-left: 0.25rem;
162+
margin-inline-start: 0.25rem;
163163
}
164164

165165
.ui5-shellbar-menu-button--interactive .ui5-shellbar-menu-button-arrow {

packages/fiori/src/themes/ShellBarBranding.css

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,16 @@
1010
overflow: hidden;
1111
display: flex;
1212
align-items: center;
13-
padding: .25rem .5rem .25rem .25rem;
13+
padding-block: 0.25rem;
14+
padding-inline: 0.25rem 0.5rem;
1415
box-sizing: border-box;
1516
cursor: pointer;
1617
background: var(--sapButton_Lite_Background);
1718
border: 1px solid var(--sapButton_Lite_BorderColor);
1819
color: var(--sapShell_TextColor);
1920
/* fix cutting of the focus outline */
2021
margin-inline-start: 0.125rem;
21-
margin-right: 8px;
22+
margin-inline-end: .5rem;
2223
}
2324

2425
.ui5-shellbar-branding-root:focus {
@@ -46,6 +47,7 @@
4647
overflow: hidden;
4748
text-overflow: ellipsis;
4849
color: var(--sapShell_SubBrand_TextColor);
50+
margin-inline-start: 0.25rem;
4951
}
5052

5153
.ui5-shellbar-logo-area {
@@ -66,4 +68,5 @@
6668
max-height: 2rem;
6769
max-width: 3.75rem;
6870
pointer-events: none;
71+
padding-inline: 0.25rem;
6972
}

0 commit comments

Comments
 (0)