Skip to content

Commit a8e8dd1

Browse files
authored
fix(ui5-checkbox): fix focus spacing (#12100)
According to the updated VD spec for checkbox, its focus needs to be 0.25rem outside of the component in both compact and cozy mode. Addtionally: - focus border radius on HC themes is fixed, there is not rounding. JIRA: BGSOFUIPIRIN-6883
1 parent b4a7539 commit a8e8dd1

File tree

8 files changed

+12
-14
lines changed

8 files changed

+12
-14
lines changed

packages/main/src/themes/sap_horizon/CheckBox-parameters.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@
3939
/* focus */
4040
--_ui5_checkbox_focus_position: 0.3125rem;
4141
--_ui5_checkbox_focus_border_radius: 0.5rem;
42-
--_ui5_checkbox_right_focus_distance: var(--_ui5_checkbox_focus_position);
42+
--_ui5_checkbox_right_focus_distance: 0.3125rem;
4343
}

packages/main/src/themes/sap_horizon/sizes-parameters.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
.sapUiSizeCompact {
2929
--_ui5_textarea_padding_top: 0.1875rem;
3030
--_ui5_textarea_padding_bottom: 0.125rem;
31-
--_ui5_checkbox_focus_position: 0.25rem;
31+
--_ui5_checkbox_focus_position: 0.125rem;
3232

3333
/* SplitButton */
3434
--_ui5_split_button_middle_separator_top: 0.3125rem;

packages/main/src/themes/sap_horizon_dark/CheckBox-parameters.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@
3939
/* focus */
4040
--_ui5_checkbox_focus_position: 0.3125rem;
4141
--_ui5_checkbox_focus_border_radius: 0.5rem;
42-
--_ui5_checkbox_right_focus_distance: var(--_ui5_checkbox_focus_position);
42+
--_ui5_checkbox_right_focus_distance: 0.3125rem;
4343
}

packages/main/src/themes/sap_horizon_dark/sizes-parameters.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
--_ui5_textarea_padding_top: 0.1875rem;
2828
--_ui5_textarea_padding_bottom: 0.125rem;
2929

30-
--_ui5_checkbox_focus_position: 0.25rem;
30+
--_ui5_checkbox_focus_position: 0.125rem;
3131

3232
/* SplitButton */
3333
--_ui5_split_button_middle_separator_top: 0.3125rem;

packages/main/src/themes/sap_horizon_hcb/CheckBox-parameters.css

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
--_ui5_checkbox_disabled_opacity: var(--sapContent_DisabledOpacity);
4141
/* focus */
4242
--_ui5_checkbox_focus_position: 0.3125rem;
43-
--_ui5_checkbox_focus_border_radius: 0.5rem;
44-
--_ui5_checkbox_right_focus_distance: var(--_ui5_checkbox_focus_position);
45-
--_ui5_checkbox_wrapped_focus_inset_block: 0.4375rem;
43+
--_ui5_checkbox_focus_border_radius: 0;
44+
--_ui5_checkbox_right_focus_distance: 0.3125rem;
4645
}

packages/main/src/themes/sap_horizon_hcb/sizes-parameters.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
--_ui5_color_picker_slider_handle_container_margin_top: 0.0625rem;
88

99
/* CheckBox */
10-
--_ui5_checkbox_focus_position: 0.25rem;
11-
--_ui5_checkbox_wrapped_focus_inset_block: 0.1875rem;
10+
--_ui5_checkbox_focus_position: 0.125rem;
11+
--_ui5_checkbox_wrapped_focus_inset_block: 0.125rem;
1212

1313
/* DayPicker */
1414
--_ui5_daypicker_selected_item_now_special_day_top: 1.5625rem;

packages/main/src/themes/sap_horizon_hcw/CheckBox-parameters.css

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
--_ui5_checkbox_disabled_opacity: var(--sapContent_DisabledOpacity);
4141
/* focus */
4242
--_ui5_checkbox_focus_position: 0.3125rem;
43-
--_ui5_checkbox_focus_border_radius: 0.5rem;
44-
--_ui5_checkbox_right_focus_distance: var(--_ui5_checkbox_focus_position);
45-
--_ui5_checkbox_wrapped_focus_inset_block: 0.4375rem;
43+
--_ui5_checkbox_focus_border_radius: 0;
44+
--_ui5_checkbox_right_focus_distance: 0.3125rem;
4645
}

packages/main/src/themes/sap_horizon_hcw/sizes-parameters.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
--_ui5_color_picker_slider_handle_container_margin_top: 0.0625rem;
88

99
/* CheckBox */
10-
--_ui5_checkbox_focus_position: 0.25rem;
11-
--_ui5_checkbox_wrapped_focus_inset_block: 0.1875rem;
10+
--_ui5_checkbox_focus_position: 0.125rem;
11+
--_ui5_checkbox_wrapped_focus_inset_block: 0.125rem;
1212

1313
/* DayPicker */
1414
--_ui5_daypicker_selected_item_now_special_day_top: 1.5625rem;

0 commit comments

Comments
 (0)