refactor(ui5-dynamic-side-content): replace resize handler with container queries #12054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S container queries
unazko
reviewed
Aug 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DynamicSideContent component to replace the existing ResizeHandler-based breakpoint detection with CSS container queries. This modernization enables styling based on the component's container size rather than relying on JavaScript resize handling and CSS class-based span calculations.
Key changes:
- Replaced ResizeHandler with ResizeObserver for breakpoint detection
- Migrated from CSS class-based layout system (ui5-dsc-span-*) to container query-based responsive design
- Updated test logic to verify actual CSS width values instead of CSS class presence
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fiori/src/DynamicSideContent.ts | Core refactoring from ResizeHandler to ResizeObserver, removed span-based layout logic, added container query support |
| packages/fiori/src/themes/DynamicSideContent.css | Complete CSS rewrite using container queries with @container rules for responsive breakpoints |
| packages/fiori/src/DynamicSideContentTemplate.tsx | Updated template to use dynamic CSS classes from component |
| packages/fiori/test/pages/DynamicSideContent.html | Updated toggle button display logic to use new _isToggleEnabled property |
| packages/fiori/cypress/specs/DynamicSideContent.cy.tsx | Modernized tests to check actual CSS width values instead of deprecated span classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tsanislavgatev
requested changes
Aug 25, 2025
tsanislavgatev
previously requested changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every component that has responsive paddings or visualisation based on a specific breakpoint apply class / attribute to the corresponding size and this class / attribute is used to style the component. Usually this class / attribute rely on the component width, where width is observed by resize handler in order to detect changes.
With current PR we want to start to use container queries. Container queries enable applying of styles to an element based on the size of the element's container.