Skip to content

fix(ui5-view-settings-dialog): initially focus first item in filter options #12065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 27, 2025
Merged

fix(ui5-view-settings-dialog): initially focus first item in filter options #12065

merged 20 commits into from
Aug 27, 2025
+51 −1

Conversation

GDamyanov
Copy link
Contributor

Fixes: #10555

@GDamyanov GDamyanov requested a review from unazko August 5, 2025 07:07
@GDamyanov GDamyanov self-assigned this Aug 6, 2025
unazko
unazko reviewed Aug 7, 2025
View reviewed changes
@GDamyanov GDamyanov requested a review from unazko August 7, 2025 11:18
unazko
unazko approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsanislavgatev
tsanislavgatev reviewed Aug 8, 2025
View reviewed changes
@GDamyanov GDamyanov merged commit f25d80e into main Aug 27, 2025
12 checks passed
@GDamyanov GDamyanov deleted the vsd-focus-filter branch August 27, 2025 12:39
@didip1000
Copy link
Contributor

‼️ Hey guys, this doesn't just initially focus the first filter item, it also steals the focus every time you select another option

@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.14.0-rc.5 🎉

The release is available on v2.14.0-rc.5

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

@unazko unazko unazko approved these changes

Assignees

@GDamyanov GDamyanov

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SF][A11Y][ViewSettingsDialog] The keyboard navigation order is unexpected.
6 participants
@GDamyanov @didip1000 @ui5-webcomponents-bot @tsanislavgatev @unazko @hinzzx