Add strictness about keys in hydration

Author: l-x

.gitignore

@@ -1,3 +1,4 @@
 /vendor/
 /build/
 composer.lock
+clover.xml

.travis.yml

@@ -8,3 +8,6 @@ script:
 
 install:
   - travis_retry composer install --no-interaction --prefer-source
+
+after_success:
+    - bash <(curl -s https://codecov.io/bash)

phpunit.xml.dist

@@ -18,4 +18,8 @@
             <directory suffix=".php">src/</directory>
         </whitelist>
     </filter>
+
+    <logging>
+        <log type="coverage-clover" target="clover.xml"/>
+    </logging>
 </phpunit>

src/Scn/Hydrator/Hydrator.php

@@ -10,6 +10,8 @@
 final class Hydrator implements HydratorInterface
 {
 
+    public const NO_STRICT_KEYS = 1;
+
     private function invoke(callable $callback, object $entity, ...$args)
     {
         if ($callback instanceof \Closure) {
@@ -19,8 +21,22 @@ private function invoke(callable $callback, object $entity, ...$args)
         return $callback(...$args);
     }
 
-    public function hydrate(HydratorConfigInterface $config, object $entity, array $data): void
-    {
+    public function hydrate(
+        HydratorConfigInterface $config,
+        object $entity,
+        array $data,
+        int $flags = 0
+    ): void {
+        $hydratorProperties = $config->getHydratorProperties();
+
+        if (~$flags & static::NO_STRICT_KEYS) {
+            $diff = array_keys(array_diff_key($data, $hydratorProperties));
+
+            if ($diff !== []) {
+                throw new \InvalidArgumentException(sprintf('Unexpected data: %s', join(', ', $diff)));
+            }
+        }
+
         foreach ($config->getHydratorProperties() as $propertyName => $set) {
             $this->invoke($set, $entity, $data[$propertyName] ?? null, $propertyName);
         }

src/Scn/Hydrator/HydratorInterface.php

@@ -10,7 +10,7 @@
 interface HydratorInterface
 {
 
-    public function hydrate(HydratorConfigInterface $config, object $entity, array $data): void;
+    public function hydrate(HydratorConfigInterface $config, object $entity, array $data, int $flags = 0): void;
 
     public function extract(ExtractorConfigInterface $config, object $entity): array;
 }

tests/Scn/Hydrator/HydratorTest.php

@@ -56,6 +56,58 @@ public function testHydrate(): void
         $this->assertSame($testData, $this->testValueStorage);
     }
 
+    public function testHydrateIsStrictByDefault()
+    {
+
+        $testPropertySetter = function (
+            $value,
+            string $name
+        ): void {
+            $this->testValueStorage[$name] = $value;
+        };
+
+        $hydratorConfig = new GenericHydratorConfig([
+            'prop1' => $testPropertySetter,
+        ]);
+
+
+        $testData = [
+            'unexpected' => true,
+            'prop1' => 'fu',
+            'another_unexpected' => true,
+        ];
+
+        $expectedResult = [
+            'prop1' => 'fu',
+        ];
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Unexpected data: unexpected, another_unexpected');
+
+        $this->subject->hydrate($hydratorConfig, $this, $testData, 0);
+
+        $this->assertSame($expectedResult, $this->testValueStorage);
+    }
+
+    public function testHydrateOnNonStrict()
+    {
+        $hydratorConfig = new GenericHydratorConfig([
+            'prop1' => 'strval',
+        ]);
+
+
+        $testData = [
+            'unexpected' => true,
+            'prop1' => 'fu',
+            'another_unexpected' => true,
+        ];
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Unexpected data: unexpected, another_unexpected');
+
+        $this->subject->hydrate($hydratorConfig, $this, $testData, 0);
+    }
+
     public function testExtract(): void
     {
         $testPropertyGetter = function (
@@ -73,13 +125,6 @@ public function testExtract(): void
 
         $randomInt = random_int(0, PHP_INT_MAX);
 
-
-        $testData = [
-            'prop1' => 'fu',
-            'prop2' => $randomInt,
-            'prop3' => null,
-        ];
-
         $this->testValueStorage = [
             'prop1' => ['fu', $this],
             'prop2' => [$randomInt, $this],