Skip to content

Commit 5d189e5

Browse files
authored
Merge pull request #41 from SC-SGS/refactor_executor_pool_names
Small fixes to internal pool names
2 parents 3c37402 + 4da08b1 commit 5d189e5

File tree

2 files changed

+25
-24
lines changed

2 files changed

+25
-24
lines changed

include/cppuddle/executor_recycling/detail/executor_pools_management.hpp

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -139,39 +139,39 @@ class executor_pool {
139139
public:
140140
template <typename Interface, typename Pool, typename... Ts>
141141
static void init(size_t number_of_executors, Ts ... executor_args) {
142-
executor_pool_implementation<Interface, Pool>::init(number_of_executors,
142+
pool_manager<Interface, Pool>::init(number_of_executors,
143143
executor_args...);
144144
}
145145
template <typename Interface, typename Pool, typename... Ts>
146146
static void init_all_executor_pools(size_t number_of_executors, Ts ... executor_args) {
147-
executor_pool_implementation<Interface, Pool>::init_all_executor_pools(number_of_executors,
147+
pool_manager<Interface, Pool>::init_all_executor_pools(number_of_executors,
148148
executor_args...);
149149
}
150150
template <typename Interface, typename Pool, typename... Ts>
151151
static void init_executor_pool(size_t pool_id, size_t number_of_executors, Ts ... executor_args) {
152-
executor_pool_implementation<Interface, Pool>::init_executor_pool(pool_id, number_of_executors,
152+
pool_manager<Interface, Pool>::init_executor_pool(pool_id, number_of_executors,
153153
executor_args...);
154154
}
155155
template <typename Interface, typename Pool> static void cleanup() {
156-
executor_pool_implementation<Interface, Pool>::cleanup();
156+
pool_manager<Interface, Pool>::cleanup();
157157
}
158158
template <typename Interface, typename Pool>
159159
static std::tuple<Interface &, size_t> get_interface(const size_t gpu_id) {
160-
return executor_pool_implementation<Interface, Pool>::get_interface(gpu_id);
160+
return pool_manager<Interface, Pool>::get_interface(gpu_id);
161161
}
162162
template <typename Interface, typename Pool>
163163
static void release_interface(size_t index, const size_t gpu_id) noexcept {
164-
executor_pool_implementation<Interface, Pool>::release_interface(index,
164+
pool_manager<Interface, Pool>::release_interface(index,
165165
gpu_id);
166166
}
167167
template <typename Interface, typename Pool>
168168
static bool interface_available(size_t load_limit, const size_t gpu_id) noexcept {
169-
return executor_pool_implementation<Interface, Pool>::interface_available(
169+
return pool_manager<Interface, Pool>::interface_available(
170170
load_limit, gpu_id);
171171
}
172172
template <typename Interface, typename Pool>
173173
static size_t get_current_load(const size_t gpu_id = 0) noexcept {
174-
return executor_pool_implementation<Interface, Pool>::get_current_load(
174+
return pool_manager<Interface, Pool>::get_current_load(
175175
gpu_id);
176176
}
177177
template <typename Interface, typename Pool>
@@ -182,19 +182,19 @@ class executor_pool {
182182

183183
template <typename Interface, typename Pool>
184184
static void set_device_selector(std::function<void(size_t)> select_gpu_function) {
185-
executor_pool_implementation<Interface, Pool>::set_device_selector(select_gpu_function);
185+
pool_manager<Interface, Pool>::set_device_selector(select_gpu_function);
186186
}
187187

188188
template <typename Interface, typename Pool>
189189
static void select_device(size_t gpu_id) {
190-
executor_pool_implementation<Interface, Pool>::select_device(gpu_id);
190+
pool_manager<Interface, Pool>::select_device(gpu_id);
191191
}
192192

193193
private:
194194
executor_pool() = default;
195195

196196
private:
197-
template <typename Interface, typename Pool> class executor_pool_implementation {
197+
template <typename Interface, typename Pool> class pool_manager {
198198
public:
199199
/// Deprecated! Use init_on_all_gpu or init_on_gpu
200200
template <typename... Ts>
@@ -277,7 +277,7 @@ class executor_pool {
277277
}
278278

279279
private:
280-
executor_pool_implementation() = default;
280+
pool_manager() = default;
281281
cppuddle::mutex_t pool_mut{};
282282
std::function<void(size_t)> select_gpu_function = [](size_t gpu_id) {
283283
// By default no multi gpu support
@@ -288,21 +288,21 @@ class executor_pool {
288288
std::deque<Pool> executorpools{};
289289
std::array<cppuddle::mutex_t, cppuddle::max_number_gpus> gpu_mutexes;
290290

291-
static executor_pool_implementation& instance(void) {
292-
static executor_pool_implementation pool_instance{};
291+
static pool_manager& instance(void) {
292+
static pool_manager pool_instance{};
293293
return pool_instance;
294294
}
295295

296296
public:
297-
~executor_pool_implementation() = default;
297+
~pool_manager() = default;
298298
// Bunch of constructors we don't need
299-
executor_pool_implementation(executor_pool_implementation const &other) =
299+
pool_manager(pool_manager const &other) =
300300
delete;
301-
executor_pool_implementation &
302-
operator=(executor_pool_implementation const &other) = delete;
303-
executor_pool_implementation(executor_pool_implementation &&other) = delete;
304-
executor_pool_implementation &
305-
operator=(executor_pool_implementation &&other) = delete;
301+
pool_manager &
302+
operator=(pool_manager const &other) = delete;
303+
pool_manager(pool_manager &&other) = delete;
304+
pool_manager &
305+
operator=(pool_manager &&other) = delete;
306306
};
307307

308308
public:

include/kokkos_buffer_util.hpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@
1515
namespace recycler {
1616
template <typename kokkos_type, typename alloc_type, typename element_type>
1717
using aggregated_recycled_view [[deprecated(
18-
"Use aggregated_recycle_view from header recycling_kokkos_view.hpp "
19-
"instead")]] =
18+
"Use cppuddle::memory_recycling::aggregated_recycling_view from header "
19+
"recycling_kokkos_view.hpp instead")]] =
2020
cppuddle::memory_recycling::aggregated_recycling_view<kokkos_type, alloc_type, element_type>;
2121

2222
template <typename kokkos_type, typename alloc_type, typename element_type>
2323
using recycled_view [[deprecated(
24-
"Use recycle_view from header recycling_kokkos_view.hpp instead")]] =
24+
"Use cppuddle::memory_recycling::recycling_view from header "
25+
"recycling_kokkos_view.hpp instead")]] =
2526
cppuddle::memory_recycling::recycling_view<kokkos_type, alloc_type, element_type>;
2627

2728
} // end namespace recycler

0 commit comments

Comments
 (0)