Potentially fix CMAKE_CXX_COMPILER_ID handling.

Author: breyerml

CMakeLists.txt

@@ -217,7 +217,7 @@ find_package(OpenMP QUIET)
 if (OpenMP_FOUND)
     message(STATUS "Found OpenMP ${OpenMP_CXX_VERSION} to speed-up library utilities (like file parsing).")
     set(PLSSVM_FOUND_OPENMP_FOR_UTILITY ON)
-    if (${CMAKE_CXX_COMPILER_ID} MATCHES "MSVC")
+    if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
         message(STATUS "Setting MSVC specific OpenMP flags.")
         target_compile_options(${PLSSVM_BASE_LIBRARY_NAME} PUBLIC -openmp:llvm -openmp:experimental)
         target_link_libraries(${PLSSVM_BASE_LIBRARY_NAME} PUBLIC -openmp:llvm -openmp:experimental)

src/plssvm/backends/Kokkos/CMakeLists.txt

@@ -37,7 +37,7 @@ target_link_libraries(${PLSSVM_KOKKOS_BACKEND_LIBRARY_NAME} PUBLIC Kokkos::kokko
 
 if (Kokkos_ENABLE_SYCL)
     # set SYCL (icpx) specific compilation flags
-    if (NOT ${CMAKE_CXX_COMPILER_ID} MATCHES "IntelLLVM")
+    if (NOT CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
         message(FATAL_ERROR "For Kokkos::SYCL to work, the compiler must be IntelLLVM, but is ${CMAKE_CXX_COMPILER}!")
     endif ()
 

src/plssvm/backends/OpenMP/CMakeLists.txt

@@ -38,7 +38,7 @@ set_local_and_parent(PLSSVM_OPENMP_BACKEND_LIBRARY_NAME plssvm-OpenMP)
 add_library(${PLSSVM_OPENMP_BACKEND_LIBRARY_NAME} SHARED ${PLSSVM_OPENMP_SOURCES})
 
 # link against OpenMP
-if (${CMAKE_CXX_COMPILER_ID} MATCHES "MSVC")
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
     # ~~~
     # special command line options for MSVC:
     # - openmp:llvm -> enables unsigned loop indexes in OpenMP parallel for loops
@@ -53,7 +53,7 @@ endif ()
 target_compile_options(${PLSSVM_OPENMP_BACKEND_LIBRARY_NAME} PRIVATE $<$<COMPILE_LANG_AND_ID:CXX,GNU,Clang,IntelLLVM>:-Wconversion>)
 
 # work-around since hipcc doesn't define _OPENMP
-if (${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
+if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     # hipcc must be clang
     execute_process(COMMAND ${CMAKE_CXX_COMPILER} --version OUTPUT_VARIABLE PLSSVM_CLANG_VERSION_OUTPUT)
     # check if version message contains hipcc specific values

src/plssvm/backends/SYCL/DPCPP/CMakeLists.txt

@@ -8,10 +8,10 @@ message(CHECK_START "Checking for DPC++ as SYCL implementation")
 
 # check if current compiler is Intel's clang llvm fork aka DPC++
 set(PLSSVM_SYCL_BACKEND_CHECK_FOR_DPCPP_COMPILER OFF)
-if (${CMAKE_CXX_COMPILER_ID} MATCHES "IntelLLVM")
+if (CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
     message(STATUS "Found Intel icpx compiler.")
     set(PLSSVM_SYCL_BACKEND_CHECK_FOR_DPCPP_COMPILER ON)
-elseif (${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
+elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     # intel llvm fork must be clang
     execute_process(COMMAND ${CMAKE_CXX_COMPILER} --help OUTPUT_VARIABLE PLSSVM_DPCPP_CLANG_HELP_OUTPUT)
     # check if help message contains DPC++ specific values