Skip to content

#3081 Fixed tables layouts in Publisher edit view #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Patrykb0802 wants to merge 1 commit into
base: release/2.8.0
Choose a base branch
from
Open

#3081 Fixed tables layouts in Publisher edit view #3190

Patrykb0802 wants to merge 1 commit into from

Conversation

@Patrykb0802
Copy link
Contributor

@Patrykb0802 Patrykb0802 commented Sep 10, 2025 •
edited by coderabbitai bot
Loading

before:

image

after:

image

Summary by CodeRabbit

  • Style
    • Made minor layout adjustments to improve visual presentation and spacing of UI elements.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✅ ±0   3s ⏱️ ±0s
 70 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0ec9b34. ± Comparison against base commit de92ac5.

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

Java JUnit Test Results

3 220 tests  ±0   3 220 ✅ ±0   50s ⏱️ -1s
  128 suites ±0       0 💤 ±0 
  128 files   ±0       0 ❌ ±0 

Results for commit 0ec9b34. ± Comparison against base commit de92ac5.

@Limraj Limraj modified the milestones: 2.8.1, 2.8.2 Jan 5, 2026
@Patrykb0802
Copy link
Contributor Author

Patrykb0802 commented Jan 13, 2026

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

A JSP file's table layout receives minor styling adjustments: width styles are added to the outer table and its first cell, and the colspan of the selectedPointsEmpty row is reduced from 5 to 4.

Changes

Cohort / File(s) Summary
Layout adjustments
WebContent/WEB-INF/jsp/publisherEdit/editPersistent.jsp		 Added width styles to table and cell; adjusted colspan from 5 to 4 on selectedPointsEmpty row

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A table finds its perfect width,
Columns align with stylish gifts,
No logic bent, no code recast—
Just prettier layouts that will last! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '#3081 Fixed tables layouts in Publisher edit view' accurately describes the main change: layout/style fixes to tables in the Publisher edit view JSP file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de92ac5 and 0ec9b34.

📒 Files selected for processing (1)
  • WebContent/WEB-INF/jsp/publisherEdit/editPersistent.jsp
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-01-06T22:12:13.613Z 
Learnt from: Limraj
Repo: SCADA-LTS/Scada-LTS PR: 3239
File: WebContent/WEB-INF/jsp/eventHandlers.jsp:275-282
Timestamp: 2026-01-06T22:12:13.613Z
Learning: In WebContent/WEB-INF/jsp/eventHandlers.jsp, when editing an existing event handler in showHandlerEdit(), targetPoint being null/undefined is considered an invalid state (data integrity violation) because if a handler exists with a targetPointId, the corresponding point is guaranteed to exist in allPoints. The maintainer has asserted this architectural invariant.

Applied to files:

  • WebContent/WEB-INF/jsp/publisherEdit/editPersistent.jsp
🔇 Additional comments (2)
WebContent/WEB-INF/jsp/publisherEdit/editPersistent.jsp (2)

195-195: LGTM!

The width styles ensure the table and its cell expand to fill the available container width, which is appropriate for layout consistency.

207-214: Correct fix for colspan mismatch.

The table has 4 columns (name, status, type, and delete action), so colspan="4" is correct. The previous value of 5 was a bug that could cause layout misalignment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Limraj Limraj Awaiting requested review from Limraj Limraj is a code owner

@SoftQ SoftQ Awaiting requested review from SoftQ SoftQ is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Patrykb0802 @Limraj