Skip to content

Commit 2f6270d

Browse files
committed
Improve default color support
1 parent abc5b13 commit 2f6270d

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

src/ExampleNets/regression/basicViz.srn5

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
<name>DefaultMeshColor</name>
139139
<value>
140140
<which>2</which>
141-
<value>Color(160,160,164)</value>
141+
<value>Color(0.831373,0.15552,0.123156)</value>
142142
</value>
143143
</second>
144144
</item>
@@ -186,7 +186,7 @@
186186
<name>FaceTransparency</name>
187187
<value>
188188
<which>3</which>
189-
<value>0</value>
189+
<value>1</value>
190190
</value>
191191
</second>
192192
</item>

src/Interface/Modules/Visualization/ShowFieldDialog.cc

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ ShowFieldDialog::ShowFieldDialog(const std::string& name, ModuleStateHandle stat
7373
connectButtonToExecuteSignal(edgesAsCylindersButton_);
7474
connectButtonToExecuteSignal(nodesAsPointsButton_);
7575
connectButtonToExecuteSignal(nodesAsSpheresButton_);
76-
76+
7777
//default values
7878
cylinder_rad_spin->setValue(1.0);
7979
cylinder_res_spin->setValue(5);
@@ -122,10 +122,12 @@ void ShowFieldDialog::pull()
122122
pull_newVersionToReplaceOld();
123123
Pulling p(this);
124124
ColorRGB color(state_->getValue(ShowFieldModule::DefaultMeshColor).toString());
125+
//std::cout << "pull color: " << color.r() << " " << color.g() << " " << color.b() << std::endl;
126+
// check for old saved color format: integers 0-255.
125127
defaultMeshColor_ = QColor(
126-
static_cast<int>(color.r() * 255.0),
127-
static_cast<int>(color.g() * 255.0),
128-
static_cast<int>(color.b() * 255.0));
128+
static_cast<int>(color.r() > 1 ? color.r() : color.r() * 255.0),
129+
static_cast<int>(color.g() > 1 ? color.g() : color.g() * 255.0),
130+
static_cast<int>(color.b() > 1 ? color.b() : color.b() * 255.0));
129131
}
130132

131133
void ShowFieldDialog::assignDefaultMeshColor()
@@ -142,5 +144,7 @@ void ShowFieldDialog::assignDefaultMeshColor()
142144

143145
void ShowFieldDialog::pushColor()
144146
{
145-
state_->setValue(ShowFieldModule::DefaultMeshColor, ColorRGB(defaultMeshColor_.red() / 255.0, defaultMeshColor_.green() / 255.0, defaultMeshColor_.blue() / 255.0).toString());
147+
//std::cout << "push color: " << defaultMeshColor_.redF() << " " << defaultMeshColor_.greenF() << " " << defaultMeshColor_.blueF() << std::endl;
148+
state_->setValue(ShowFieldModule::DefaultMeshColor, ColorRGB(defaultMeshColor_.redF(), defaultMeshColor_.greenF(), defaultMeshColor_.blueF()).toString());
149+
Q_EMIT executeActionTriggered();
146150
}

0 commit comments

Comments
 (0)