Skip to content

Commit 36491d5

Browse files
committed
Toolbar
1 parent e675ebb commit 36491d5

File tree

4 files changed

+36
-24
lines changed

4 files changed

+36
-24
lines changed

src/Interface/Application/NetworkEditor.cc

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,6 +1033,12 @@ void NetworkEditor::fillModulePositionMap(ModulePositions& positions, ModuleFilt
10331033

10341034
void NetworkEditor::centerView()
10351035
{
1036+
if (!isActiveWindow())
1037+
{
1038+
tailRecurse(boost::bind(&NetworkEditor::centerView, _1));
1039+
return;
1040+
}
1041+
10361042
ModulePositions positions;
10371043
fillModulePositionMap(positions, boost::lambda::constant(true));
10381044
centerOn(findCenterOfNetwork(positions));
@@ -1471,7 +1477,10 @@ QPixmap NetworkEditor::sceneGrab()
14711477
void NetworkEditor::selectAll()
14721478
{
14731479
if (!isActiveWindow())
1480+
{
1481+
tailRecurse(boost::bind(&NetworkEditor::selectAll, _1));
14741482
return;
1483+
}
14751484

14761485
Q_FOREACH(QGraphicsItem* item, scene_->items())
14771486
{
@@ -1481,6 +1490,12 @@ void NetworkEditor::selectAll()
14811490

14821491
void NetworkEditor::pinAllModuleUIs()
14831492
{
1493+
if (!isActiveWindow())
1494+
{
1495+
tailRecurse(boost::bind(&NetworkEditor::pinAllModuleUIs, _1));
1496+
return;
1497+
}
1498+
14841499
Q_FOREACH(QGraphicsItem* item, scene_->items())
14851500
{
14861501
auto module = getModule(item);
@@ -1491,6 +1506,12 @@ void NetworkEditor::pinAllModuleUIs()
14911506

14921507
void NetworkEditor::hideAllModuleUIs()
14931508
{
1509+
if (!isActiveWindow())
1510+
{
1511+
tailRecurse(boost::bind(&NetworkEditor::hideAllModuleUIs, _1));
1512+
return;
1513+
}
1514+
14941515
Q_FOREACH(QGraphicsItem* item, scene_->items())
14951516
{
14961517
auto module = getModule(item);
@@ -1501,6 +1522,12 @@ void NetworkEditor::hideAllModuleUIs()
15011522

15021523
void NetworkEditor::restoreAllModuleUIs()
15031524
{
1525+
if (!isActiveWindow())
1526+
{
1527+
tailRecurse(boost::bind(&NetworkEditor::restoreAllModuleUIs, _1));
1528+
return;
1529+
}
1530+
15041531
Q_FOREACH(QGraphicsItem* item, scene_->items())
15051532
{
15061533
auto module = getModule(item);

src/Interface/Application/SCIRunMainWindow.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ class SCIRunMainWindow : public QMainWindow, public Ui::SCIRunMainWindow
8282
void addToDataDirectory(const QString& dir);
8383
void setCurrentFile(const QString& fileName);
8484
void addToolkit(const QString& filename, const QString& directory, const SCIRun::Dataflow::Networks::ToolkitFile& toolkit);
85+
void addNetworkActionsToBar(QToolBar* toolbar) const;
8586

8687
//TODO: extract another interface for command objects
8788
NetworkEditor* networkEditor() { return networkEditor_; }
@@ -137,7 +138,6 @@ public Q_SLOTS:
137138
void createStandardToolbars();
138139
void createExecuteToolbar();
139140
void createAdvancedToolbar();
140-
void addNetworkActionsToBar(QToolBar* toolbar) const;
141141
void postConstructionSignalHookup();
142142
void executeCommandLineRequests();
143143
void setTipsAndWhatsThis();

src/Interface/Application/SubnetEditor.ui

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,6 @@
2323
<property name="spacing">
2424
<number>-1</number>
2525
</property>
26-
<item>
27-
<widget class="QPushButton" name="openAllPushButton_">
28-
<property name="maximumSize">
29-
<size>
30-
<width>220</width>
31-
<height>25</height>
32-
</size>
33-
</property>
34-
<property name="text">
35-
<string>Open all module UIs</string>
36-
</property>
37-
</widget>
38-
</item>
3926
<item>
4027
<widget class="QPushButton" name="expandPushButton_">
4128
<property name="maximumSize">

src/Interface/Application/Subnetworks.cc

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,7 @@ editor_(editor), name_(name), subnetModuleId_(subnetModuleId)
9191
auto subnetBar = new QToolBar("Subnet");
9292
WidgetStyleMixin::toolbarStyle(subnetBar);
9393
subnetBar->setObjectName("SubnetToolbar");
94-
95-
subnetBar->addAction("hi");
96-
subnetBar->addAction("bye");
94+
SCIRunMainWindow::Instance()->addNetworkActionsToBar(subnetBar);
9795
vbox->setMenuBar(subnetBar);
9896

9997
saveAsTemplatePushButton_->hide();
@@ -208,7 +206,7 @@ NetworkEditor* NetworkEditor::inEditingContext_(nullptr);
208206
NetworkEditor::ConnectorFunc NetworkEditor::connectorFunc_;
209207

210208
std::function<QPointF(const QRectF&)> NetworkEditor::topSubnetPortHolderPositioner_([](const QRectF& rect) { return rect.topLeft(); });
211-
std::function<QPointF(const QRectF&)> NetworkEditor::bottomSubnetPortHolderPositioner_([](const QRectF& rect) { return rect.bottomLeft() + QPointF(0, -23); });
209+
std::function<QPointF(const QRectF&)> NetworkEditor::bottomSubnetPortHolderPositioner_([](const QRectF& rect) { return rect.bottomLeft() + QPointF(0, -40); });
212210

213211
void NetworkEditor::setupPortHolder(const std::vector<SharedPointer<PortDescriptionInterface>>& ports, const QString& name, std::function<QPointF(const QRectF&)> position)
214212
{
@@ -263,15 +261,15 @@ void NetworkEditor::setupPortHolder(const std::vector<SharedPointer<PortDescript
263261
scene_->addItem(proxy);
264262
subnetPortHolders_.append(proxy);
265263

266-
proxy->setPos(position(visible));
264+
proxy->setPos(position(visibleRect()));
267265
}
268266

269267
SubnetInputPortWidget::SubnetInputPortWidget(const QString& name, const QColor& color, const std::string& datatype,
270268
boost::function<boost::shared_ptr<ConnectionFactory>()> connectionFactory,
271269
boost::function<boost::shared_ptr<ClosestPortFinder>()> closestPortFinder,
272270
PortDescriptionInterface* realPort,
273271
QWidget* parent)
274-
: InputPortWidget(name, color, datatype, ModuleId(), PortId(), 0, false, connectionFactory, closestPortFinder, {}, parent), realPort_(realPort)
272+
: InputPortWidget(name, color, datatype, ModuleId(), PortId(), 0, true, connectionFactory, closestPortFinder, {}, parent), realPort_(realPort)
275273

276274
{
277275

@@ -283,7 +281,7 @@ SubnetOutputPortWidget::SubnetOutputPortWidget(const QString& name, const QColor
283281
boost::function<boost::shared_ptr<ClosestPortFinder>()> closestPortFinder,
284282
PortDescriptionInterface* realPort,
285283
QWidget* parent)
286-
: OutputPortWidget(name, color, datatype, ModuleId(), PortId(), 0, false, connectionFactory, closestPortFinder, {}, parent), realPort_(realPort)
284+
: OutputPortWidget(name, color, datatype, ModuleId(), PortId(), 0, true, connectionFactory, closestPortFinder, {}, parent), realPort_(realPort)
287285
{
288286

289287
}
@@ -325,12 +323,12 @@ void NetworkEditor::initializeSubnet(const QString& name, ModuleHandle mod, Netw
325323
connectorFunc_(subnet);
326324
subnet->setupPortHolders(mod);
327325

328-
subnet->setSceneRect(QRectF());
329-
subnet->centerView();
330-
331326
auto dock = new SubnetworkEditor(subnet, mod->get_id(), name, nullptr);
332327
dock->setStyleSheet(SCIRunMainWindow::Instance()->styleSheet());
328+
//subnet->setSceneRect(QRectF());
329+
333330
dock->show();
331+
subnet->centerView();
334332

335333
childrenNetworks_[name] = dock;
336334
}

0 commit comments

Comments
 (0)