Add dialog showing image, with checkbox option

Author: dcwhite

src/ExampleNets/regression/interfaceWithOspray.srn5

@@ -267,7 +267,7 @@
 					</module>
 					<state>
 						<stateMap>
-							<count>18</count>
+							<count>19</count>
 							<item_version>0</item_version>
 							<item>
 								<first>
@@ -337,7 +337,7 @@
 									<name>CameraPositionZ</name>
 									<value>
 										<which>1</which>
-										<value>-5.00000000000000000e+000</value>
+										<value>-2.00000000000000000e+000</value>
 									</value>
 								</second>
 							</item>
@@ -469,7 +469,7 @@
 									<name>ImageHeight</name>
 									<value>
 										<which>0</which>
-										<value>4000</value>
+										<value>600</value>
 									</value>
 								</second>
 							</item>
@@ -481,7 +481,19 @@
 									<name>ImageWidth</name>
 									<value>
 										<which>0</which>
-										<value>6000</value>
+										<value>800</value>
+									</value>
+								</second>
+							</item>
+							<item>
+								<first>
+									<name>ShowImageInWindow</name>
+								</first>
+								<second>
+									<name>ShowImageInWindow</name>
+									<value>
+										<which>3</which>
+										<value>1</value>
 									</value>
 								</second>
 							</item>

src/Interface/Modules/Visualization/InterfaceWithOspray.ui

@@ -421,6 +421,13 @@
      </layout>
     </widget>
    </item>
+   <item row="0" column="2">
+    <widget class="QCheckBox" name="showImageCheckBox_">
+     <property name="text">
+      <string>Show Image in new window</string>
+     </property>
+    </widget>
+   </item>
   </layout>
  </widget>
  <resources/>

src/Interface/Modules/Visualization/InterfaceWithOsprayDialog.cc

@@ -29,11 +29,13 @@
 #include <Interface/Modules/Visualization/InterfaceWithOsprayDialog.h>
 #include <Modules/Visualization/InterfaceWithOspray.h>
 #include <Dataflow/Network/ModuleStateInterface.h>
+#include <Core/Algorithms/Base/AlgorithmVariableNames.h>
 
 using namespace SCIRun::Gui;
 using namespace SCIRun::Dataflow::Networks;
 using namespace SCIRun::Core::Datatypes;
 using namespace SCIRun::Modules::Visualization;
+using namespace SCIRun::Core::Algorithms;
 using namespace SCIRun::Core::Algorithms::Visualization::Parameters;
 
 InterfaceWithOsprayDialog::InterfaceWithOsprayDialog(const std::string& name, ModuleStateHandle state,
@@ -62,6 +64,29 @@ InterfaceWithOsprayDialog::InterfaceWithOsprayDialog(const std::string& name, Mo
   addDoubleSpinBoxManager(backgroundColorRDoubleSpinBox_, BackgroundColorR);
   addDoubleSpinBoxManager(backgroundColorGDoubleSpinBox_, BackgroundColorG);
   addDoubleSpinBoxManager(backgroundColorBDoubleSpinBox_, BackgroundColorB);
+  addCheckBoxManager(showImageCheckBox_, ShowImageInWindow);
 
   createExecuteInteractivelyToggleAction();
+
+  state_->connectSpecificStateChanged(Variables::Filename, [this]() { imageFilenameChanged(); });
+  connect(this, SIGNAL(imageFilenameChanged()), this, SLOT(showImage()));
 }
+
+void InterfaceWithOsprayDialog::showImage()
+{
+  if (state_->getValue(ShowImageInWindow).toBool())
+  {
+    auto filename(QString::fromStdString(transient_value_cast<std::string>(state_->getTransientValue(Variables::Filename))));
+    QImage image(filename);
+    auto myLabel = new QLabel(parentWidget());
+    myLabel->setPixmap(QPixmap::fromImage(image));
+    myLabel->resize(myLabel->pixmap()->size());
+
+    auto d = new QDialog;
+    d->setWindowTitle("Ospray Scene Image");
+    auto layout = new QHBoxLayout;
+    layout->addWidget(myLabel);
+    d->setLayout(layout);
+    d->show();
+  }
+}

src/Interface/Modules/Visualization/InterfaceWithOsprayDialog.h

@@ -45,9 +45,11 @@ class SCISHARE InterfaceWithOsprayDialog : public ModuleDialogGeneric,
   InterfaceWithOsprayDialog(const std::string& name,
     SCIRun::Dataflow::Networks::ModuleStateHandle state,
     QWidget* parent = nullptr);
-protected:
-private Q_SLOTS:
 
+Q_SIGNALS:
+  void imageFilenameChanged();
+private Q_SLOTS:
+  void showImage();
 };
 
 }

src/Modules/Visualization/InterfaceWithOspray.cc

@@ -31,8 +31,11 @@ DEALINGS IN THE SOFTWARE.
 #include <Core/Datatypes/Legacy/Field/VField.h>
 #include <Core/Datatypes/ColorMap.h>
 #include <Core/Datatypes/Legacy/Field/Field.h>
+#include <Core/Datatypes/Legacy/Field/FieldInformation.h>
 #include <Core/Datatypes/Legacy/Field/VMesh.h>
 #include <Core/Datatypes/Mesh/VirtualMeshFacade.h>
+#include <Core/Algorithms/Base/AlgorithmVariableNames.h>
+
 #include <boost/date_time/posix_time/posix_time.hpp>
 
 #include <ospray/ospray.h>
@@ -63,6 +66,7 @@ ALGORITHM_PARAMETER_DEF(Visualization, BackgroundColorR);
 ALGORITHM_PARAMETER_DEF(Visualization, BackgroundColorG);
 ALGORITHM_PARAMETER_DEF(Visualization, BackgroundColorB);
 ALGORITHM_PARAMETER_DEF(Visualization, FrameCount);
+ALGORITHM_PARAMETER_DEF(Visualization, ShowImageInWindow);
 
 MODULE_INFO_DEF(InterfaceWithOspray, Visualization, SCIRun)
 
@@ -87,6 +91,7 @@ void InterfaceWithOspray::setStateDefaults()
   state->setValue(Parameters::BackgroundColorG, 0.0);
   state->setValue(Parameters::BackgroundColorB, 0.0);
   state->setValue(Parameters::FrameCount, 10);
+  state->setValue(Parameters::ShowImageInWindow, true);
 }
 
 namespace detail
@@ -225,15 +230,17 @@ namespace detail
     {
       FILE *file = fopen(fileName, "wb");
       fprintf(file, "P6\n%i %i\n255\n", size.x, size.y);
-      unsigned char *out = (unsigned char *)alloca(3 * size.x);
-      for (int y = 0; y < size.y; y++) {
+      std::vector<unsigned char> out(3 * size.x);
+      for (int y = 0; y < size.y; y++) 
+      {
         const unsigned char *in = (const unsigned char *)&pixel[(size.y - 1 - y)*size.x];
-        for (int x = 0; x < size.x; x++) {
+        for (int x = 0; x < size.x; x++) 
+        {
           out[3 * x + 0] = in[4 * x + 0];
           out[3 * x + 1] = in[4 * x + 1];
           out[3 * x + 2] = in[4 * x + 2];
         }
-        fwrite(out, 3 * size.x, sizeof(char), file);
+        fwrite(&out[0], 3 * size.x, sizeof(char), file);
       }
       fprintf(file, "\n");
       fclose(file);
@@ -256,10 +263,16 @@ void InterfaceWithOspray::execute()
 
   if (needToExecute())
   {
-    
-    auto isoString = boost::posix_time::to_iso_string(boost::posix_time::microsec_clock::universal_time());
+    FieldInformation info(field);
+
+    if (!info.is_trisurfmesh())
+      THROW_INVALID_ARGUMENT("Module currently only works with trisurfs.");
 
-    impl_->writeImage(field, "scirunOsprayOutput_" + isoString + ".ppm", get_state(), colorMap);
+    auto isoString = boost::posix_time::to_iso_string(boost::posix_time::microsec_clock::universal_time());
+    auto filename = "scirunOsprayOutput_" + isoString + ".ppm";
+    remark("Saving output to " + filename);
+    impl_->writeImage(field, filename, get_state(), colorMap);
+    get_state()->setTransientValue(Variables::Filename, filename);
 
     //auto geom = builder_->buildGeometryObject(field, colorMap, *this, this);
     //sendOutput(SceneGraph, geom);

src/Modules/Visualization/InterfaceWithOspray.h

@@ -64,6 +64,7 @@ namespace SCIRun {
         ALGORITHM_PARAMETER_DECL(BackgroundColorG);
         ALGORITHM_PARAMETER_DECL(BackgroundColorB);
         ALGORITHM_PARAMETER_DECL(FrameCount);
+        ALGORITHM_PARAMETER_DECL(ShowImageInWindow);
       }
     }
   }