Skip to content

Commit 43e8380

Browse files
committed
Change signal again, disable combo box signalling execute for now.
1 parent 1681fe5 commit 43e8380

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/Interface/Modules/Base/ModuleDialogGeneric.cc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,14 @@ void ModuleDialogGeneric::connectButtonToExecuteSignal(QAbstractButton* button)
8282

8383
void ModuleDialogGeneric::connectComboToExecuteSignal(QComboBox* box)
8484
{
85-
connect(box, SIGNAL(activated(const QString&)), this, SIGNAL(executeActionTriggered()));
85+
/*
86+
connect(box, SIGNAL(currentIndexChanged(const QString&)), this, SIGNAL(executeActionTriggered()));
8687
if (disablerAdd_ && disablerRemove_)
8788
{
8889
disablerAdd_(box);
8990
needToRemoveFromDisabler_.push_back(box);
9091
}
92+
*/
9193
}
9294

9395
void ModuleDialogGeneric::updateWindowTitle(const QString& title)
@@ -201,7 +203,7 @@ class ComboBoxSlotManager : public WidgetSlotManager
201203
ToQStringConverter toLabelConverter = &QString::fromStdString) :
202204
WidgetSlotManager(state, dialog), stateKey_(stateKey), comboBox_(comboBox), fromLabelConverter_(fromLabelConverter), toLabelConverter_(toLabelConverter)
203205
{
204-
connect(comboBox, SIGNAL(activated(const QString&)), this, SLOT(push()));
206+
connect(comboBox, SIGNAL(currentIndexChanged(const QString&)), this, SLOT(push()));
205207
}
206208
ComboBoxSlotManager(ModuleStateHandle state, ModuleDialogGeneric& dialog, const AlgorithmParameterName& stateKey, QComboBox* comboBox,
207209
const GuiStringTranslationMap& stringMap) :
@@ -213,7 +215,7 @@ class ComboBoxSlotManager : public WidgetSlotManager
213215
}
214216
fromLabelConverter_ = [this](const QString& qstr) { return findOrFirst(stringMap_.left, qstr.toStdString()); };
215217
toLabelConverter_ = [this](const std::string& str) { return QString::fromStdString(findOrFirst(stringMap_.right, str)); };
216-
connect(comboBox, SIGNAL(activated(const QString&)), this, SLOT(push()));
218+
connect(comboBox, SIGNAL(currentIndexChanged(const QString&)), this, SLOT(push()));
217219
}
218220
virtual void pull() override
219221
{

0 commit comments

Comments
 (0)