Fix crashes; subnets always on top

dcwhite · dcwhite · commit 5655a894f852 · 2017-06-21T02:58:27.000-06:00
diff --git a/src/ExampleNets/regression/subnet3.srn5 b/src/ExampleNets/regression/subnet3.srn5
diff --git a/src/Interface/Application/ModuleWidget.cc b/src/Interface/Application/ModuleWidget.cc
@@ -458,21 +458,14 @@ void ModuleWidget::resizeBasedOnModuleName(ModuleWidgetDisplayBase* display, int
 {
   auto frame = this;
   int pixelWidth = display->getTitleWidth();
-  //qDebug() << moduleId_.c_str();
-  //qDebug() << "\tPixelwidth = " << pixelWidth;
   int extraWidth = pixelWidth - ModuleWidgetDisplayBase::moduleWidthThreshold;
-  //qDebug() << "\textraWidth = " << extraWidth;
   if (extraWidth > ModuleWidgetDisplayBase::extraWidthThreshold)
   {
-    //qDebug() << "\tGROWING MODULE Current width: " << frame->width();
     frame->resize(frame->width() + extraWidth + ModuleWidgetDisplayBase::extraModuleWidth, frame->height());
-    //qDebug() << "\tNew width: " << frame->width();
   }
   else
   {
-    //qDebug() << "\tSHRINKING MODULE Current width: " << frame->width();
     frame->resize(frame->width() - ModuleWidgetDisplayBase::smushFactor, frame->height());
-    //qDebug() << "\tNew width: " << frame->width();
   }
 }
 
@@ -571,7 +564,6 @@ void ModuleWidget::fillReplaceWithMenu()
 
 void ModuleWidget::menuFunction()
 {
-  qDebug() << "ModuleWidget::menuFunction";
   // fullWidgetDisplay_->getModuleActionButton()->setMenu(nullptr);
   // actionsMenu_.reset();
 }
@@ -744,7 +736,6 @@ void ModuleWidget::addOutputPortsToWidget(int index)
   }
   else
   {
-    qDebug() << "OOPS NO OUTPUT PORTS";
   }
 }
 
@@ -811,7 +802,6 @@ void ModuleWidget::addInputPortsToWidget(int index)
   }
   else
   {
-    qDebug() << "OOPS NO INPUT PORTS";
   }
 }
 
diff --git a/src/Interface/Application/ModuleWidget.h b/src/Interface/Application/ModuleWidget.h
@@ -312,9 +312,11 @@ class SubnetWidget : public ModuleWidget
   SubnetWidget(NetworkEditor* ed, const QString& name, Dataflow::Networks::ModuleHandle theModule, boost::shared_ptr<DialogErrorControl> dialogErrorControl, QWidget* parent = nullptr);
   ~SubnetWidget();
   void postLoadAction() override;
+  void deleteSubnetImmediately() { deleteSubnetImmediately_ = true; }
 private:
   NetworkEditor* editor_;
   QString name_;
+  bool deleteSubnetImmediately_{ false };
 };
 
 class SubnetPortsBridgeWidget : public QWidget
diff --git a/src/Interface/Application/NetworkEditor.cc b/src/Interface/Application/NetworkEditor.cc
@@ -404,13 +404,10 @@ ModuleProxyWidget* NetworkEditor::setupModuleWidget(ModuleWidget* module)
 
   if (highResolutionExpandFactor_ > 1)
   {
-    //qDebug() << "module widget expand factor:" << highResolutionExpandFactor_;
-    //qDebug() << proxy->size();
     module->setFixedHeight(proxy->size().height() * highResolutionExpandFactor_);
     proxy->setMaximumHeight(proxy->size().height() * highResolutionExpandFactor_);
     module->setFixedWidth(proxy->size().width() * std::max(highResolutionExpandFactor_*0.9, 1.0));
     proxy->setMaximumWidth(proxy->size().width() * std::max(highResolutionExpandFactor_*0.9, 1.0));
-    //qDebug() << proxy->size();
   }
 
   scene_->addItem(proxy);
@@ -543,7 +540,13 @@ void NetworkEditor::del()
   if (!isActiveWindow())
     return;
 
-  auto items = scene_->selectedItems();
+  deleteImpl(scene_->selectedItems());
+  updateViewport();
+  Q_EMIT modified();
+}
+
+void NetworkEditor::deleteImpl(QList<QGraphicsItem*> items)
+{
   QMutableListIterator<QGraphicsItem*> i(items);
   while (i.hasNext())
   {
@@ -556,8 +559,6 @@ void NetworkEditor::del()
     }
   }
   qDeleteAll(items);
-  updateViewport();
-  Q_EMIT modified();
 }
 
 void NetworkEditor::cut()
@@ -832,7 +833,6 @@ class NetworkSearchEngine
       }
       else
       {
-        //qDebug() << "something else";
       }
       results.insert(results.end(), subresults.begin(), subresults.end());
     }
@@ -1325,7 +1325,16 @@ void NetworkEditor::clear()
 {
   tagLabelOverrides_.clear();
   ModuleWidget::NetworkClearingScope clearing;
-  //auto portSwitch = createDynamicPortDisabler();
+
+  QList<QGraphicsItem*> deleteTheseFirst;
+  Q_FOREACH(QGraphicsItem* item, scene_->items())
+  {
+    if (auto s = dynamic_cast<SubnetWidget*>(getModule(item)))
+    {
+      deleteTheseFirst.append(item);
+    }
+  }
+  deleteImpl(deleteTheseFirst);
   scene_->clear();
   //TODO: this (unwritten) method does not need to be called here.  the dtors of all the module widgets get called when the scene_ is cleared, which triggered removal from the underlying network.
   // we'll need a similar hook when programming the scripting interface (moduleWidgets<->modules).
@@ -1642,7 +1651,6 @@ void NetworkEditor::zoomBestFit()
   auto oldRect = sceneRect();
   setSceneRect(QRectF());
   fitInView(sceneRect(), Qt::KeepAspectRatio);
-  //qDebug() << "old rect: " << oldRect << "new rect:" << sceneRect();
   currentScale_ *= sceneRect().x() / oldRect.x();
   //scale(1.0 / currentScale_, 1.0 / currentScale_);
   //currentScale_ = 1;
diff --git a/src/Interface/Application/NetworkEditor.h b/src/Interface/Application/NetworkEditor.h
@@ -262,7 +262,7 @@ namespace Gui {
 
     NetworkEditor* parentNetwork() { return parentNetwork_; }
     size_t childCount() const { return childrenNetworks_.size(); }
-    void killChild(const QString& name);
+    void killChild(const QString& name, bool force);
     void sendItemsToParent();
     bool containsModule(const std::string& moduleId) const;
 
@@ -377,6 +377,7 @@ namespace Gui {
     void dumpSubnetworksImpl(const QString& name, Dataflow::Networks::Subnetworks& data, Dataflow::Networks::ModuleFilter modFilter) const;
     QList<QGraphicsItem*> includeConnections(QList<QGraphicsItem*> items) const;
     QRectF visibleRect() const;
+    void deleteImpl(QList<QGraphicsItem*> items);
 
     // default constructed
     bool modulesSelectedByCL_{ false };
diff --git a/src/Interface/Application/Port.cc b/src/Interface/Application/Port.cc
@@ -289,7 +289,6 @@ void PortWidget::doMousePress(Qt::MouseButton button, const QPointF& pos)
   }
   else
   {
-    //qDebug() << "mouse press sth else";
   }
 }
 
@@ -308,7 +307,6 @@ QGraphicsItem* PortWidget::doMouseMove(Qt::MouseButtons buttons, const QPointF&
   }
   else
   {
-    //qDebug() << "mouse move sth else";
   }
   return nullptr;
 }
@@ -341,7 +339,6 @@ void PortWidget::doMouseRelease(Qt::MouseButton button, const QPointF& pos, Qt::
   }
   else
   {
-    //qDebug() << "mouse release sth else";
   }
 }
 
diff --git a/src/Interface/Application/SCIRunMainWindow.cc b/src/Interface/Application/SCIRunMainWindow.cc
@@ -618,7 +618,6 @@ bool SCIRunMainWindow::loadNetworkFile(const QString& filename, bool isTemporary
     if (command.execute())
     {
       networkProgressBar_->updateTotalModules(networkEditor_->numModules());
-
       if (!isTemporary)
       {
         setCurrentFile(filename);
diff --git a/src/Interface/Application/Subnetworks.cc b/src/Interface/Application/Subnetworks.cc
@@ -65,8 +65,10 @@ NetworkEditor::~NetworkEditor()
   {
     child.second->get()->controller_.reset();
     delete child.second->get();
+    delete child.second;
     child.second = nullptr;
   }
+  childrenNetworks_.clear();
 
   Q_FOREACH(QGraphicsItem* item, scene_->items())
   {
@@ -363,7 +365,7 @@ void NetworkEditor::initializeSubnet(const QString& name, ModuleHandle mod, Netw
 
   auto dock = new SubnetworkEditor(subnet, mod->get_id(), name, nullptr);
   dock->setStyleSheet(SCIRunMainWindow::Instance()->styleSheet());
-
+  dock->setWindowFlags(dock->windowFlags() | Qt::WindowStaysOnTopHint);
   dock->show();
   subnet->centerView();
 
@@ -733,7 +735,7 @@ SubnetWidget::SubnetWidget(NetworkEditor* ed, const QString& name, ModuleHandle
 
 SubnetWidget::~SubnetWidget()
 {
-  editor_->killChild(name_);
+  editor_->killChild(name_, deleteSubnetImmediately_);
 }
 
 SubnetPortsBridgeWidget::SubnetPortsBridgeWidget(NetworkEditor* ed, const QString& name, QWidget* parent /* = 0 */) :
@@ -744,13 +746,16 @@ SubnetPortsBridgeWidget::SubnetPortsBridgeWidget(NetworkEditor* ed, const QStrin
   setStyleSheet(rounded + " background-color: darkGray");
 }
 
-void NetworkEditor::killChild(const QString& name)
+void NetworkEditor::killChild(const QString& name, bool force)
 {
   auto subnetIter = childrenNetworks_.find(name);
   if (subnetIter != childrenNetworks_.end())
   {
     subnetIter->second->get()->clear();
-    subnetIter->second->deleteLater();
+    if (force)
+      delete subnetIter->second;
+    else
+      subnetIter->second->deleteLater();
     childrenNetworks_.erase(subnetIter);
     currentSubnetNames_.remove(name);
   }
@@ -802,7 +807,6 @@ bool SubnetModuleConnector::signalFromSubnet(QObject* sender) const
 
 void SubnetModuleConnector::moduleAddedToSubnet(const std::string& s, ModuleHandle module)
 {
-  //qDebug() << __FUNCTION__ << sender() << signalFromSubnet(sender()) << signalFromParent(sender());
   if (signalFromSubnet(sender()) && subnet_->containsModule(module->get_id().id_))
   {
     qDebug() << "was:" << module_->underlyingModules_.size();
@@ -824,5 +828,4 @@ bool NetworkEditor::containsModule(const std::string& id) const
 
 void SubnetModuleConnector::connectionDeletedFromParent()
 {
-  qDebug() << __FUNCTION__;
 }
diff --git a/src/Interface/Modules/Base/ModuleButtonBar.cc b/src/Interface/Modules/Base/ModuleButtonBar.cc
@@ -69,7 +69,6 @@ void ModuleButtonBar::setTitleVisible(bool visible)
 void ModuleButtonBar::switchIcons()
 {
   //TODO
-  //qDebug() << collapseToolButton_->styleSheet();
   //collapseToolButton_->setIcon(QApplication::style()->standardIcon(QStyle::SP_TitleBarShadeButton));
   //collapseToolButton_->setIcon(QApplication::style()->standardIcon(QStyle::SP_TitleBarUnshadeButton));
 }
diff --git a/src/Interface/Modules/Base/ModuleDialogGeneric.cc b/src/Interface/Modules/Base/ModuleDialogGeneric.cc
@@ -881,12 +881,8 @@ void ModuleDialogGeneric::syncTableRowsWithDynamicPort(const std::string& portId
   ScopedWidgetSignalBlocker swsb(table);
   if (portId.find(type) != std::string::npos)
   {
-    //qDebug() << "adjust input table: " << portId.c_str() << portChangeType;
-
     if (portChangeType == DynamicPortChange::USER_ADDED_PORT || portChangeType == DynamicPortChange::USER_ADDED_PORT_DURING_FILE_LOAD)
     {
-      //qDebug() << "trying to add row via port added, id: " << portId.c_str();
-
       int connectedPortNumber;
       std::string connectedPortId;
       std::tie(connectedPortId, connectedPortNumber) = getConnectedDynamicPortId(portId, type, portChangeType == DynamicPortChange::USER_ADDED_PORT_DURING_FILE_LOAD);
@@ -917,7 +913,6 @@ void ModuleDialogGeneric::syncTableRowsWithDynamicPort(const std::string& portId
 
         addLineEditManager(lineEdit, name);
         table->setCellWidget(newRowIndex, lineEditIndex, lineEdit);
-        //qDebug() << "row added with " << lineEditText;
 
         for (int i = 1; i < table->columnCount(); ++i)
         {
@@ -942,14 +937,12 @@ void ModuleDialogGeneric::syncTableRowsWithDynamicPort(const std::string& portId
     }
     else
     {
-      //qDebug() << "trying to remove row with " << portId.c_str();
       auto items = table->findItems(QString::fromStdString(portId), Qt::MatchFixedString);
       if (!items.empty())
       {
         auto item = items[0];
         int row = table->row(item);
         table->removeRow(row);
-        //qDebug() << "row removed" << QString::fromStdString(portId);
         removeManager(Name(portId));
       }
       else
diff --git a/src/Interface/Modules/Python/InterfaceWithPythonDialog.cc b/src/Interface/Modules/Python/InterfaceWithPythonDialog.cc
@@ -363,7 +363,6 @@ void Highlighter::highlightBlock(const QString &text)
 
 void Highlighter::highlightBlockParens(const QString &text)
 {
-  //qDebug() << "highlightBlockParens" << text;
   auto data = new TextBlockData;
   int leftPos = text.indexOf('(');
   while (leftPos != -1)
diff --git a/src/Interface/Modules/Render/GLWidget.cc b/src/Interface/Modules/Render/GLWidget.cc
@@ -163,10 +163,8 @@ void GLWidget::resizeGL(int width, int height)
 //------------------------------------------------------------------------------
 void GLWidget::closeEvent(QCloseEvent *evt)
 {
-  //qDebug() << "Close event for window.";
   if (mGraphics != nullptr)
   {
-    //std::cout << "Terminating spire." << std::endl;
     mGraphics.reset();
   }
   QGLWidget::closeEvent(evt);

Original file line number	Diff line number	Diff line change
`@@ -458,21 +458,14 @@ void ModuleWidget::resizeBasedOnModuleName(ModuleWidgetDisplayBase* display, int`
`458`	`458`	`{`
`459`	`459`	`auto frame = this;`
`460`	`460`	`int pixelWidth = display->getTitleWidth();`
`461`		`- //qDebug() << moduleId_.c_str();`
`462`		`- //qDebug() << "\tPixelwidth = " << pixelWidth;`
`463`	`461`	`int extraWidth = pixelWidth - ModuleWidgetDisplayBase::moduleWidthThreshold;`
`464`		`- //qDebug() << "\textraWidth = " << extraWidth;`
`465`	`462`	`if (extraWidth > ModuleWidgetDisplayBase::extraWidthThreshold)`
`466`	`463`	`{`
`467`		`- //qDebug() << "\tGROWING MODULE Current width: " << frame->width();`
`468`	`464`	`frame->resize(frame->width() + extraWidth + ModuleWidgetDisplayBase::extraModuleWidth, frame->height());`
`469`		`- //qDebug() << "\tNew width: " << frame->width();`
`470`	`465`	`}`
`471`	`466`	`else`
`472`	`467`	`{`
`473`		`- //qDebug() << "\tSHRINKING MODULE Current width: " << frame->width();`
`474`	`468`	`frame->resize(frame->width() - ModuleWidgetDisplayBase::smushFactor, frame->height());`
`475`		`- //qDebug() << "\tNew width: " << frame->width();`
`476`	`469`	`}`
`477`	`470`	`}`
`478`	`471`
`@@ -571,7 +564,6 @@ void ModuleWidget::fillReplaceWithMenu()`
`571`	`564`
`572`	`565`	`void ModuleWidget::menuFunction()`
`573`	`566`	`{`
`574`		`- qDebug() << "ModuleWidget::menuFunction";`
`575`	`567`	`// fullWidgetDisplay_->getModuleActionButton()->setMenu(nullptr);`
`576`	`568`	`// actionsMenu_.reset();`
`577`	`569`	`}`
`@@ -744,7 +736,6 @@ void ModuleWidget::addOutputPortsToWidget(int index)`
`744`	`736`	`}`
`745`	`737`	`else`
`746`	`738`	`{`
`747`		`- qDebug() << "OOPS NO OUTPUT PORTS";`
`748`	`739`	`}`
`749`	`740`	`}`
`750`	`741`
`@@ -811,7 +802,6 @@ void ModuleWidget::addInputPortsToWidget(int index)`
`811`	`802`	`}`
`812`	`803`	`else`
`813`	`804`	`{`
`814`		`- qDebug() << "OOPS NO INPUT PORTS";`
`815`	`805`	`}`
`816`	`806`	`}`
`817`	`807`
Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,6 @@ void PortWidget::doMousePress(Qt::MouseButton button, const QPointF& pos)`
`289`	`289`	`}`
`290`	`290`	`else`
`291`	`291`	`{`
`292`		`- //qDebug() << "mouse press sth else";`
`293`	`292`	`}`
`294`	`293`	`}`
`295`	`294`
`@@ -308,7 +307,6 @@ QGraphicsItem* PortWidget::doMouseMove(Qt::MouseButtons buttons, const QPointF&`
`308`	`307`	`}`
`309`	`308`	`else`
`310`	`309`	`{`
`311`		`- //qDebug() << "mouse move sth else";`
`312`	`310`	`}`
`313`	`311`	`return nullptr;`
`314`	`312`	`}`
`@@ -341,7 +339,6 @@ void PortWidget::doMouseRelease(Qt::MouseButton button, const QPointF& pos, Qt::`
`341`	`339`	`}`
`342`	`340`	`else`
`343`	`341`	`{`
`344`		`- //qDebug() << "mouse release sth else";`
`345`	`342`	`}`
`346`	`343`	`}`
`347`	`344`
Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,6 @@ bool SCIRunMainWindow::loadNetworkFile(const QString& filename, bool isTemporary`
`618`	`618`	`if (command.execute())`
`619`	`619`	`{`
`620`	`620`	`networkProgressBar_->updateTotalModules(networkEditor_->numModules());`
`621`		`-`
`622`	`621`	`if (!isTemporary)`
`623`	`622`	`{`
`624`	`623`	`setCurrentFile(filename);`
Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,10 @@ NetworkEditor::~NetworkEditor()`
`65`	`65`	`{`
`66`	`66`	`child.second->get()->controller_.reset();`
`67`	`67`	`delete child.second->get();`
	`68`	`+ delete child.second;`
`68`	`69`	`child.second = nullptr;`
`69`	`70`	`}`
	`71`	`+ childrenNetworks_.clear();`
`70`	`72`
`71`	`73`	`Q_FOREACH(QGraphicsItem* item, scene_->items())`
`72`	`74`	`{`
`@@ -363,7 +365,7 @@ void NetworkEditor::initializeSubnet(const QString& name, ModuleHandle mod, Netw`
`363`	`365`
`364`	`366`	`auto dock = new SubnetworkEditor(subnet, mod->get_id(), name, nullptr);`
`365`	`367`	`dock->setStyleSheet(SCIRunMainWindow::Instance()->styleSheet());`
`366`		`-`
	`368`	`+ dock->setWindowFlags(dock->windowFlags() \| Qt::WindowStaysOnTopHint);`
`367`	`369`	`dock->show();`
`368`	`370`	`subnet->centerView();`
`369`	`371`
`@@ -733,7 +735,7 @@ SubnetWidget::SubnetWidget(NetworkEditor* ed, const QString& name, ModuleHandle`
`733`	`735`
`734`	`736`	`SubnetWidget::~SubnetWidget()`
`735`	`737`	`{`
`736`		`- editor_->killChild(name_);`
	`738`	`+ editor_->killChild(name_, deleteSubnetImmediately_);`
`737`	`739`	`}`
`738`	`740`
`739`	`741`	`SubnetPortsBridgeWidget::SubnetPortsBridgeWidget(NetworkEditor* ed, const QString& name, QWidget* parent /* = 0 */) :`
`@@ -744,13 +746,16 @@ SubnetPortsBridgeWidget::SubnetPortsBridgeWidget(NetworkEditor* ed, const QStrin`
`744`	`746`	`setStyleSheet(rounded + " background-color: darkGray");`
`745`	`747`	`}`
`746`	`748`
`747`		`-void NetworkEditor::killChild(const QString& name)`
	`749`	`+void NetworkEditor::killChild(const QString& name, bool force)`
`748`	`750`	`{`
`749`	`751`	`auto subnetIter = childrenNetworks_.find(name);`
`750`	`752`	`if (subnetIter != childrenNetworks_.end())`
`751`	`753`	`{`
`752`	`754`	`subnetIter->second->get()->clear();`
`753`		`- subnetIter->second->deleteLater();`
	`755`	`+ if (force)`
	`756`	`+ delete subnetIter->second;`
	`757`	`+ else`
	`758`	`+ subnetIter->second->deleteLater();`
`754`	`759`	`childrenNetworks_.erase(subnetIter);`
`755`	`760`	`currentSubnetNames_.remove(name);`
`756`	`761`	`}`
`@@ -802,7 +807,6 @@ bool SubnetModuleConnector::signalFromSubnet(QObject* sender) const`
`802`	`807`
`803`	`808`	`void SubnetModuleConnector::moduleAddedToSubnet(const std::string& s, ModuleHandle module)`
`804`	`809`	`{`
`805`		`- //qDebug() << __FUNCTION__ << sender() << signalFromSubnet(sender()) << signalFromParent(sender());`
`806`	`810`	`if (signalFromSubnet(sender()) && subnet_->containsModule(module->get_id().id_))`
`807`	`811`	`{`
`808`	`812`	`qDebug() << "was:" << module_->underlyingModules_.size();`
`@@ -824,5 +828,4 @@ bool NetworkEditor::containsModule(const std::string& id) const`
`824`	`828`
`825`	`829`	`void SubnetModuleConnector::connectionDeletedFromParent()`
`826`	`830`	`{`
`827`		`- qDebug() << __FUNCTION__;`
`828`	`831`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ void ModuleButtonBar::setTitleVisible(bool visible)`
`69`	`69`	`void ModuleButtonBar::switchIcons()`
`70`	`70`	`{`
`71`	`71`	`//TODO`
`72`		`- //qDebug() << collapseToolButton_->styleSheet();`
`73`	`72`	`//collapseToolButton_->setIcon(QApplication::style()->standardIcon(QStyle::SP_TitleBarShadeButton));`
`74`	`73`	`//collapseToolButton_->setIcon(QApplication::style()->standardIcon(QStyle::SP_TitleBarUnshadeButton));`
`75`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -881,12 +881,8 @@ void ModuleDialogGeneric::syncTableRowsWithDynamicPort(const std::string& portId`
`881`	`881`	`ScopedWidgetSignalBlocker swsb(table);`
`882`	`882`	`if (portId.find(type) != std::string::npos)`
`883`	`883`	`{`
`884`		`- //qDebug() << "adjust input table: " << portId.c_str() << portChangeType;`
`885`		`-`
`886`	`884`	`if (portChangeType == DynamicPortChange::USER_ADDED_PORT \|\| portChangeType == DynamicPortChange::USER_ADDED_PORT_DURING_FILE_LOAD)`
`887`	`885`	`{`
`888`		`- //qDebug() << "trying to add row via port added, id: " << portId.c_str();`
`889`		`-`
`890`	`886`	`int connectedPortNumber;`
`891`	`887`	`std::string connectedPortId;`
`892`	`888`	`std::tie(connectedPortId, connectedPortNumber) = getConnectedDynamicPortId(portId, type, portChangeType == DynamicPortChange::USER_ADDED_PORT_DURING_FILE_LOAD);`
`@@ -917,7 +913,6 @@ void ModuleDialogGeneric::syncTableRowsWithDynamicPort(const std::string& portId`
`917`	`913`
`918`	`914`	`addLineEditManager(lineEdit, name);`
`919`	`915`	`table->setCellWidget(newRowIndex, lineEditIndex, lineEdit);`
`920`		`- //qDebug() << "row added with " << lineEditText;`
`921`	`916`
`922`	`917`	`for (int i = 1; i < table->columnCount(); ++i)`
`923`	`918`	`{`
`@@ -942,14 +937,12 @@ void ModuleDialogGeneric::syncTableRowsWithDynamicPort(const std::string& portId`
`942`	`937`	`}`
`943`	`938`	`else`
`944`	`939`	`{`
`945`		`- //qDebug() << "trying to remove row with " << portId.c_str();`
`946`	`940`	`auto items = table->findItems(QString::fromStdString(portId), Qt::MatchFixedString);`
`947`	`941`	`if (!items.empty())`
`948`	`942`	`{`
`949`	`943`	`auto item = items[0];`
`950`	`944`	`int row = table->row(item);`
`951`	`945`	`table->removeRow(row);`
`952`		`- //qDebug() << "row removed" << QString::fromStdString(portId);`
`953`	`946`	`removeManager(Name(portId));`
`954`	`947`	`}`
`955`	`948`	`else`