Extract method

Author: dcwhite

src/Interface/Application/ModuleProxyWidget.cc

@@ -111,8 +111,6 @@ namespace SCIRun
   }
 }
 
-const int fadeInSeconds = 1;
-
 ModuleProxyWidget::ModuleProxyWidget(ModuleWidget* module, QGraphicsItem* parent/* = 0*/)
   : QGraphicsProxyWidget(parent),
   NoteDisplayHelper(boost::make_shared<ModuleWidgetNoteDisplayStrategy>()),
@@ -137,6 +135,7 @@ ModuleProxyWidget::ModuleProxyWidget(ModuleWidget* module, QGraphicsItem* parent
   originalSize_ = size();
 
   // {
+  //   const int fadeInSeconds = 1;
   //   timeLine_ = new QTimeLine(fadeInSeconds * 1000, this);
   //   connect(timeLine_, SIGNAL(valueChanged(qreal)), this, SLOT(loadAnimate(qreal)));
   //   timeLine_->start();

src/Interface/Application/ModuleWidget.cc

@@ -1357,20 +1357,20 @@ void ModuleWidget::unhighlightPorts()
   Q_EMIT displayChanged();
 }
 
-void ModuleWidget::updateMetadata(bool active)
+QString ModuleWidget::metadataToString() const
 {
-  if (active)
+  auto metadata = theModule_->metadata().getFullMap();
+  QStringList display;
+  for (const auto& metaPair : metadata)
   {
-    auto metadata = theModule_->metadata().getFullMap();
-    QStringList display;
-    for (const auto& metaPair : metadata)
-    {
-      display.append(QString::fromStdString(metaPair.first) + " : " + QString::fromStdString(metaPair.second));
-    }
-    setToolTip("Metadata:\n" + display.join("\n"));
+    display.append(QString::fromStdString(metaPair.first) + " : " + QString::fromStdString(metaPair.second));
   }
-  else
-    setToolTip("");
+  return display.join("\n");
+}
+
+void ModuleWidget::updateMetadata(bool active)
+{
+  setToolTip(active ? "Metadata:\n" + metadataToString() : "");
 }
 
 void ModuleWidget::setExecutionDisabled(bool disabled)

src/Interface/Application/ModuleWidget.h

@@ -159,6 +159,8 @@ class ModuleWidget : public QStackedWidget,
     ~NetworkClearingScope();
   };
 
+  QString metadataToString() const;
+
 public Q_SLOTS:
   virtual bool executeWithSignals() override;
   void toggleOptionsDialog();