Python test code crash fix

Author: dcwhite

src/Dataflow/Engine/Controller/PythonImpl.cc

@@ -582,9 +582,15 @@ namespace SCIRun {
 
 PythonImpl::PythonImpl(NetworkEditorController& nec, GlobalCommandFactoryHandle cmdFactory) : impl_(new PythonImplImpl), nec_(nec), cmdFactory_(cmdFactory)
 {
-  nec_.connectNetworkExecutionFinished([this](int) { executionFromPythonFinish(0); });
-  nec_.connectModuleAdded([this](const std::string& id, ModuleHandle m, ModuleCounter mc) { pythonModuleAddedSlot(id, m, mc); });
-  nec_.connectModuleRemoved([this](const ModuleId& id) { pythonModuleRemovedSlot(id); });
+  connections_.push_back(nec_.connectNetworkExecutionFinished([this](int) { executionFromPythonFinish(0); }));
+  connections_.push_back(nec_.connectModuleAdded([this](const std::string& id, ModuleHandle m, ModuleCounter mc) { pythonModuleAddedSlot(id, m, mc); }));
+  connections_.push_back(nec_.connectModuleRemoved([this](const ModuleId& id) { pythonModuleRemovedSlot(id); }));
+}
+
+PythonImpl::~PythonImpl()
+{
+  for (const auto& c : connections_)
+    c.disconnect();
 }
 
 void PythonImpl::setUnlockFunc(boost::function<void()> unlock)

src/Dataflow/Engine/Controller/PythonImpl.h

@@ -49,6 +49,7 @@ namespace Engine {
   {
   public:
     PythonImpl(NetworkEditorController& nec, Core::Commands::GlobalCommandFactoryHandle cmdFactory);
+    ~PythonImpl();
     virtual boost::shared_ptr<PyModule> addModule(const std::string& name) override;
     virtual std::string removeModule(const std::string& id) override;
     virtual std::vector<boost::shared_ptr<PyModule>> moduleList() const override;
@@ -71,6 +72,7 @@ namespace Engine {
     NetworkEditorController& nec_;
     Core::Commands::GlobalCommandFactoryHandle cmdFactory_;
     boost::function<void()> unlock_;
+    std::vector<boost::signals2::connection> connections_;
   };
 
 }}}