Skip to content

Commit 6f6d123

Browse files
authored
Merge pull request #1927 from allywarner/update_cleaver_UI
Update cleaver UI
2 parents d6e09a5 + 0cca18c commit 6f6d123

File tree

4 files changed

+19
-16
lines changed

4 files changed

+19
-16
lines changed

src/Core/Algorithms/Field/InterfaceWithCleaver2Algorithm.cc

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ namespace detail
8484
static const double kDefaultAlpha = 0.4;
8585
static const double kDefaultAlphaLong = 0.357;
8686
static const double kDefaultAlphaShort = 0.203;
87-
static const double kDefaultScale = 1.0;
87+
static const double kDefaultSamplingRate = 1.0;
8888
static const double kDefaultLipschitz = 0.2;
89-
static const double kDefaultMultiplier = 1.0;
89+
static const double kDefaultFeatureScaling = 1.0;
9090
//static const int kDefaultPadding = 0;
9191
//static const int kDefaultMaxIterations = 1000;
9292
//static const double kDefaultSigma = 1.;
@@ -96,9 +96,9 @@ namespace detail
9696
cleaver2::MeshType mesh_mode;
9797
double alphaLong;
9898
double alphaShort;
99-
double scaling;
99+
double samplingRate;
100100
double lipschitz;
101-
double multiplier;
101+
double featureScaling;
102102
bool verbose;
103103
bool simpleMode;
104104
bool reverseJacobians;
@@ -119,9 +119,9 @@ namespace detail
119119
Cleaver2Impl(const AlgorithmBase* algo, const Cleaver2Parameters& params, FieldHandle sizingField, FieldHandle backgroundMesh) :
120120
algo_(algo), params_(params), inputSizingField_(sizingField), inputBackgroundMesh_(backgroundMesh)
121121
{
122-
LOG_DEBUG("Cleaver 2 parameters: \n\tmesh_mode: {}\n\talphaLong: {}\n\talphaShort: {}\n\tscaling: {}\n\tlipschitz: {}\n\tmultiplier: {}\n\tverbose: {}\n\tsimpleMode: {}",
122+
LOG_DEBUG("Cleaver 2 parameters: \n\tmesh_mode: {}\n\talphaLong: {}\n\talphaShort: {}\n\tsampling_rate: {}\n\tlipschitz: {}\n\tfeature_scaling: {}\n\tverbose: {}\n\tsimpleMode: {}",
123123
params_.mesh_mode, params_.alphaLong, params_.alphaShort,
124-
params_.scaling, params_.lipschitz, params_.multiplier,
124+
params_.samplingRate, params_.lipschitz, params_.featureScaling,
125125
params_.verbose, params_.simpleMode);
126126
}
127127

@@ -429,8 +429,8 @@ namespace detail
429429
sizingField_.reset(cleaver2::SizingFieldCreator::createSizingFieldFromVolume(
430430
volume_.get(),
431431
(float)(1.0 / params_.lipschitz),
432-
(float)params_.scaling,
433-
(float)params_.multiplier,
432+
(float)params_.samplingRate,
433+
(float)params_.featureScaling,
434434
0, // padding--off
435435
(params_.mesh_mode != cleaver2::Regular),
436436
params_.verbose));
@@ -505,11 +505,12 @@ namespace detail
505505

506506
InterfaceWithCleaver2Algorithm::InterfaceWithCleaver2Algorithm()
507507
{
508+
//Cleaver parameters: Scaling = Sampling Rate, Multiplier = Feature Scaling
508509
addParameter(Parameters::Verbose, true);
509510
addParameter(Parameters::SimpleMode, false);
510511
addParameter(Parameters::ReverseJacobians, true);
511-
addParameter(Parameters::VolumeScaling, detail::kDefaultScale);
512-
addParameter(Parameters::VolumeMultiplier, detail::kDefaultMultiplier);
512+
addParameter(Parameters::VolumeScaling, detail::kDefaultSamplingRate);
513+
addParameter(Parameters::VolumeMultiplier, detail::kDefaultFeatureScaling);
513514
addParameter(Parameters::Lipschitz, detail::kDefaultLipschitz);
514515
//addParameter(Parameters::Padding, detail::kDefaultPadding);
515516
addParameter(Parameters::AlphaLong, detail::kDefaultAlphaLong);

src/Core/Algorithms/Field/InterfaceWithCleaver2Algorithm.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ namespace Core {
3838
namespace Algorithms {
3939
namespace Fields {
4040

41+
//Cleaver parameters: Scaling = Sampling Rate, Multiplier = Feature Scaling
4142
ALGORITHM_PARAMETER_DECL(Verbose);
4243
ALGORITHM_PARAMETER_DECL(VolumeScaling);
4344
ALGORITHM_PARAMETER_DECL(VolumeMultiplier);

src/Interface/Modules/Fields/InterfaceWithCleaver2.ui

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,12 @@
5959
<item row="2" column="0">
6060
<widget class="QLabel" name="label_4">
6161
<property name="text">
62-
<string>Scaling</string>
62+
<string>Sampling Rate</string>
6363
</property>
6464
</widget>
6565
</item>
6666
<item row="2" column="1">
67-
<widget class="QDoubleSpinBox" name="scalingDoubleSpinBox_">
67+
<widget class="QDoubleSpinBox" name="samplingRateDoubleSpinBox_">
6868
<property name="minimumSize">
6969
<size>
7070
<width>125</width>
@@ -82,12 +82,12 @@
8282
<item row="3" column="0">
8383
<widget class="QLabel" name="label_5">
8484
<property name="text">
85-
<string>Multiplier</string>
85+
<string>Feature Scaling</string>
8686
</property>
8787
</widget>
8888
</item>
8989
<item row="3" column="1">
90-
<widget class="QDoubleSpinBox" name="multiplierDoubleSpinBox_">
90+
<widget class="QDoubleSpinBox" name="featureScalingDoubleSpinBox_">
9191
<property name="minimumSize">
9292
<size>
9393
<width>125</width>

src/Interface/Modules/Fields/InterfaceWithCleaver2Dialog.cc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,11 @@ InterfaceWithCleaver2Dialog::InterfaceWithCleaver2Dialog(const std::string& name
4242
setWindowTitle(QString::fromStdString(name));
4343
fixSize();
4444

45+
//Cleaver parameters: Scaling = Sampling Rate, Multiplier = Feature Scaling
4546
addDoubleSpinBoxManager(alphaLongDoubleSpinBox_, Parameters::AlphaLong);
4647
addDoubleSpinBoxManager(alphaShortDoubleSpinBox_, Parameters::AlphaShort);
47-
addDoubleSpinBoxManager(multiplierDoubleSpinBox_, Parameters::VolumeMultiplier);
48-
addDoubleSpinBoxManager(scalingDoubleSpinBox_, Parameters::VolumeScaling);
48+
addDoubleSpinBoxManager(featureScalingDoubleSpinBox_, Parameters::VolumeMultiplier);
49+
addDoubleSpinBoxManager(samplingRateDoubleSpinBox_, Parameters::VolumeScaling);
4950
addDoubleSpinBoxManager(lipschitzDoubleSpinBox_, Parameters::Lipschitz);
5051
addCheckBoxManager(verboseCheckBox_, Parameters::Verbose);
5152
addCheckBoxManager(simpleModeCheckBox_, Parameters::SimpleMode);

0 commit comments

Comments
 (0)