Skip to content

Commit 784dcb3

Browse files
committed
Merge branch 'master' into ConvertMatricesToMesh
2 parents 653ab3e + d49f951 commit 784dcb3

File tree

66 files changed

+4169
-381
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+4169
-381
lines changed

src/Core/Algorithms/Base/AlgorithmBase.cc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,9 @@ double AlgorithmParameter::toDouble() const
136136

137137
std::vector<double> AlgorithmParameter::toDoubleVector() const
138138
{
139-
const std::vector<double>* v = boost::get<std::vector<double>>(&value_);
140-
return v ? *v : std::vector<double>();
139+
return {};
140+
// const std::vector<double>* v = boost::get<std::vector<double>>(&value_);
141+
// return v ? *v : std::vector<double>();
141142
}
142143

143144
std::string AlgorithmParameter::toString() const

src/Core/Algorithms/Base/Variable.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ namespace Algorithms {
5454
std::string,
5555
bool,
5656
AlgoOption,
57-
std::vector<double>,
5857
List
58+
//,std::vector<double>
5959
> Value;
6060

6161
Variable() {}

src/Core/Algorithms/Field/Tests/SetFieldDataAlgoTests.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,8 @@ TEST(SetFieldDataTest, TriSurfOnNodeScalarMatrixTooSmall)
270270
EXPECT_MATRIX_EQ_TOLERANCE(*resultmatrix, *matrix, 1e-16);
271271
}
272272

273-
TEST(SetFieldDataTest, TriSurfOnNodeScalarMatrixTooLarge)
273+
//TODO: issue made, requirements need refining to see if this one is actually a problem.
274+
TEST(SetFieldDataTest, DISABLED_TriSurfOnNodeScalarMatrixTooLarge)
274275
{
275276
SetFieldDataAlgo algo;
276277

src/Core/Algorithms/Legacy/Converter/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ SET(Core_Algorithms_Legacy_Converter_SRCS
3333
#MatrixToField.cc
3434
NrrdToField.cc
3535
FieldToNrrd.cc
36-
#ConvertToNrrd.cc
36+
ConvertToNrrd.cc
3737
#MatricesToDipoleField.cc
3838
#ConvertBundleToField.cc
3939
ConvertMatrixToString.cc
@@ -43,7 +43,9 @@ SET(Core_Algorithms_Legacy_Converter_HEADERS
4343
ConverterAlgo.h
4444
NrrdToField.h
4545
FieldToNrrd.h
46+
ConvertToNrrd.h
4647
ConvertMatrixToString.h
48+
share.h
4749
)
4850

4951
SCIRUN_ADD_LIBRARY(Core_Algorithms_Legacy_Converter

src/Core/Algorithms/Legacy/Converter/ConvertMatrixToString.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,15 @@ namespace SCIRun {
3838
namespace Core {
3939
namespace Algorithms {
4040
namespace Converters {
41-
41+
4242
class SCISHARE ConvertMatrixToStringAlgo : public AlgorithmBase
4343
{
4444
public:
45-
static AlgorithmInputName InputMatrix;
4645
static AlgorithmOutputName ResultString;
4746
ConvertMatrixToStringAlgo() {}
4847
bool run(Datatypes::MatrixHandle input, Datatypes::StringHandle& output) const;
4948
virtual AlgorithmOutput run_generic(const AlgorithmInput& input) const;
5049
};
5150
}}}}
5251

53-
#endif
52+
#endif

0 commit comments

Comments
 (0)