Skip to content

Commit a781342

Browse files
authored
Merge pull request #1967 from Haydelj/showFieldTests
Closes #1965
2 parents d1e2f2f + 2d67472 commit a781342

File tree

4 files changed

+552
-13
lines changed

4 files changed

+552
-13
lines changed

src/Modules/Visualization/ShowField.cc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -347,9 +347,9 @@ GeometryHandle GeometryBuilder::buildGeometryObject(
347347
const GeometryIDGenerator& gid, Interruptible* interruptible)
348348
{
349349
// Function for reporting progress. TODO: use this variable somewhere!
350-
//auto progressFunc = getUpdaterFunc();
350+
// auto progressFunc = getUpdaterFunc();
351351

352-
/// \todo Determine a better way of handling all of the various object state_.
352+
// todo Determine a better way of handling all of the various object state_.
353353
bool showNodes = state_->getValue(ShowField::ShowNodes).toBool();
354354
bool showEdges = state_->getValue(ShowField::ShowEdges).toBool();
355355
bool showFaces = state_->getValue(ShowField::ShowFaces).toBool();
@@ -363,24 +363,23 @@ GeometryHandle GeometryBuilder::buildGeometryObject(
363363

364364
auto geom(boost::make_shared<GeometryObjectSpire>(gid, idname, true));
365365

366-
/// \todo Implement inputs_changes_ ? See old scirun ShowField.cc:293.
366+
// todo Implement inputs_changes_ ? See old scirun ShowField.cc:293.
367367

368-
/// \todo Mind material properties (simple since we already have implemented
369-
/// most of this).
368+
// todo Mind material properties (simple since we already have implemented
369+
// most of this).
370370

371-
/// \todo Handle assignment of color map. The color map will need to be
372-
/// available to us as we are building the meshes. Due to the way
373-
/// SCIRun expects meshes to be built.
371+
// todo Handle assignment of color map. The color map will need to be
372+
// available to us as we are building the meshes. Due to the way
373+
// SCIRun expects meshes to be built.
374374

375-
/// \todo render_state_ DIRTY flag? See old scirun ShowField.cc:446.
375+
// todo render_state_ DIRTY flag? See old scirun ShowField.cc:446.
376376

377377
const int dim = field->vmesh()->dimensionality();
378378
if (showEdges && dim < 1) { showEdges = false; }
379379
if (showFaces && dim < 2) { showFaces = false; }
380380

381381
if (showNodes)
382382
{
383-
// Construct node geometry.
384383
renderNodes(field, colorMap, interruptible, getNodeRenderState(colorMap), geom, geom->uniqueID());
385384
}
386385

src/Modules/Visualization/ShowField.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,7 @@ namespace SCIRun {
120120

121121
boost::shared_ptr<detail::GeometryBuilder> builder_;
122122
};
123-
124-
125-
123+
126124
} // Visualization
127125
} // Modules
128126
} // SCIRun

src/Modules/Visualization/Tests/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ SET(Modules_Visualization_Tests_SRCS
3131
MatrixAsVectorFieldTests.cc
3232
RescaleColorMapTests.cc
3333
ShowColorMapTests.cc
34+
ShowFieldFunctionalTests.cc
3435
ShowFieldTests.cc
3536
ShowMeshTests.cc
3637
ShowStringTests.cc

0 commit comments

Comments
 (0)