Working on py-undo

dcwhite · dcwhite · commit ae56c0ac3f46 · 2023-03-02T14:07:04.000-07:00
diff --git a/src/Dataflow/Engine/Controller/ProvenanceItemImpl.cc b/src/Dataflow/Engine/Controller/ProvenanceItemImpl.cc
@@ -31,14 +31,15 @@
 #include <string>
 #include <sstream>
 #include <Dataflow/Engine/Controller/ProvenanceItemImpl.h>
+#include <Dataflow/Engine/Python/NetworkEditorPythonInterface.h>
 #include <Core/Logging/Log.h>
 #include <spdlog/fmt/fmt.h>
 
 using namespace SCIRun;
 using namespace SCIRun::Dataflow::Engine;
 using namespace SCIRun::Dataflow::Networks;
 
-ProvenanceItemBase::ProvenanceItemBase(NetworkFileHandle state) : state_(state)
+ProvenanceItemBase::ProvenanceItemBase(NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy) : state_(state), nedPy_(nedPy)
 {
 }
 
@@ -47,8 +48,8 @@ NetworkFileHandle ProvenanceItemBase::memento() const
   return state_;
 }
 
-ModuleAddedProvenanceItem::ModuleAddedProvenanceItem(const std::string& moduleName, const std::string& modId, NetworkFileHandle state)
-  : ProvenanceItemBase(state), moduleName_(moduleName), moduleId_(modId)
+ModuleAddedProvenanceItem::ModuleAddedProvenanceItem(const std::string& moduleName, const std::string& modId, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)
+  : ProvenanceItemBase(state, nedPy), moduleName_(moduleName), moduleId_(modId)
 {
 }
 
@@ -62,7 +63,7 @@ std::string ModuleAddedProvenanceItem::undoCode() const
   if (redone_)
   {
     logCritical("here is where i need to pull the most recently added id");
-    moduleId_ = "TODO";
+    moduleId_ = nedPy_->mostRecentAddModuleId();
   }
   return fmt::format("scirun_remove_module(\"{}\")", moduleId_);
 }
@@ -73,8 +74,8 @@ std::string ModuleAddedProvenanceItem::redoCode() const
   return fmt::format("scirun_add_module(\"{}\")", moduleName_);
 }
 
-ModuleRemovedProvenanceItem::ModuleRemovedProvenanceItem(const ModuleId& moduleId, NetworkFileHandle state)
-  : ProvenanceItemBase(state), moduleId_(moduleId)
+ModuleRemovedProvenanceItem::ModuleRemovedProvenanceItem(const ModuleId& moduleId, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)
+  : ProvenanceItemBase(state, nedPy), moduleId_(moduleId)
 {
 }
 
@@ -83,8 +84,24 @@ std::string ModuleRemovedProvenanceItem::name() const
   return "Module Removed: " + moduleId_.id_;
 }
 
-ConnectionAddedProvenanceItem::ConnectionAddedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionDescription& cd, NetworkFileHandle state)
-  : ProvenanceItemBase(state), desc_(cd)
+std::string ModuleRemovedProvenanceItem::undoCode() const
+{
+  redone_ = true;
+  return fmt::format("scirun_add_module(\"{}\")", moduleId_.name_);
+}
+
+std::string ModuleRemovedProvenanceItem::redoCode() const
+{
+  if (redone_)
+  {
+    //logCritical("here is where i need to pull the most recently added id");
+    //moduleId_ = nedPy_->mostRecentAddModuleId();
+  }
+  return fmt::format("scirun_remove_module(\"{}\")", moduleId_.id_);
+}
+
+ConnectionAddedProvenanceItem::ConnectionAddedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionDescription& cd, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)
+  : ProvenanceItemBase(state, nedPy), desc_(cd)
 {
 }
 
@@ -93,8 +110,8 @@ std::string ConnectionAddedProvenanceItem::name() const
   return "Connection added: " + ConnectionId::create(desc_).id_;
 }
 
-ConnectionRemovedProvenanceItem::ConnectionRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionId& id, NetworkFileHandle state)
-  : ProvenanceItemBase(state), id_(id)
+ConnectionRemovedProvenanceItem::ConnectionRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionId& id, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)
+  : ProvenanceItemBase(state, nedPy), id_(id)
 {
 }
 
@@ -103,8 +120,8 @@ std::string ConnectionRemovedProvenanceItem::name() const
   return "Connection Removed: " + id_.id_;
 }
 
-ModuleMovedProvenanceItem::ModuleMovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, double newX, double newY, NetworkFileHandle state)
-  : ProvenanceItemBase(state), moduleId_(moduleId), newX_(newX), newY_(newY)
+ModuleMovedProvenanceItem::ModuleMovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, double newX, double newY, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)
+  : ProvenanceItemBase(state, nedPy), moduleId_(moduleId), newX_(newX), newY_(newY)
 {
 }
 
diff --git a/src/Dataflow/Engine/Controller/ProvenanceItemImpl.h b/src/Dataflow/Engine/Controller/ProvenanceItemImpl.h
@@ -37,24 +37,24 @@
 #include <Dataflow/Engine/Controller/share.h>
 
 namespace SCIRun {
+  class NetworkEditorPythonInterface;
 namespace Dataflow {
 namespace Engine {
 
   class SCISHARE ProvenanceItemBase : public ProvenanceItem<Networks::NetworkFileHandle>
   {
   public:
-    explicit ProvenanceItemBase(Networks::NetworkFileHandle state);
+    explicit ProvenanceItemBase(Networks::NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy);
     Networks::NetworkFileHandle memento() const override;
-    std::string undoCode() const override { throw "not implemented"; }
-    std::string redoCode() const override { throw "not implemented"; }
   protected:
     Networks::NetworkFileHandle state_;
+    SharedPointer<NetworkEditorPythonInterface> nedPy_;
   };
 
   class SCISHARE ModuleAddedProvenanceItem : public ProvenanceItemBase
   {
   public:
-    ModuleAddedProvenanceItem(const std::string& moduleName, const std::string& modId, Networks::NetworkFileHandle state);
+    ModuleAddedProvenanceItem(const std::string& moduleName, const std::string& modId, Networks::NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy);
     std::string name() const override;
     std::string undoCode() const override;
     std::string redoCode() const override;
@@ -67,35 +67,44 @@ namespace Engine {
   class SCISHARE ModuleRemovedProvenanceItem : public ProvenanceItemBase
   {
   public:
-    ModuleRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, Networks::NetworkFileHandle state);
+    ModuleRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, Networks::NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy);
     std::string name() const override;
+    std::string undoCode() const override;
+    std::string redoCode() const override;
   private:
     SCIRun::Dataflow::Networks::ModuleId moduleId_;
+    mutable bool redone_ {false};
   };
 
   class SCISHARE ConnectionAddedProvenanceItem : public ProvenanceItemBase
   {
   public:
-    ConnectionAddedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionDescription& cd, Networks::NetworkFileHandle state);
+    ConnectionAddedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionDescription& cd, Networks::NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy);
     std::string name() const override;
+    std::string undoCode() const override { throw "not implemented"; }
+    std::string redoCode() const override { throw "not implemented"; }
   private:
     SCIRun::Dataflow::Networks::ConnectionDescription desc_;
   };
 
   class SCISHARE ConnectionRemovedProvenanceItem : public ProvenanceItemBase
   {
   public:
-    ConnectionRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionId& id, Networks::NetworkFileHandle state);
+    ConnectionRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionId& id, Networks::NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy);
     std::string name() const override;
+    std::string undoCode() const override { throw "not implemented"; }
+    std::string redoCode() const override { throw "not implemented"; }
   private:
     SCIRun::Dataflow::Networks::ConnectionId id_;
   };
 
   class SCISHARE ModuleMovedProvenanceItem : public ProvenanceItemBase
   {
   public:
-    ModuleMovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, double newX, double newY, Networks::NetworkFileHandle state);
+    ModuleMovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, double newX, double newY, Networks::NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy);
     std::string name() const override;
+    std::string undoCode() const override { throw "not implemented"; }
+    std::string redoCode() const override { throw "not implemented"; }
   private:
     SCIRun::Dataflow::Networks::ModuleId moduleId_;
     double newX_, newY_;
diff --git a/src/Dataflow/Engine/Controller/PythonImpl.cc b/src/Dataflow/Engine/Controller/PythonImpl.cc
@@ -533,10 +533,10 @@ SharedPointer<PyModule> PythonImpl::addModule(const std::string& name)
   else
     logWarning("Module add failed, no such module type ({})", name);
 
-logCritical("here i have the most recent added id: {}", m->id().id_);
-mostRecentAddModuleId_ = m->id().id_;
+  mostRecentAddModuleId_ = m->id().id_;
+  logCritical("here i have the most recent added id: {}", mostRecentAddModuleId_);
 
-  return modules_[m->id().id_];
+  return modules_[mostRecentAddModuleId_];
 }
 
 void PythonImpl::pythonModuleAddedSlot(const std::string&, ModuleHandle m, ModuleCounter)
diff --git a/src/Dataflow/Engine/Python/NetworkEditorPythonAPI.cc b/src/Dataflow/Engine/Python/NetworkEditorPythonAPI.cc
@@ -80,6 +80,11 @@ void NetworkEditorPythonAPI::setImpl(SharedPointer<NetworkEditorPythonInterface>
   }
 }
 
+SharedPointer<NetworkEditorPythonInterface> NetworkEditorPythonAPI::getImpl()
+{
+  return impl_;
+}
+
 void NetworkEditorPythonAPI::clearImpl()
 {
   impl_.reset();
diff --git a/src/Dataflow/Engine/Python/NetworkEditorPythonAPI.h b/src/Dataflow/Engine/Python/NetworkEditorPythonAPI.h
@@ -85,6 +85,7 @@ namespace SCIRun {
     static std::string quit(bool force);
 
     static void setImpl(SharedPointer<NetworkEditorPythonInterface> impl);
+    static SharedPointer<NetworkEditorPythonInterface> getImpl();
     static void clearImpl();
     /// @todo: smelly!
     static void setExecutionContext(Dataflow::Networks::ExecutableLookup* lookup);
diff --git a/src/Interface/Application/NetworkEditor.cc b/src/Interface/Application/NetworkEditor.cc
@@ -474,8 +474,8 @@ ModuleProxyWidget* NetworkEditor::setupModuleWidget(ModuleWidget* module)
   auto modId = module->getModule()->id().id_;
   module->getModule()->get_state()->connectProvenanceStateChanged([modId](const Name& n, const AlgorithmParameter::Value& oldV, const AlgorithmParameter::Value& newV)
     {
-      logCritical("UNDO CODE: scirun_set_module_state(\"{}\", \"{}\", {})", modId, n.name(), to_string(oldV));
-      logCritical("REDO CODE: scirun_set_module_state(\"{}\", \"{}\", {})", modId, n.name(), to_string(newV));
+      LOG_TRACE("UNDO CODE: scirun_set_module_state(\"{}\", \"{}\", {})", modId, n.name(), to_string(oldV));
+      LOG_TRACE("REDO CODE: scirun_set_module_state(\"{}\", \"{}\", {})", modId, n.name(), to_string(newV));
     });
 
   connect(this, &NetworkEditor::networkExecuted, module, &ModuleWidget::resetLogButtonColor);
diff --git a/src/Interface/Application/ProvenanceWindow.cc b/src/Interface/Application/ProvenanceWindow.cc
@@ -37,6 +37,10 @@
 //TODO: factory
 #include <Dataflow/Engine/Controller/ProvenanceItemImpl.h>
 
+#ifdef BUILD_WITH_PYTHON
+#include <Dataflow/Engine/Python/NetworkEditorPythonAPI.h>
+#endif
+
 using namespace SCIRun::Gui;
 using namespace SCIRun::Dataflow::Networks;
 using namespace SCIRun::Dataflow::Engine;
@@ -305,7 +309,7 @@ void GuiActionProvenanceConverter::moduleAdded(const std::string& name, SCIRun::
 {
   if (!provenanceManagerModifyingNetwork_)
   {
-    ProvenanceItemHandle item(makeShared<ModuleAddedProvenanceItem>(name, mod->id().id_, editor_->saveNetwork()));
+    ProvenanceItemHandle item(makeShared<ModuleAddedProvenanceItem>(name, mod->id().id_, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));
     Q_EMIT provenanceItemCreated(item);
   }
 }
@@ -314,9 +318,7 @@ void GuiActionProvenanceConverter::moduleRemoved(const ModuleId& id)
 {
   if (!provenanceManagerModifyingNetwork_)
   {
-    ProvenanceItemHandle item(makeShared<ModuleRemovedProvenanceItem>(id, editor_->saveNetwork()));
-    logCritical("REDO CODE: scirun_remove_module(\"{}\")", id.id_);
-    logCritical("UNDO CODE: scirun_add_module(\"{}\")", id.name_);
+    ProvenanceItemHandle item(makeShared<ModuleRemovedProvenanceItem>(id, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));
     Q_EMIT provenanceItemCreated(item);
   }
 }
@@ -325,9 +327,9 @@ void GuiActionProvenanceConverter::connectionAdded(const SCIRun::Dataflow::Netwo
 {
   if (!provenanceManagerModifyingNetwork_)
   {
-    ProvenanceItemHandle item(makeShared<ConnectionAddedProvenanceItem>(cd, editor_->saveNetwork()));
-    logCritical("REDO CODE: scirun_add_connection(\"{}\")", ConnectionId::create(cd).id_);
-    logCritical("UNDO CODE: scirun_remove_connection(\"{}\")", ConnectionId::create(cd).id_);
+    ProvenanceItemHandle item(makeShared<ConnectionAddedProvenanceItem>(cd, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));
+    LOG_TRACE("REDO CODE: scirun_add_connection(\"{}\")", ConnectionId::create(cd).id_);
+    LOG_TRACE("UNDO CODE: scirun_remove_connection(\"{}\")", ConnectionId::create(cd).id_);
     Q_EMIT provenanceItemCreated(item);
   }
 }
@@ -336,7 +338,7 @@ void GuiActionProvenanceConverter::connectionRemoved(const SCIRun::Dataflow::Net
 {
   if (!provenanceManagerModifyingNetwork_)
   {
-    ProvenanceItemHandle item(makeShared<ConnectionRemovedProvenanceItem>(id, editor_->saveNetwork()));
+    ProvenanceItemHandle item(makeShared<ConnectionRemovedProvenanceItem>(id, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));
     logCritical("REDO CODE: scirun_remove_connection(\"{}\")", id.id_);
     logCritical("UNDO CODE: scirun_add_connection(\"{}\")", id.id_);
     Q_EMIT provenanceItemCreated(item);
@@ -347,7 +349,7 @@ void GuiActionProvenanceConverter::moduleMoved(const SCIRun::Dataflow::Networks:
 {
   if (!provenanceManagerModifyingNetwork_)
   {
-    ProvenanceItemHandle item(makeShared<ModuleMovedProvenanceItem>(id, newX, newY, editor_->saveNetwork()));
+    ProvenanceItemHandle item(makeShared<ModuleMovedProvenanceItem>(id, newX, newY, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));
     logCritical("REDO CODE: scirun_move_module(\"{}\", {}, {})", id.id_, newX, newY);
     logCritical("UNDO CODE: scirun_move_module(\"{}\", {}, {})", id.id_, oldPos.x(), oldPos.y());
     Q_EMIT provenanceItemCreated(item);

Original file line number	Diff line number	Diff line change
`@@ -31,14 +31,15 @@`
`31`	`31`	`#include <string>`
`32`	`32`	`#include <sstream>`
`33`	`33`	`#include <Dataflow/Engine/Controller/ProvenanceItemImpl.h>`
	`34`	`+#include <Dataflow/Engine/Python/NetworkEditorPythonInterface.h>`
`34`	`35`	`#include <Core/Logging/Log.h>`
`35`	`36`	`#include <spdlog/fmt/fmt.h>`
`36`	`37`
`37`	`38`	`using namespace SCIRun;`
`38`	`39`	`using namespace SCIRun::Dataflow::Engine;`
`39`	`40`	`using namespace SCIRun::Dataflow::Networks;`
`40`	`41`
`41`		`-ProvenanceItemBase::ProvenanceItemBase(NetworkFileHandle state) : state_(state)`
	`42`	`+ProvenanceItemBase::ProvenanceItemBase(NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy) : state_(state), nedPy_(nedPy)`
`42`	`43`	`{`
`43`	`44`	`}`
`44`	`45`
`@@ -47,8 +48,8 @@ NetworkFileHandle ProvenanceItemBase::memento() const`
`47`	`48`	`return state_;`
`48`	`49`	`}`
`49`	`50`
`50`		`-ModuleAddedProvenanceItem::ModuleAddedProvenanceItem(const std::string& moduleName, const std::string& modId, NetworkFileHandle state)`
`51`		`- : ProvenanceItemBase(state), moduleName_(moduleName), moduleId_(modId)`
	`51`	`+ModuleAddedProvenanceItem::ModuleAddedProvenanceItem(const std::string& moduleName, const std::string& modId, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)`
	`52`	`+ : ProvenanceItemBase(state, nedPy), moduleName_(moduleName), moduleId_(modId)`
`52`	`53`	`{`
`53`	`54`	`}`
`54`	`55`
`@@ -62,7 +63,7 @@ std::string ModuleAddedProvenanceItem::undoCode() const`
`62`	`63`	`if (redone_)`
`63`	`64`	`{`
`64`	`65`	`logCritical("here is where i need to pull the most recently added id");`
`65`		`- moduleId_ = "TODO";`
	`66`	`+ moduleId_ = nedPy_->mostRecentAddModuleId();`
`66`	`67`	`}`
`67`	`68`	`return fmt::format("scirun_remove_module(\"{}\")", moduleId_);`
`68`	`69`	`}`
`@@ -73,8 +74,8 @@ std::string ModuleAddedProvenanceItem::redoCode() const`
`73`	`74`	`return fmt::format("scirun_add_module(\"{}\")", moduleName_);`
`74`	`75`	`}`
`75`	`76`
`76`		`-ModuleRemovedProvenanceItem::ModuleRemovedProvenanceItem(const ModuleId& moduleId, NetworkFileHandle state)`
`77`		`- : ProvenanceItemBase(state), moduleId_(moduleId)`
	`77`	`+ModuleRemovedProvenanceItem::ModuleRemovedProvenanceItem(const ModuleId& moduleId, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)`
	`78`	`+ : ProvenanceItemBase(state, nedPy), moduleId_(moduleId)`
`78`	`79`	`{`
`79`	`80`	`}`
`80`	`81`
`@@ -83,8 +84,24 @@ std::string ModuleRemovedProvenanceItem::name() const`
`83`	`84`	`return "Module Removed: " + moduleId_.id_;`
`84`	`85`	`}`
`85`	`86`
`86`		`-ConnectionAddedProvenanceItem::ConnectionAddedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionDescription& cd, NetworkFileHandle state)`
`87`		`- : ProvenanceItemBase(state), desc_(cd)`
	`87`	`+std::string ModuleRemovedProvenanceItem::undoCode() const`
	`88`	`+{`
	`89`	`+ redone_ = true;`
	`90`	`+ return fmt::format("scirun_add_module(\"{}\")", moduleId_.name_);`
	`91`	`+}`
	`92`	`+`
	`93`	`+std::string ModuleRemovedProvenanceItem::redoCode() const`
	`94`	`+{`
	`95`	`+ if (redone_)`
	`96`	`+ {`
	`97`	`+ //logCritical("here is where i need to pull the most recently added id");`
	`98`	`+ //moduleId_ = nedPy_->mostRecentAddModuleId();`
	`99`	`+ }`
	`100`	`+ return fmt::format("scirun_remove_module(\"{}\")", moduleId_.id_);`
	`101`	`+}`
	`102`	`+`
	`103`	`+ConnectionAddedProvenanceItem::ConnectionAddedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionDescription& cd, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)`
	`104`	`+ : ProvenanceItemBase(state, nedPy), desc_(cd)`
`88`	`105`	`{`
`89`	`106`	`}`
`90`	`107`
`@@ -93,8 +110,8 @@ std::string ConnectionAddedProvenanceItem::name() const`
`93`	`110`	`return "Connection added: " + ConnectionId::create(desc_).id_;`
`94`	`111`	`}`
`95`	`112`
`96`		`-ConnectionRemovedProvenanceItem::ConnectionRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionId& id, NetworkFileHandle state)`
`97`		`- : ProvenanceItemBase(state), id_(id)`
	`113`	`+ConnectionRemovedProvenanceItem::ConnectionRemovedProvenanceItem(const SCIRun::Dataflow::Networks::ConnectionId& id, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)`
	`114`	`+ : ProvenanceItemBase(state, nedPy), id_(id)`
`98`	`115`	`{`
`99`	`116`	`}`
`100`	`117`
`@@ -103,8 +120,8 @@ std::string ConnectionRemovedProvenanceItem::name() const`
`103`	`120`	`return "Connection Removed: " + id_.id_;`
`104`	`121`	`}`
`105`	`122`
`106`		`-ModuleMovedProvenanceItem::ModuleMovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, double newX, double newY, NetworkFileHandle state)`
`107`		`- : ProvenanceItemBase(state), moduleId_(moduleId), newX_(newX), newY_(newY)`
	`123`	`+ModuleMovedProvenanceItem::ModuleMovedProvenanceItem(const SCIRun::Dataflow::Networks::ModuleId& moduleId, double newX, double newY, NetworkFileHandle state, SharedPointer<NetworkEditorPythonInterface> nedPy)`
	`124`	`+ : ProvenanceItemBase(state, nedPy), moduleId_(moduleId), newX_(newX), newY_(newY)`
`108`	`125`	`{`
`109`	`126`	`}`
`110`	`127`
Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,11 @@ void NetworkEditorPythonAPI::setImpl(SharedPointer<NetworkEditorPythonInterface>`
`80`	`80`	`}`
`81`	`81`	`}`
`82`	`82`
	`83`	`+SharedPointer<NetworkEditorPythonInterface> NetworkEditorPythonAPI::getImpl()`
	`84`	`+{`
	`85`	`+ return impl_;`
	`86`	`+}`
	`87`	`+`
`83`	`88`	`void NetworkEditorPythonAPI::clearImpl()`
`84`	`89`	`{`
`85`	`90`	`impl_.reset();`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,10 @@`
`37`	`37`	`//TODO: factory`
`38`	`38`	`#include <Dataflow/Engine/Controller/ProvenanceItemImpl.h>`
`39`	`39`
	`40`	`+#ifdef BUILD_WITH_PYTHON`
	`41`	`+#include <Dataflow/Engine/Python/NetworkEditorPythonAPI.h>`
	`42`	`+#endif`
	`43`	`+`
`40`	`44`	`using namespace SCIRun::Gui;`
`41`	`45`	`using namespace SCIRun::Dataflow::Networks;`
`42`	`46`	`using namespace SCIRun::Dataflow::Engine;`
`@@ -305,7 +309,7 @@ void GuiActionProvenanceConverter::moduleAdded(const std::string& name, SCIRun::`
`305`	`309`	`{`
`306`	`310`	`if (!provenanceManagerModifyingNetwork_)`
`307`	`311`	`{`
`308`		`- ProvenanceItemHandle item(makeShared<ModuleAddedProvenanceItem>(name, mod->id().id_, editor_->saveNetwork()));`
	`312`	`+ ProvenanceItemHandle item(makeShared<ModuleAddedProvenanceItem>(name, mod->id().id_, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));`
`309`	`313`	`Q_EMIT provenanceItemCreated(item);`
`310`	`314`	`}`
`311`	`315`	`}`
`@@ -314,9 +318,7 @@ void GuiActionProvenanceConverter::moduleRemoved(const ModuleId& id)`
`314`	`318`	`{`
`315`	`319`	`if (!provenanceManagerModifyingNetwork_)`
`316`	`320`	`{`
`317`		`- ProvenanceItemHandle item(makeShared<ModuleRemovedProvenanceItem>(id, editor_->saveNetwork()));`
`318`		`- logCritical("REDO CODE: scirun_remove_module(\"{}\")", id.id_);`
`319`		`- logCritical("UNDO CODE: scirun_add_module(\"{}\")", id.name_);`
	`321`	`+ ProvenanceItemHandle item(makeShared<ModuleRemovedProvenanceItem>(id, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));`
`320`	`322`	`Q_EMIT provenanceItemCreated(item);`
`321`	`323`	`}`
`322`	`324`	`}`
`@@ -325,9 +327,9 @@ void GuiActionProvenanceConverter::connectionAdded(const SCIRun::Dataflow::Netwo`
`325`	`327`	`{`
`326`	`328`	`if (!provenanceManagerModifyingNetwork_)`
`327`	`329`	`{`
`328`		`- ProvenanceItemHandle item(makeShared<ConnectionAddedProvenanceItem>(cd, editor_->saveNetwork()));`
`329`		`- logCritical("REDO CODE: scirun_add_connection(\"{}\")", ConnectionId::create(cd).id_);`
`330`		`- logCritical("UNDO CODE: scirun_remove_connection(\"{}\")", ConnectionId::create(cd).id_);`
	`330`	`+ ProvenanceItemHandle item(makeShared<ConnectionAddedProvenanceItem>(cd, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));`
	`331`	`+ LOG_TRACE("REDO CODE: scirun_add_connection(\"{}\")", ConnectionId::create(cd).id_);`
	`332`	`+ LOG_TRACE("UNDO CODE: scirun_remove_connection(\"{}\")", ConnectionId::create(cd).id_);`
`331`	`333`	`Q_EMIT provenanceItemCreated(item);`
`332`	`334`	`}`
`333`	`335`	`}`
`@@ -336,7 +338,7 @@ void GuiActionProvenanceConverter::connectionRemoved(const SCIRun::Dataflow::Net`
`336`	`338`	`{`
`337`	`339`	`if (!provenanceManagerModifyingNetwork_)`
`338`	`340`	`{`
`339`		`- ProvenanceItemHandle item(makeShared<ConnectionRemovedProvenanceItem>(id, editor_->saveNetwork()));`
	`341`	`+ ProvenanceItemHandle item(makeShared<ConnectionRemovedProvenanceItem>(id, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));`
`340`	`342`	`logCritical("REDO CODE: scirun_remove_connection(\"{}\")", id.id_);`
`341`	`343`	`logCritical("UNDO CODE: scirun_add_connection(\"{}\")", id.id_);`
`342`	`344`	`Q_EMIT provenanceItemCreated(item);`
`@@ -347,7 +349,7 @@ void GuiActionProvenanceConverter::moduleMoved(const SCIRun::Dataflow::Networks:`
`347`	`349`	`{`
`348`	`350`	`if (!provenanceManagerModifyingNetwork_)`
`349`	`351`	`{`
`350`		`- ProvenanceItemHandle item(makeShared<ModuleMovedProvenanceItem>(id, newX, newY, editor_->saveNetwork()));`
	`352`	`+ ProvenanceItemHandle item(makeShared<ModuleMovedProvenanceItem>(id, newX, newY, editor_->saveNetwork(), NetworkEditorPythonAPI::getImpl()));`
`351`	`353`	`logCritical("REDO CODE: scirun_move_module(\"{}\", {}, {})", id.id_, newX, newY);`
`352`	`354`	`logCritical("UNDO CODE: scirun_move_module(\"{}\", {}, {})", id.id_, oldPos.x(), oldPos.y());`
`353`	`355`	`Q_EMIT provenanceItemCreated(item);`