Improve default algo updater

Author: dcwhite

src/Core/Algorithms/Base/AlgorithmBase.cc

@@ -254,7 +254,11 @@ void AlgorithmParameterList::addParameter(const AlgorithmParameterName& key, con
 
 AlgorithmStatusReporter::AlgorithmStatusReporter() 
 {
+#if DEBUG
   setUpdaterFunc(defaultUpdaterFunc_);
+#else
+  setUpdaterFunc([](double x) {});
+#endif
 }
 
 AlgorithmStatusReporter::UpdaterFunc AlgorithmStatusReporter::defaultUpdaterFunc_([](double r) { std::cout << "Algorithm at " << std::setiosflags(std::ios::fixed) << std::setprecision(2) << r*100 << "% complete" << std::endl;});

src/Core/Algorithms/BrainStimulator/ElectrodeCoilSetupAlgorithm.cc

@@ -821,7 +821,6 @@ boost::tuple<DenseMatrixHandle, FieldHandle, FieldHandle, VariableHandle> Electr
      /// use projected point r (that was projected on scalp surface) to differentiate which surface is the one to use
      /// but first splitbydomain to get the surface with tha value 1.0
      SplitFieldByDomainAlgo algo_splitfieldbydomain;
-     algo_splitfieldbydomain.setUpdaterFunc(getUpdaterFunc());
      algo_splitfieldbydomain.setLogger(getLogger());
      FieldList final_electrode_sponge_surf_domainsplit;  
      algo_splitfieldbydomain.set(SplitFieldByDomainAlgo::SortBySize, true);

src/Core/Algorithms/BrainStimulator/SetupRHSforTDCSandTMSAlgorithm.cc

@@ -489,7 +489,6 @@ boost::tuple<DenseMatrixHandle, DenseMatrixHandle, DenseMatrixHandle, DenseMatri
   /// use SplitFieldByDomainAlgo to find only labeled (based on elc. normal criteria) surfaces
   VMesh::Elem::index_type c_ind=0;
   SplitFieldByDomainAlgo algo2;
-  algo2.setUpdaterFunc(getUpdaterFunc());
   algo2.setLogger(getLogger());
   FieldList output;  
   algo2.set(SplitFieldByDomainAlgo::SortBySize, true);

src/Core/Algorithms/Legacy/Fields/MeshData/SetMeshNodes.cc

@@ -74,7 +74,6 @@ SetMeshNodesAlgo::run(FieldHandle input, DenseMatrixHandle matrix, FieldHandle&
   {
     /// @todo: worth separating out into factory call for mocking purposes? probably not, just keep the concrete dependence
     ConvertMeshToIrregularMeshAlgo algo;
-    algo.setUpdaterFunc(getUpdaterFunc());
 
     if (!algo.run(input,output))
       return (false);

src/Core/Algorithms/Legacy/Fields/RefineMesh/RefineMesh.cc

@@ -111,8 +111,8 @@ RefineMeshAlgo::runImpl(FieldHandle input, FieldHandle& output) const
     error("This algorithm does not support point or prism meshes");
     return(false);
   }
-    
-  if ((!(fi.is_scalar()))&&(addCon != "all"))
+
+  if ((!(fi.is_scalar())) && (addCon != "all"))
   {
     error("Field data needs to be of scalar type");
     return (false);
@@ -122,40 +122,39 @@ RefineMeshAlgo::runImpl(FieldHandle input, FieldHandle& output) const
   {
     RefineMeshQuadSurfAlgoV algo;
     algo.setUpdaterFunc(getUpdaterFunc());
-    return(algo.runImpl(input,output,addCon,isoVal));
+    return(algo.runImpl(input, output, addCon, isoVal));
   }
-  
+
   if (fi.is_hex_element())
   {
-		bool convex = false; 
-		convex = rMethod == "Expand refinement volume to improve element quality"; 
+    bool convex = false;
+    convex = rMethod == "Expand refinement volume to improve element quality";
     RefineMeshHexVolAlgoV algo;
     algo.setUpdaterFunc(getUpdaterFunc());
-		return(algo.runImpl(input,output,convex,addCon,isoVal));
+    return(algo.runImpl(input, output, convex, addCon, isoVal));
   }
 
   if (fi.is_crv_element())
   {
-			RefineMeshCurveAlgoV algo; 
-      algo.setUpdaterFunc(getUpdaterFunc());
-			return(algo.runImpl(input,output,addCon,isoVal));
+    RefineMeshCurveAlgoV algo;
+    algo.setUpdaterFunc(getUpdaterFunc());
+    return(algo.runImpl(input, output, addCon, isoVal));
   }
-  
+
   if (fi.is_tri_element())
-  { 
-			RefineMeshTriSurfAlgoV algo; 
-      algo.setUpdaterFunc(getUpdaterFunc());
-			return(algo.runImpl(input,output,addCon,isoVal));
+  {
+    RefineMeshTriSurfAlgoV algo;
+    algo.setUpdaterFunc(getUpdaterFunc());
+    return(algo.runImpl(input, output, addCon, isoVal));
   }
-  
+
   if (fi.is_tet_element())
   {
-			RefineMeshTetVolAlgoV algo; 
-      algo.setUpdaterFunc(getUpdaterFunc());
-			return(algo.runImpl(input,output,addCon,isoVal));
+    RefineMeshTetVolAlgoV algo;
+    algo.setUpdaterFunc(getUpdaterFunc());
+    return(algo.runImpl(input, output, addCon, isoVal));
   }
 
   error("No refinement method has been implemented for this type of mesh");
   return (false);
-}                           
-     
+}