Skip to content

Commit dbb8c78

Browse files
committed
Fix issues with CollectMatrices
1 parent b6a9b96 commit dbb8c78

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/Interface/Modules/Math/CollectMatricesDialog.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
*/
2828

2929
#include <Interface/Modules/Math/CollectMatricesDialog.h>
30-
#include <Dataflow/Network/ModuleStateInterface.h> //TODO: extract into intermediate
3130
#include <Core/Algorithms/Math/CollectMatrices/CollectMatricesAlgorithm.h>
3231

3332
using namespace SCIRun::Gui;
@@ -41,7 +40,7 @@ CollectMatricesDialog::CollectMatricesDialog(const std::string& name, ModuleStat
4140
setupUi(this);
4241
setWindowTitle(QString::fromStdString(name));
4342
fixSize();
44-
addRadioButtonGroupManager({ rowRadioButton_, columnRadioButton_ }, Parameters::CollectAppendIndicator);
45-
addRadioButtonGroupManager({ appendRadioButton_, replaceRadioButton_ }, Parameters::CollectRowIndicator);
43+
addRadioButtonGroupManager({ rowRadioButton_, columnRadioButton_ }, Parameters::CollectRowIndicator);
44+
addRadioButtonGroupManager({ appendRadioButton_, replaceRadioButton_ }, Parameters::CollectAppendIndicator);
4645
addRadioButtonGroupManager({ prependRadioButton_, postpendRadioButton_ }, Parameters::CollectPrependIndicator);
4746
}

src/Modules/Legacy/Math/CollectMatrices.cc

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,14 @@ CollectMatrices::execute()
116116
{
117117
update_state(NeedData);
118118

119-
//MatrixHandle aH, bH;
120119
auto aHOpt = getOptionalInput(Optional_BaseMatrix);
121120
auto bH = getRequiredInput(SubMatrix);
122121

123122
auto state = get_state();
124-
bool append = state->getValue(Parameters::CollectAppendIndicator).toInt() != 0;
125-
bool row = state->getValue(Parameters::CollectRowIndicator).toInt() != 0;
126-
bool front = state->getValue(Parameters::CollectPrependIndicator).toInt() != 0;
127-
123+
bool append = state->getValue(Parameters::CollectAppendIndicator).toInt() == 0;
124+
bool row = state->getValue(Parameters::CollectRowIndicator).toInt() == 0;
125+
bool front = state->getValue(Parameters::CollectPrependIndicator).toInt() == 0;
126+
128127
MatrixHandle omatrix;
129128

130129
if (!append) // Replace -- just send B matrix

0 commit comments

Comments
 (0)