Fix unit tests by reducing precision of comparison

Author: dcwhite

src/Interface/Modules/Render/Tests/ObjectRotationTests.cc

@@ -126,13 +126,13 @@ TEST_F(RotationTest, CanRotateArbitraryFromArbitrary)
 
   auto t = rotator.computeTransform(25, -42);
 
-  //std::cout << std::setprecision(16) << t.transform << std::endl;
-
   glm::mat4 expected;
   expected[0] = glm::vec4{0.9994457364082336,	-0.003830079222097993,	0.03306873887777328,	0};
   expected[1] = glm::vec4{0.002393543953076005,	0.9990561604499817,	0.04337168484926224,	0};
   expected[2] = glm::vec4{-0.03320364654064178,	-0.04326849430799484,	0.9985115528106689,	0};
   expected[3] = glm::vec4{0.09537804126739502,	0.1355232000350952,	-0.1153466701507568,	1};
 
-  EXPECT_TRUE(t.transform == expected);
+  //std::cout << std::setprecision(16) << t.transform << std::endl << expected << std::endl;
+
+  EXPECT_TRUE(epsilonEqual(t.transform, expected, 1e-5));
 }

src/Interface/Modules/Render/Tests/ObjectTransformationHelper.h

@@ -54,7 +54,8 @@ namespace SCIRun
       glm::mat4 getStaticCameraViewProjection() override { return {}; }
     };
 
-  bool operator==(const glm::mat4& lhs, const glm::mat4& rhs);
+    bool operator==(const glm::mat4& lhs, const glm::mat4& rhs);
+    bool epsilonEqual(const glm::mat4& lhs, const glm::mat4& rhs, float epsilon);
   }
 }
 

src/Interface/Modules/Render/Tests/ObjectTranslationTests.cc

@@ -28,6 +28,8 @@
 
 #include <gtest/gtest.h>
 #include <Interface/Modules/Render/Tests/ObjectTransformationHelper.h>
+#include <glm/gtc/epsilon.hpp>
+#include <glm/gtc/matrix_access.hpp>
 
 using namespace SCIRun;
 using namespace Render;
@@ -70,7 +72,15 @@ TEST_F(TranslationTest, CanConstruct)
 
 bool SCIRun::RenderTesting::operator==(const glm::mat4& lhs, const glm::mat4& rhs)
 {
-  return lhs[0] == rhs[0] && lhs[1] == rhs[1] && lhs[2] == rhs[2] && lhs[3] == rhs[3];
+  static const float epsilon = 1e-6f;
+  return epsilonEqual(lhs, rhs, epsilon);
+}
+
+bool SCIRun::RenderTesting::epsilonEqual(const glm::mat4& lhs, const glm::mat4& rhs, float epsilon)
+{
+  auto indexes = {0,1,2,3};
+  return std::all_of(std::begin(indexes), std::end(indexes),
+    [&](int i) { return glm::all(glm::epsilonEqual(glm::row(lhs, i), glm::row(rhs, i), epsilon)); });
 }
 
 TEST_F(TranslationTest, CanTranslateHorizontalFromOrigin)