Skip to content

Commit e7bb3c0

Browse files
committed
Closes #795
1 parent 6a1eff5 commit e7bb3c0

File tree

5 files changed

+8
-31
lines changed

5 files changed

+8
-31
lines changed

src/Core/Datatypes/Geometry.h

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ namespace Datatypes {
9898
bool normalize;
9999
};
100100

101-
SpireVBO(){}
102101
SpireVBO(const std::string& vboName, const std::vector<AttributeData> attribs,
103102
std::shared_ptr<CPM_VAR_BUFFER_NS::VarBuffer> vboData,
104103
int64_t numVBOElements, const Core::Geometry::BBox& bbox, bool placeOnGPU) :
@@ -127,7 +126,6 @@ namespace Datatypes {
127126
TRIANGLES,
128127
};
129128

130-
SpireIBO() {}
131129
SpireIBO(const std::string& iboName, PRIMITIVE primIn, size_t iboIndexSize,
132130
std::shared_ptr<CPM_VAR_BUFFER_NS::VarBuffer> iboData) :
133131
name(iboName),
@@ -148,7 +146,6 @@ namespace Datatypes {
148146
/// Defines a Spire object 'pass'.
149147
struct SpireSubPass
150148
{
151-
SpireSubPass() {}
152149
SpireSubPass(const std::string& name, const std::string& vboName,
153150
const std::string& iboName, const std::string& program,
154151
ColorScheme scheme, const RenderState& state,
@@ -165,14 +162,6 @@ namespace Datatypes {
165162
scalar(1.0)
166163
{}
167164

168-
static const char* getName() { return "SpireSubPass"; }
169-
170-
bool serialize(CPM_ES_CEREAL_NS::ComponentSerialize& /* s */, uint64_t /* entityID */)
171-
{
172-
// No need to serialize.
173-
return true;
174-
}
175-
176165
std::string passName;
177166
std::string vboName;
178167
std::string iboName;
@@ -191,7 +180,7 @@ namespace Datatypes {
191180
UNIFORM_VEC4
192181
};
193182

194-
Uniform(){}
183+
//Uniform(){}
195184
Uniform(const std::string& nameIn, float d) :
196185
name(nameIn),
197186
type(UNIFORM_SCALAR),

src/Interface/Modules/Render/ES/SRCamera.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class SRCamera
8383
/// Default camera settings
8484
/// @{
8585
static float getDefaultFOVY() {return 32.0f * (glm::pi<float>() / 180.0f);}
86-
static float getDefaultZNear() {return 0.1f;}
86+
static float getDefaultZNear() {return 0.001f;}
8787
static float getDefaultZFar() {return 100000.0f;}
8888
/// @}
8989

src/Interface/Modules/Render/ES/SRInterface.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@ namespace SCIRun {
180180
float aspect = static_cast<float>(width) / static_cast<float>(height);
181181

182182
float perspFOVY = 0.59f;
183-
float perspZNear = 1.0f;
184-
float perspZFar = 2000.0f;
183+
float perspZNear = 0.01f;
184+
float perspZFar = 20000.0f;
185185
glm::mat4 proj = glm::perspective(perspFOVY, aspect, perspZNear, perspZFar);
186186
cam->data.setProjection(proj, perspFOVY, aspect, perspZNear, perspZFar);
187187

@@ -469,7 +469,6 @@ namespace SCIRun {
469469

470470
if (pass.renderType == Core::Datatypes::GeometryObject::RENDER_VBO_IBO)
471471
{
472-
//reorderIBO(pass);
473472
addVBOToEntity(entityID, pass.vboName);
474473
for (int i = 0; i <= 6; ++i)
475474
{
@@ -523,7 +522,6 @@ namespace SCIRun {
523522
assetName = "Assests/arrow.geom";
524523
}
525524

526-
//reorderIBO(pass);
527525
addVBOToEntity(entityID, assetName);
528526
addIBOToEntity(entityID, assetName);
529527
}

src/Interface/Modules/Render/ES/systems/RenderTransBasicSys.cc

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include <es-render/comp/MatUniform.hpp>
2121
#include <es-render/comp/StaticGLState.hpp>
2222
#include <es-render/comp/StaticVBOMan.hpp>
23-
#include <es-render/comp/StaticIBOMan.hpp>
2423

2524
#include <bserialize/BSerialize.hpp>
2625

@@ -57,8 +56,7 @@ class RenderBasicSysTrans :
5756
StaticWorldLight,
5857
gen::StaticCamera,
5958
ren::StaticGLState,
60-
ren::StaticVBOMan,
61-
ren::StaticIBOMan>
59+
ren::StaticVBOMan>
6260
{
6361
public:
6462

@@ -92,8 +90,7 @@ class RenderBasicSysTrans :
9290
const es::ComponentGroup<StaticWorldLight>& worldLight,
9391
const es::ComponentGroup<gen::StaticCamera>& camera,
9492
const es::ComponentGroup<ren::StaticGLState>& defaultGLState,
95-
const es::ComponentGroup<ren::StaticVBOMan>& vboMan,
96-
const es::ComponentGroup<ren::StaticIBOMan>& iboMan) override
93+
const es::ComponentGroup<ren::StaticVBOMan>& vboMan) override
9794
{
9895
/// \todo This needs to be moved to pre-execute.
9996
if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE)
@@ -352,8 +349,6 @@ class RenderBasicSysTrans :
352349
}
353350
}
354351

355-
//iboMan.front().instance->removeInMemoryIBO(iboID);
356-
357352
if (depthMask)
358353
{
359354
GL(glDepthMask(GL_TRUE));

src/Interface/Modules/Render/ES/systems/RenderTransColorMapSys.cc

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include <es-render/comp/MatUniform.hpp>
2121
#include <es-render/comp/StaticGLState.hpp>
2222
#include <es-render/comp/StaticVBOMan.hpp>
23-
#include <es-render/comp/StaticIBOMan.hpp>
2423

2524
#include "../comp/RenderColorMapGeom.h"
2625
#include "../comp/SRRenderState.h"
@@ -56,8 +55,7 @@ class RenderColorMapSysTrans :
5655
StaticWorldLight,
5756
gen::StaticCamera,
5857
ren::StaticGLState,
59-
ren::StaticVBOMan,
60-
ren::StaticIBOMan>
58+
ren::StaticVBOMan>
6159
{
6260
public:
6361

@@ -92,8 +90,7 @@ class RenderColorMapSysTrans :
9290
const es::ComponentGroup<StaticWorldLight>& worldLight,
9391
const es::ComponentGroup<gen::StaticCamera>& camera,
9492
const es::ComponentGroup<ren::StaticGLState>& defaultGLState,
95-
const es::ComponentGroup<ren::StaticVBOMan>& vboMan,
96-
const es::ComponentGroup<ren::StaticIBOMan>& iboMan) override
93+
const es::ComponentGroup<ren::StaticVBOMan>& vboMan) override
9794
{
9895
/// \todo This needs to be moved to pre-execute.
9996
if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE)
@@ -364,8 +361,6 @@ class RenderColorMapSysTrans :
364361
}
365362
}
366363

367-
//iboMan.front().instance->removeInMemoryIBO(iboID);
368-
369364
if (depthMask)
370365
{
371366
GL(glDepthMask(GL_TRUE));

0 commit comments

Comments
 (0)