Skip to content

Commit cea8246

Browse files
authored
2341 - Fix mac/intel runner (#2352)
* Try macos-13 GHA runner * Attempting to use older SDK and target no longer works on macos-13 runner.
1 parent 99f848f commit cea8246

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

.github/workflows/build-mac.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,21 @@ concurrency:
2424
jobs:
2525
build:
2626

27-
runs-on: macos-12
27+
runs-on: macos-13
2828

2929
steps:
3030

31+
- name: Setup Miniconda
32+
uses: conda-incubator/[email protected]
33+
3134
- name: OS Setup
3235
run: |
33-
ls /usr/local
34-
uname -m
35-
echo $CONDA
36+
echo CONDA=$CONDA
3637
sudo chown -R $UID $CONDA
3738
conda init zsh
3839
source ~/.zshrc
3940
brew install ccache pigz gnu-tar coreutils
4041
41-
- name: Acquire 10.15 SDK
42-
run: |
43-
curl -L -o $HOME/MacOSX10.15.sdk.tar.xz https://github.com/phracker/MacOSX-SDKs/releases/download/11.3/MacOSX10.15.sdk.tar.xz
44-
cd $HOME && tar -xJf MacOSX10.15.sdk.tar.xz
45-
4642
- name: Checkout code
4743
uses: actions/checkout@v3
4844
with:
@@ -61,7 +57,7 @@ jobs:
6157

6258
- name: cmake
6359
shell: bash -l {0}
64-
run: conda activate shapeworks && mkdir build && cd build && cmake -DCMAKE_LIBTOOL=/usr/bin/libtool -DCMAKE_CXX_FLAGS=-g -DCMAKE_PREFIX_PATH=$HOME/install -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DPython3_ROOT_DIR:FILEPATH=${CONDA_PREFIX} -DUSE_OPENMP=OFF -DBuild_Studio=ON -DCMAKE_INSTALL_PREFIX=${GITHUB_WORKSPACE}/shapeworks-install -DCMAKE_OSX_SYSROOT="$HOME/MacOSX10.15.sdk" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.15" -DBUILD_DOCUMENTATION=ON -DGA_MEASUREMENT_ID=$GA_MEASUREMENT_ID -DGA_API_SECRET=$GA_API_SECRET ..
60+
run: conda activate shapeworks && mkdir build && cd build && cmake -DCMAKE_LIBTOOL=/usr/bin/libtool -DCMAKE_CXX_FLAGS=-g -DCMAKE_PREFIX_PATH=$HOME/install -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DPython3_ROOT_DIR:FILEPATH=${CONDA_PREFIX} -DUSE_OPENMP=OFF -DBuild_Studio=ON -DCMAKE_INSTALL_PREFIX=${GITHUB_WORKSPACE}/shapeworks-install -DBUILD_DOCUMENTATION=ON -DGA_MEASUREMENT_ID=$GA_MEASUREMENT_ID -DGA_API_SECRET=$GA_API_SECRET ..
6561

6662
- name: make
6763
shell: bash -l {0}

.github/workflows/gha_deps.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ else
2525

2626
NPROCS=4
2727

28-
# if intel mac and not arm64, using uname -m to detect arm64
29-
if [[ "$PLATFORM" == "mac-intel" ]]; then
30-
export SDKROOT=$HOME/MacOSX10.15.sdk # only needed for MacOS obviously
31-
export MACOSX_DEPLOYMENT_TARGET=10.15
32-
fi
33-
3428
if [[ "$PLATFORM" == "linux" ]]; then
3529
# GHA runner is running out of resources with 4 now on linux
3630
NPROCS=2

0 commit comments

Comments
 (0)