Skip to content

Commit ede45bd

Browse files
more changes
1 parent abd8fcf commit ede45bd

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

Libs/Particles/ParticleShapeStatistics.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,7 @@ ParticleShapeStatistics::ParticleShapeStatistics(std::shared_ptr<Project> projec
497497

498498
Eigen::VectorXd ParticleShapeStatistics::compute_regression_mean(
499499
const std::vector<double>& explanatory_variables) const {
500+
std::cout << "Computing mean for regression" << std::endl;
500501
Eigen::VectorXd t = Eigen::Map<const Eigen::VectorXd>(
501502
explanatory_variables.data(), explanatory_variables.size());
502503

Libs/Particles/ParticleShapeStatistics.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ class ParticleShapeStatistics {
159159
// for regression tasks
160160
Eigen::VectorXd slope_;
161161
Eigen::VectorXd intercept_;
162-
bool regression_enabled_;
163162

164163
std::vector<double> percent_variance_by_mode_;
165164
Eigen::MatrixXd principals_;

Studio/Analysis/AnalysisTool.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ bool AnalysisTool::compute_stats() {
713713

714714
bool check_explanatory_variable_limits() {
715715
auto subjects = session_->get_project()->get_subjects();
716-
explanatory_variable_limits_.resize(2);
716+
explanatory_variable_limits_.resize(2, 0.0);
717717
explanatory_variable_limits_[0] = std::numeric_limits<double>::max();
718718
explanatory_variable_limits_[1] = std::numeric_limits<double>::lowest();
719719
for (auto sub : subjects) {
@@ -786,7 +786,7 @@ Particles AnalysisTool::get_shape_points(int mode, double value) {
786786
ui_->explained_variance->setText("");
787787
ui_->cumulative_explained_variance->setText("");
788788
}
789-
auto mean = !regression_enabled_ ? stats_.get_mean() : stats_.compute_regression_mean(ui_->get_explanatory_variable_value());
789+
auto mean = !get_regression_analysis_status() ? stats_.get_mean() : stats_.compute_regression_mean(ui_->get_explanatory_variable_value());
790790
temp_shape_ = mean + (e * (value * lambda));
791791

792792
auto positions = temp_shape_;
@@ -1155,7 +1155,8 @@ double AnalysisTool::get_pca_value() {
11551155

11561156
std::vector<double> AnalysisTool::get_explanatory_variable_value() {
11571157
int slider_value = ui_->explanatoryVariableSlider->value();
1158-
return {t_min + (static_cast<double>(slider_value) / 100.0) * (t_max - t_min)};
1158+
// return {t_min + (static_cast<double>(slider_value) / 100.0) * (t_max - t_min)};
1159+
return {explanatory_variable_limits_[0] + (static_cast<double>(slider_value) / 100.0) * (explanatory_variable_limits_[1] - explanatory_variable_limits_[0])};
11591160

11601161
}
11611162

Studio/Interface/ShapeWorksStudioApp.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1528,14 +1528,6 @@ void ShapeWorksStudioApp::open_project(QString filename) {
15281528

15291529
groom_tool_->load_params();
15301530
optimize_tool_->load_params();
1531-
1532-
if (optimize_tool_->get_regression_analysis_status())
1533-
{
1534-
// Verify if slope and intercept files exist
1535-
// auto particles_dir = session_->get_filename().dir().absolutePath().toStdString();
1536-
// auto slope_filename = session_->get_filename().toStdString();
1537-
}
1538-
analysis_tool_->store_settings();
15391531
update_from_preferences();
15401532

15411533
update_tool_mode();

0 commit comments

Comments
 (0)