Fixed issue with vectorLength, removed it from test file #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsmith
reviewed
Oct 12, 2022
src/SliceWrapper.hpp
Outdated
| class CabSliceFactory { | ||
| static constexpr int vecLen = Impl::PerformanceTraits<ExecutionSpace>::vector_length/8; | ||
| public: | ||
| static constexpr int vecLen = Impl::PerformanceTraits<ExecutionSpace>::vector_length; |
Contributor
There was a problem hiding this comment.
Since it is static constexpr in the AoSoA object, would the following work?
static constexpr int vecLen = Cabana::AoSoA<DataTypes, DeviceType, vecLen>::vector_length;
Contributor
Author
There was a problem hiding this comment.
Ill try it out!
cwsmith
approved these changes
Oct 12, 2022
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Looks good. Feel free to merge if you are all set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.