Skip to content

Conversation

@HazelCullom
Copy link
Contributor

updated test cases and added array type support

Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few comments are below.

Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It looks like some code for the ordered tests was accidentally added. Once that is removed this is good to merge.

@HazelCullom HazelCullom merged commit 79a3178 into main Oct 20, 2022
@HazelCullom HazelCullom deleted the multi-slice-cab-factory branch October 20, 2022 14:09
@HazelCullom HazelCullom restored the multi-slice-cab-factory branch October 20, 2022 14:09
@cwsmith cwsmith deleted the multi-slice-cab-factory branch November 2, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants