Parallel for abstraction #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do as kokkos does in their parallel_for
Contributor
|
@HenryCullom Please add a description of the PR (i.e., what was added) in the opening post. |
cwsmith
requested changes
Nov 3, 2022
Contributor
There was a problem hiding this comment.
Looks good to me. I pushed a commit to use std::move(...) on the slice object in makeField(...). Based on valgrind, this doesn't appear like it was required, but I think the code better expresses the intent of the Field instance owning the slice.
One suggestion, I think we should prefix the test file names with test to make it clearer that they are tests and not implementations of the header files. -- Just pushed this with c9bccae.
This was referenced Nov 3, 2022
Closed
cwsmith
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the MeshField class and Field class that are templated over the SliceWrapper and SliceController types as abstractions to hide the underlying implementation, whether it be cabana, omega_h, kokkos, or something else.
Created a parallel_for absraction that adds parallel_for functionality and hides the underlying implementation from the user