Jk/num comp lagrange #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsmith
requested changes
Jun 24, 2025
Contributor
There was a problem hiding this comment.
Looks good. Thank you. A few comments are below.
It looks like
meshFields/src/MeshField_Shape.hpp
Line 39 in e401f7e
isn't being used with these changes. If that is correct, we should remove it and other similar definitions in the other shape functions.
We should also do a test with three components as that is going to be one of the common sizes.
Contributor
|
/runtests |
cwsmith
requested changes
Jun 25, 2025
|
Test Result: success (details) |
Contributor
|
/runtests |
|
Test Result: success (details) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
/runtests |
|
Test Result: success (details) |
cwsmith
requested changes
Jun 27, 2025
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Thanks for the fix for the CI builds. I think we should add one more test before merging this. If you see a way to consolidate some of the repeated blocks of code for the tests that would be appreciated, but not necessary.
Contributor
|
/runtests |
|
Test Result: success (details) |
cwsmith
approved these changes
Jun 30, 2025
This was referenced Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User defined number of components for createLagrangeField