tetrahedron integration #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2025 20:00
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cwsmith
requested changes
Aug 15, 2025
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Looks good. Thank you.
We'll have to define some better integration tests. The current one is just counting integration points over the mesh.
I only see one minor change.
Would you please run the clang-format on this when you get a chance?
added 2 commits
August 15, 2025 13:38
cwsmith
requested changes
Aug 18, 2025
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
A few more comments/suggestions.
Contributor
|
/runtests |
|
Test Result: success (details) |
cwsmith
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functionality for integrating tetrahedron (linear and quadratic).