Skip to content

Conversation

@Sichao25
Copy link
Contributor

@Sichao25 Sichao25 commented Sep 9, 2025

Resolved the missing return statement at end of non-void function warnings reported in CDash builds using GCC 13.2.0.

@cwsmith
Copy link
Contributor

cwsmith commented Sep 10, 2025

Thank you. Would you mind also pushing the Kokkos HostMirror -> host_mirror_type changes to this branch (https://github.com/kokkos/kokkos/blob/6dbe8b49ba75b93ee09ace6c6934cbef908389cc/core/src/Kokkos_View.hpp#L234-L238)? We can rename the PR accordingly.

@Sichao25
Copy link
Contributor Author

Do we use HostMirror in meshFields? I didn't find any usage of it.

@cwsmith
Copy link
Contributor

cwsmith commented Sep 10, 2025

Whoops. I misread the omegah build errors as meshfields errors. Sorry about that.

@Sichao25
Copy link
Contributor Author

No worries. Is there a specific reason to use the sandialabs/omega_h in meshFields checks?

@cwsmith
Copy link
Contributor

cwsmith commented Sep 10, 2025

Nope. Good catch. It should be using our repo.

@cwsmith cwsmith marked this pull request as ready for review September 11, 2025 14:54
@cwsmith cwsmith merged commit 4a20f6c into SCOREC:main Sep 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants