add tolerances #79
Merged
add tolerances #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobmerson
force-pushed
the
mesh-fields-tolerances
branch
from
83e3885 to
e0be3e0
Compare
Contributor
|
/runtests |
|
Test Result: failure (details) |
Contributor
Author
|
Are you able to see what the issue would be in the asics test? There are not enough details. Possibly we should add |
Contributor
|
/runtests |
|
Test Result: failure (details) |
Contributor
|
/runtests |
|
Test Result: failure (details) |
Contributor
|
@jacobmerson I submitted a PR to your branch with a few small changes jacobmerson#1. The fix for the failing test in self-hosted CI was pushed to main (3b5125e). |
tolerances
Contributor
Author
|
/runtests |
|
Test Result: failure (details) |
cwsmith
approved these changes
Nov 17, 2025
Contributor
|
I'm not sure what is happening with the self-hosted CI failing; this commit (3b5125e) should have fixed the element count check. I'll fix it in another PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides tolerances that should work with PCMS and lets the user specify. Addresses #69