[PR #3815] change per reveiw: drop unneeded try block in Python node

Signed-off-by: Mats Wichmann <[email protected]>

Author: mwichmann

CHANGES.txt

@@ -63,7 +63,7 @@ RELEASE  VERSION/DATE TO BE FILLED IN LATER
     - Make sure cProfile is used if profiling - SCons was expecting
       the Util module to monkeypatch in cProfile as profile if available,
       but this is no longer being done.
-    - Some Python 2 compat dropped
+    - Some Python 2 compatibility code dropped
 
   From Simon Tegelid
     - Fix using TEMPFILE in multiple actions in an action list. Previously a builder, or command

SCons/Node/Python.py

@@ -143,19 +143,14 @@ def get_text_contents(self) -> str:
 
     def get_contents(self) -> bytes:
         """Get contents for signature calculations."""
-        text_contents = self.get_text_contents()
-        try:
-            return text_contents.encode()
-        except AttributeError:
-            # Should not happen, as get_text_contents returns str
-            return text_contents
+        return self.get_text_contents().encode()
 
     def changed_since_last_build(self, target, prev_ni):
         cur_csig = self.get_csig()
         try:
             return cur_csig != prev_ni.csig
         except AttributeError:
-            return 1
+            return True
 
     def get_csig(self, calc=None):
         """Because we're a Python value node and don't have a real