Prevent files from being partially read from the cache

Author: ravenAtSafe

SCons/CacheDir.py

@@ -66,7 +66,20 @@ def CacheRetrieveFunc(target, source, env) -> int:
         if fs.islink(cachefile):
             fs.symlink(fs.readlink(cachefile), t.get_internal_path())
         else:
-            cd.copy_from_cache(env, cachefile, t.get_internal_path())
+            try:
+                env.copy_from_cache(cachefile, t.get_internal_path())
+            except:
+                try:
+                    # In case file was partially retrieved (and now corrupt)
+                    # delete it to avoid poisoning commands like 'ar' that
+                    # read from the initial state of the file they are writing
+                    # to.
+                    t.fs.unlink(t.get_internal_path())
+                except:
+                    pass
+
+                raise
+
             try:
                 os.utime(cachefile, None)
             except OSError:
@@ -80,8 +93,8 @@ def CacheRetrieveString(target, source, env) -> str:
     cd = env.get_CacheDir()
     cachedir, cachefile = cd.cachepath(t)
     if t.fs.exists(cachefile):
-        return "Retrieved `%s' from cache" % t.get_internal_path()
-    return ""
+        return "Retrieving `%s' from cache" % t.get_internal_path()
+    return None
 
 CacheRetrieve = SCons.Action.Action(CacheRetrieveFunc, CacheRetrieveString)
 

SCons/Taskmaster/__init__.py

@@ -233,10 +233,13 @@ def execute(self):
                 cached_targets.append(t)
             if len(cached_targets) < len(self.targets):
                 # Remove targets before building. It's possible that we
-                # partially retrieved targets from the cache, leaving
-                # them in read-only mode. That might cause the command
+                # retrieved a subset of targets from the cache, leaving
+                # them in an inconsistent state. That might cause the command
                 # to fail.
                 #
+                # Note that retrieve_from_cache() ensures no single target can
+                # be partially retrieved (file left in corrupt state).
+                #
                 for t in cached_targets:
                     try:
                         t.fs.unlink(t.get_internal_path())