Skip to content

Commit 141b8a5

Browse files
committed
Update the podspec && carthage to use the latest SVGKit release
1 parent 65a5e5e commit 141b8a5

File tree

5 files changed

+25
-14
lines changed

5 files changed

+25
-14
lines changed

Cartfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
github "SDWebImage/SDWebImage" >= 5.0.0-beta3
2-
github "SVGKit/SVGKit" "2.x"
2+
github "SVGKit/SVGKit" >= 2.1

Example/Podfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ PODS:
77
- CocoaLumberjack/Default
88
- SDWebImage/Core (5.0.0-beta3)
99
- SDWebImageSVGCoder (0.1.0):
10-
- SDWebImage/Core (>= 5.0.0-beta2)
11-
- SVGKit (>= 2.x)
10+
- SDWebImage/Core (>= 5.0.0-beta3)
11+
- SVGKit (>= 2.1)
1212
- SVGKit (2.1.0):
1313
- CocoaLumberjack (~> 3.0)
1414

@@ -31,7 +31,7 @@ CHECKOUT OPTIONS:
3131
SPEC CHECKSUMS:
3232
CocoaLumberjack: db7cc9e464771f12054c22ff6947c5a58d43a0fd
3333
SDWebImage: e52654ceef9fdc19f4c612d64a5b6d3f05dd81a4
34-
SDWebImageSVGCoder: a39ffaef7618b138d18eef8e3c49c96a3637fbe2
34+
SDWebImageSVGCoder: adcf27c5fe8424441f515f54409c64b57dbaed1b
3535
SVGKit: 8a2fc74258bdb2abb54d3b65f3dd68b0277a9c4d
3636

3737
PODFILE CHECKSUM: dc5153f27ba2a6dd43c49d8e0100b34b78f46730

Example/SDWebImageSVGCoder/SDViewController.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ - (void)viewDidLoad
3737

3838
// `SVGKFastImageView`, draw SVG as bitmap dynamically when size changed.
3939
SVGKImageView *imageView2 = [[SVGKFastImageView alloc] initWithFrame:CGRectMake(0, screenSize.height / 2, screenSize.width, screenSize.height / 2)];
40-
imageView2.sd_adjustContentMode = YES;
4140
imageView2.clipsToBounds = YES;
4241

4342
// `UIImageView`, draw SVG as bitmap image with fixed size, like PNG.

SDWebImageSVGCoder.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ TODO: Add long description of the pod here.
3333
s.source_files = 'SDWebImageSVGCoder/Classes/**/*', 'SDWebImageSVGCoder/Module/SDWebImageSVGCoder.h'
3434
s.module_map = 'SDWebImageSVGCoder/Module/SDWebImageSVGCoder.modulemap'
3535

36-
s.dependency 'SDWebImage/Core', '>= 5.0.0-beta2'
37-
s.dependency 'SVGKit', '>= 2.x'
36+
s.dependency 'SDWebImage/Core', '>= 5.0.0-beta3'
37+
s.dependency 'SVGKit', '>= 2.1'
3838
end

SDWebImageSVGCoder/Classes/SDWebImageSVGCoderDefine.m

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ void SDAdjustSVGContentMode(SVGKImage * svgImage, UIViewContentMode contentMode,
2424
CGFloat hScale = viewSize.height / imageSize.height;
2525
CGFloat imageAspect = imageSize.width / imageSize.height;
2626
CGFloat viewAspect = viewSize.width / viewSize.height;
27-
CGFloat smallestScaleUp = MIN(wScale, hScale);
28-
CGFloat biggestScaleDown = MAX(wScale, hScale);
2927
CGFloat xPosition;
3028
CGFloat yPosition;
3129

@@ -36,10 +34,24 @@ void SDAdjustSVGContentMode(SVGKImage * svgImage, UIViewContentMode contentMode,
3634
}
3735
break;
3836
case UIViewContentModeScaleAspectFit: {
39-
CGFloat scale = smallestScaleUp < 1.0f ? biggestScaleDown : smallestScaleUp;
37+
CGFloat scale;
38+
if (imageAspect > viewAspect) {
39+
// scale width
40+
scale = wScale;
41+
} else {
42+
// scale height
43+
scale = hScale;
44+
}
4045
CGSize targetSize = CGSizeApplyAffineTransform(imageSize, CGAffineTransformMakeScale(scale, scale));
41-
xPosition = (viewSize.width - targetSize.width) / 2;
42-
yPosition = (viewSize.height - targetSize.height) / 2;
46+
if (imageAspect > viewAspect) {
47+
// need center y as well
48+
xPosition = 0;
49+
yPosition = ABS(targetSize.height - viewSize.height) / 2;
50+
} else {
51+
// need center x as well
52+
xPosition = ABS(targetSize.width - viewSize.width) / 2;
53+
yPosition = 0;
54+
}
4355
svgImage.size = targetSize;
4456
svgImage.DOMTree.viewport = SVGRectMake(xPosition, yPosition, targetSize.width, targetSize.height);
4557
// masksToBounds to clip the sublayer which beyond the viewport to match `UIImageView` behavior
@@ -59,10 +71,10 @@ void SDAdjustSVGContentMode(SVGKImage * svgImage, UIViewContentMode contentMode,
5971
if (imageAspect < viewAspect) {
6072
// need center y as well
6173
xPosition = 0;
62-
yPosition = (targetSize.height - viewSize.height) / 2;
74+
yPosition = ABS(targetSize.height - viewSize.height) / 2;
6375
} else {
6476
// need center x as well
65-
xPosition = (targetSize.width - viewSize.width) / 2;
77+
xPosition = ABS(targetSize.width - viewSize.width) / 2;
6678
yPosition = 0;
6779
}
6880
svgImage.size = targetSize;

0 commit comments

Comments
 (0)