Skip to content

Commit 5a7de5a

Browse files
Merge pull request #20 from SELab-2/remove-dev-container-files
fix: added volume binds to Docker Containers
2 parents d938ee8 + 53b961b commit 5a7de5a

File tree

4 files changed

+9
-58
lines changed

4 files changed

+9
-58
lines changed

README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@
22

33
## Configuration and Deployement
44

5-
This project is configured to have 3 modules, each forming a subproject:
5+
This project is configured to have 2 modules, each forming a subproject:
66

77
```
88
.
99
├── backend
10-
├── database
1110
├── frontend
1211
├── LICENSE
1312
└── README.md
@@ -46,9 +45,9 @@ We link to the [Docker Compose documentation](https://docs.docker.com/compose/in
4645

4746
### Dev Containers
4847

49-
The team makes use of [VSCode Dev Containers](https://code.visualstudio.com/docs/devcontainers/containers) to streamline development.
50-
Each of the subprojects can be opened in a container,
51-
where the developer can then make use of the running (containerized) services.
48+
If you want to develop inside one of the containers,
49+
you can attach your running VSCode session to this container using ``CTRL + SHIFT + P``,
50+
then selecting ``Attach to running container``.
5251

5352
### Caveats and Debug tips:
5453

backend/.devcontainer/devcontainer.json

Lines changed: 0 additions & 25 deletions
This file was deleted.

compose.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ services:
1111
database:
1212
condition: service_healthy
1313
volumes:
14-
- /workspace/backend/node_modules
14+
- ./backend:/workspace/backend # Bind local backend folder to container
15+
- /workspace/backend/node_modules # Anonymous volume for node_modules
1516
restart: always
1617

1718
frontend:
@@ -25,7 +26,8 @@ services:
2526
depends_on:
2627
- backend
2728
volumes:
28-
- /workspace/frontend/node_modules
29+
- ./frontend:/workspace/frontend # Bind local frontend folder to container
30+
- /workspace/frontend/node_modules # Anonymous volume for node_modules
2931
restart: always
3032

3133
database:
@@ -35,7 +37,7 @@ services:
3537
ports:
3638
- "5432:5432"
3739
volumes:
38-
- ./backend/src/infrastructure/database:/workspace/database
40+
- ./backend/src/infrastructure/database:/workspace/database # Bind local database folder
3941
environment:
4042
- POSTGRES_USER=postgres
4143
- POSTGRES_PASSWORD=postgres

frontend/.devcontainer/devcontainer.json

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)