smaller fixes

Author: fquirin

www/css/sepiaFW-cards.css

@@ -748,6 +748,9 @@
 	font-size: 15px;
 	max-width: 100%;
 }
+.sepiaFW-cards-list-body .linkCard .linkCardCenter h3:only-child {
+	margin: 5px;
+}
 .sepiaFW-cards-list-body .linkCard .linkCardCenter p {
 	word-wrap: break-word;
 	max-width: 100%;

www/scripts/sepiaFW.ui.cards.embed.js

@@ -423,9 +423,13 @@ function sepiaFW_build_ui_cards_embed(){
 		}
 
 		//Specials
-		thisPlayer.openInExternalPage = function(){
+		thisPlayer.openInExternalPage = function(givenUrl){
 			//TODO: implement
-			SepiaFW.ui.showPopup(SepiaFW.local.g("cant_execute") + " (Coming Soon)");
+			if (givenUrl){
+				SepiaFW.ui.actions.openUrlAutoTarget(givenUrl, true);
+			}else{
+				SepiaFW.ui.showPopup(SepiaFW.local.g("cant_execute") + " (Coming Soon)");
+			}
 		}
 
 		//Release resources and remove handler

www/scripts/sepiaFW.ui.cards.js

@@ -1278,7 +1278,7 @@ function sepiaFW_build_ui_cards(){
 		var rightElement = "<div class='itemRight linkCardRight'><a href='' target='_blank' rel='noopener'><i class='material-icons md-mnu'>&#xE895;</i></a></div>";
 		linkCardEle.innerHTML = leftElement
 				+ SepiaFW.tools.sanitizeHtml("<div class='itemCenter linkCardCenter'>" 
-					+ (data.title? ("<h3>" + data.title + "</h3>") : ("")) + "<p>" + description + "</p></div>")
+					+ (data.title? ("<h3>" + data.title + "</h3>") : ("")) + (description? ("<p>" + description + "</p></div>") : ""))
 				+ rightElement;
 		linkCardEle.title = linkUrl || data.title;
 		//linkCardEle.setAttribute('data-element', JSON.stringify(cardElementInfo));
@@ -1311,7 +1311,7 @@ function sepiaFW_build_ui_cards(){
 			SepiaFW.ui.onclick($(linkCardEle).find('.linkCardRight')[0], function(event){
 				event.preventDefault();
 				if (embedWebPlayer && typeInfo.mediaPlayer){
-					typeInfo.mediaPlayer.openInExternalPage();
+					typeInfo.mediaPlayer.openInExternalPage(linkUrl);
 				}else if (linkUrl){
 					SepiaFW.ui.actions.openUrlAutoTarget(linkUrl, true);
 				}else{

www/templates/media-player_template.html

@@ -89,7 +89,7 @@
 				//settings previously sent by the widget (widget/app specific etc. - NOTE: avoid autoplay!)
 				handleSettingsRestore(ev);
 			}else{
-				console.error("event", ev);
+				console.error("event", ev);		//DEBUG
 			}
 		}
 
@@ -103,7 +103,7 @@
 
 		function handleSettingsRestore(ev){
 			//any widget specific data submitted by widget itself (either via 'postSettings' or during 'ready')
-			console.error("Settings", ev.settings);
+			console.error("Settings", ev.settings);		//DEBUG
 			var settings = ev.settings;
 			//restore
 			autoplay = settings.autoplay || false;
@@ -114,33 +114,35 @@
 
 		function handleControls(ev){
 			//play, pause, fadeOut, fadeIn, next, previous, volumeUp, volumeDown, ... tbd
-			console.error("Controls", ev.controls);
+			console.error("Controls", ev.controls);		//DEBUG
 			var ctrl = ev.controls;
-			if (player){
-				switch (ev.controls){
-					case "play":
-					case "fadeIn":		//for now just stop (alt.: reduce volume)
-						player.play();
-						break;
-					case "pause":
-					case "stop":
-					case "fadeOut":		//for now just resume (alt.: restore volume)
-						player.pause();
-						break;
-					case "volumeUp":
-					case "volumeDown":
-						//ignore for now
-						break;
-					default:
-						//Error: UnknownEvent
-						postError("UnknownEvent", "Unknown control event: " + ev.controls, 1);
-						break;
-				}
+			switch (ev.controls){
+				case "play":
+				case "fadeIn":		//for now just resume (alt.: restore volume)
+					player.play();
+					break;
+				case "pause":
+				case "stop":
+				case "fadeOut":		//for now just pause (alt.: reduce volume)
+					player.pause();
+					break;
+				case "next":
+				case "previous":
+					//TODO: ignored for now
+					break;
+				case "volumeUp":
+				case "volumeDown":
+					//TODO: ignored for now
+					break;
+				default:
+					//Error: UnknownEvent
+					postError("UnknownEvent", "Unknown control event: " + ev.controls, 1);
+					break;
 			}
 		}
 
 		function handleMediaRequest(ev){
-			console.error("Media request", ev.mediaRequest);
+			console.error("Media request", ev.mediaRequest);		//DEBUG
 			var mr = ev.mediaRequest;
 			/* type: music:
 			{
@@ -151,7 +153,8 @@
 				"album": "",
 				"service": "",
 				"genre": "",
-				"uri": ""
+				"uri": "",
+				"serviceResult": {...}	//specific to service
 			}*/
 			var safeRequest = ev.safeRequest;	//request came from assistant or private channel?
 			autoplay = ev.autoplay;
@@ -188,7 +191,7 @@
 				player.title = title || "";
 
 				//Backup settings
-				restoreSettings.src = player.src
+				restoreSettings.src = player.src;
 				restoreSettings.autoplay = false;	//this should only be true at actualy requests
 				restoreSettings.title = player.title;
 				restoreSettings.preload = player.preload;	//add?