fixed bugs in media player and client controls (fadeOut handling)

Author: fquirin

www/scripts/sepiaFW.client.controls.js

@@ -241,11 +241,12 @@ function sepiaFW_build_client_controls(sepiaSessionId){
                     //Embedded media player
                     sentAdditionalEvent = SepiaFW.ui.cards.embed.stopAllMediaPlayers();
                     SepiaFW.debug.info("Client controls - Media: stopping embedded media player(s)");
-                }else if (SepiaFW.ui.isAndroid){
+                }
+                if (SepiaFW.ui.isAndroid){
                     //we do this only if we have a recent Android media event - otherwhise it will activate all music apps
                     var requireMediaAppPackage = true;
                     SepiaFW.debug.info("Client controls - Media: trying to stop Android media player");
-                    sentAdditionalEvent = SepiaFW.android.broadcastMediaButtonDownUpIntent(127, requireMediaAppPackage);  
+                    sentAdditionalEvent = SepiaFW.android.broadcastMediaButtonDownUpIntent(127, requireMediaAppPackage) || sentAdditionalEvent;
                     //127: KEYCODE_MEDIA_PAUSE
                 }
                 //TODO: add iOS and Windows?

www/scripts/sepiaFW.ui.actions.js

@@ -6,7 +6,6 @@ function sepiaFW_build_ui_actions(){
 	//Executes all functions in next idle state so MAKE SURE! they don't interfere with each other!
 	var delayQueue = {};
 	var delayQueueTimers = {};
-	var delayQueueTimeout = 6000;
 	var delayId = 0;
 	Actions.delayFunctionUntilIdle = function(fun, idleState, timeoutDelay, timeoutMessage){
 		delayId++;
@@ -218,8 +217,8 @@ function sepiaFW_build_ui_actions(){
 		if (delayUntilIdle || action.delayUntilIdle){
 			Actions.delayFunctionUntilIdle(function(){
 				SepiaFW.client.controls.handle(action.fun, action.controlData);
-			}, "any",	//idleState req.
-			8000, "Failed to start audio (timeout).");
+			}, "any",	//idleState req. (change?)
+			8000, "Failed to trigger client controls (timeout).");
 		}else{
 			SepiaFW.client.controls.handle(action.fun, action.controlData);
 		}
@@ -407,7 +406,7 @@ function sepiaFW_build_ui_actions(){
 			Actions.delayFunctionUntilIdle(function(){
 				playAction(action);
 			}, idleState,
-			14000, "Failed to start audio (timeout).");
+			14000, "Failed to trigger audio player (timeout).");
 		}else{
 			playAction(action);
 		}

www/scripts/sepiaFW.ui.cards.embed.js

@@ -158,7 +158,7 @@ function sepiaFW_build_ui_cards_embed(){
 		var triedToStopAtLeastOne = false;
 		Object.values(activeMediaPlayers).forEach(function(mp){
 			if (!except || mp != except){
-				if (mp.isPlaying() || mp.isWaitingForPlay()){
+				if (mp.isPlaying() || mp.isWaitingForPlay() || mp.isOnHold()){
 					mp.pause();
 					triedToStopAtLeastOne = true;
 				}