Skip to content

Commit 7a187cb

Browse files
committed
some tweaks and fixes
1 parent f059519 commit 7a187cb

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

src/modules/porcupine-wake-word-worker.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,14 @@ function constructWorker(options) {
127127
processBufferSize = options.setup.bufferSize || inputSampleSize;
128128

129129
porcupineVersion = options.setup.version || options.setup.porcupineVersion || 19;
130+
porcupineVersion = porcupineVersion.replace(".", "").trim(); //remove dot
130131
importScripts('./picovoice/porcupine-wasm-module-' + porcupineVersion + '.js');
131132

132133
keywords = options.setup.keywords || ["Computer"];
133134
keywords.forEach(function(kw){
134135
importScripts('./picovoice/porcupine-keywords/' + kw.replace(/\s+/, "_").toLowerCase() + "_wasm_" + porcupineVersion + '.js');
135136
});
137+
//TODO: use 'options.setup.keywordsData'
136138
sensitivities = options.setup.sensitivities || [0.5];
137139

138140
var wasmFileArrayBuffer = options.preLoadResults.wasmFile;

src/modules/speex-resample-switch.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/modules/speex-resample-worker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ function constructWorker(options) {
113113
channelCount = 1; //options.setup.channelCount || 1; //TODO: only MONO atm
114114

115115
calculateRmsVolume = (options.setup.calculateRmsVolume != undefined)? options.setup.calculateRmsVolume : true;
116-
gain = options.setup.gain || 1.0; //TODO: keep?
116+
gain = options.setup.gain || 1.0;
117117

118118
resamplingMode = (targetSampleRate < sourceSamplerate? -1 : (targetSampleRate > sourceSamplerate? 1 : 0));
119119
resampleRatio = targetSampleRate/sourceSamplerate;

src/processor.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ if (!(typeof SepiaFW == "object")){
276276
var moduleName = info.moduleName;
277277
var moduleSetup = info.moduleSetup;
278278

279-
//pre-loads - NOTE: there might be room for optimizations here ...
279+
//pre-loads - NOTE: there might be room for optimizations here ... - TODO: can/should we cache preloads globally?
280280
var preLoads = {};
281281
var preLoadKeys = Object.keys(info.modulePreLoads);
282282
await Promise.all(preLoadKeys.map(async function(plKey, j){
@@ -349,6 +349,7 @@ if (!(typeof SepiaFW == "object")){
349349
if (err.message && err.message.indexOf("Uncaught {") == 0){
350350
err.preventDefault();
351351
errorMessage = JSON.parse(err.message.replace(/^Uncaught /, ""));
352+
err.message = errorMessage;
352353
}
353354
onProcessorError({
354355
name: "AudioModuleProcessorException",
@@ -359,6 +360,9 @@ if (!(typeof SepiaFW == "object")){
359360
completeInitCondition("module-" + i);
360361
initializerError({message: "Error during setup of module: " + thisProcessNode.moduleName, name: "ProcessorInitError", info: errorMessage});
361362
}
363+
if (moduleSetup.onerror){
364+
moduleSetup.onerror(err); //... in case the user requires per-module error messages
365+
}
362366
}
363367

364368
//AudioWorkletProcessor

test2.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ <h1>SEPIA Web Audio Processor</h1>
362362
name: 'porcupine-wake-word-worker',
363363
type: 'worker',
364364
preLoad: {
365-
wasmFile: (porcupineVersion == 14? 'src/modules/picovoice/porcupine-14.wasm' : 'src/modules/picovoice/porcupine-19.wasm')
365+
wasmFile: ('src/modules/picovoice/porcupine-' + porcupineVersion + '.wasm')
366366
},
367367
settings: {
368368
onmessage: onWakeWordMessage,

0 commit comments

Comments
 (0)