Skip to content

Commit 5ba443d

Browse files
committed
fix: remove sharding from CI workflow, run tests in single job
1 parent 190458a commit 5ba443d

File tree

1 file changed

+6
-63
lines changed

1 file changed

+6
-63
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,7 @@ defaults:
1717

1818
jobs:
1919
test:
20-
# Why Mac and Windows?
21-
# I can't run electron playwright on ubuntu-latest and
22-
# Linux support for Dyad is experimental so not as important
23-
# as Mac + Windows
24-
strategy:
25-
fail-fast: false
26-
matrix:
27-
os: [
28-
{ name: "macos", image: "macos-latest" },
29-
]
30-
shard: [1, 2, 3, 4]
31-
shardTotal: [4]
32-
runs-on: ${{ matrix.os.image }}
20+
runs-on: macos-latest
3321
steps:
3422
- name: Checkout code
3523
uses: actions/checkout@v4
@@ -87,60 +75,15 @@ jobs:
8775
run: npm run pre:e2e
8876
- name: Prep test server
8977
run: cd testing/fake-llm-server && npm install && npm run build && cd -
90-
- name: E2E tests (Shard ${{ matrix.shard }}/4)
78+
- name: E2E tests
9179
# You can add debug logging to make it easier to see what's failing
9280
# by adding "DEBUG=pw:browser" in front.
93-
# Use blob reporter for sharding and merge capabilities
94-
run: DEBUG=pw:browser npx playwright test --shard=${{ matrix.shard }}/${{ matrix.shardTotal }}
95-
- name: Upload shard results
81+
run: DEBUG=pw:browser npx playwright test
82+
- name: Upload test results
9683
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
9784
if: ${{ !cancelled() }}
9885
with:
99-
name: blob-report-${{ matrix.os.name }}-shard-${{ matrix.shard }}
100-
path: blob-report
86+
name: test-results
87+
path: test-results
10188
retention-days: 1
10289

103-
merge-reports:
104-
# Merge reports after playwright-tests, even if some shards have failed
105-
if: ${{ !cancelled() }}
106-
needs: [test]
107-
108-
runs-on: ubuntu-latest
109-
steps:
110-
- uses: actions/checkout@v4
111-
- uses: actions/setup-node@v4
112-
with:
113-
node-version: lts/*
114-
- name: Install dependencies
115-
run: npm install --no-audit --no-fund --progress=false
116-
117-
- name: Download blob reports from GitHub Actions Artifacts
118-
uses: actions/download-artifact@v4
119-
with:
120-
path: all-blob-reports
121-
pattern: blob-report-*
122-
merge-multiple: true
123-
124-
- name: Debug - List downloaded blob reports
125-
run: |
126-
echo "Contents of all-blob-reports directory:"
127-
ls -la all-blob-reports/
128-
echo "File sizes and details:"
129-
find all-blob-reports/ -type f -exec ls -lh {} \; || echo "No files found"
130-
131-
- name: Merge into HTML Report
132-
run: PLAYWRIGHT_HTML_OUTPUT_DIR=playwright-report npx playwright merge-reports --config=merge.config.ts ./all-blob-reports
133-
134-
- name: Debug - List playwright-report contents
135-
run: |
136-
echo "Contents of playwright-report directory:"
137-
ls -la playwright-report/ || echo "playwright-report directory does not exist"
138-
echo "Current directory contents:"
139-
ls -la
140-
141-
- name: Upload HTML report
142-
uses: actions/upload-artifact@v4
143-
with:
144-
name: html-report--attempt-${{ github.run_attempt }}
145-
path: playwright-report
146-
retention-days: 3

0 commit comments

Comments
 (0)