Modernize to use pathlib instead of os.path

Author: c-salomonsen

main.py

@@ -1,4 +1,5 @@
 import argparse
+from pathlib import Path
 
 import numpy as np
 import torch as th
@@ -30,20 +31,20 @@ def main():
     # Structuture related values
     parser.add_argument(
         "--datafolder",
-        type=str,
-        default="Data/",
+        type=Path,
+        default="Data",
         help="Path to where data will be saved during training.",
     )
     parser.add_argument(
         "--resultfolder",
-        type=str,
-        default="Results/",
+        type=Path,
+        default="Results",
         help="Path to where results will be saved during evaluation.",
     )
     parser.add_argument(
         "--modelfolder",
-        type=str,
-        default="Experiments/",
+        type=Path,
+        default="Experiments",
         help="Path to where model weights will be saved at the end of training.",
     )
     parser.add_argument(
@@ -107,7 +108,7 @@ def main():
 
     args = parser.parse_args()
 
-    createfolders(args)
+    createfolders(args.datafolder, args.resultfolder, args.modelfolder)
 
     device = 'cuda' if th.cuda.is_available() else 'cpu'
 

utils/createfolders.py

@@ -1,9 +1,9 @@
 import argparse
-import os
+from pathlib import Path
 from tempfile import TemporaryDirectory
 
 
-def createfolders(args) -> None:
+def createfolders(*dirs: Path) -> None:
     """
     Creates folders for storing data, results, model weights.
 
@@ -14,43 +14,44 @@ def createfolders(args) -> None:
 
     """
 
-    if not os.path.exists(args.datafolder):
-        os.makedirs(args.datafolder)
-        print(f"Created a folder at {args.datafolder}")
-
-    if not os.path.exists(args.resultfolder):
-        os.makedirs(args.resultfolder)
-        print(f"Created a folder at {args.resultfolder}")
-
-    if not os.path.exists(args.modelfolder):
-        os.makedirs(args.modelfolder)
-        print(f"Created a folder at {args.modelfolder}")
+    for dir in dirs:
+        dir.mkdir(parents=True, exist_ok=True)
 
 
 def test_createfolders():
-    with TemporaryDirectory(dir="tmp/") as temp_dir:
+    with TemporaryDirectory() as temp_dir:
+        temp_dir = Path(temp_dir)
+
         parser = argparse.ArgumentParser()
+
         # Structuture related values
         parser.add_argument(
             "--datafolder",
-            type=str,
-            default=os.path.join(temp_dir, "Data/"),
+            type=Path,
+            default=temp_dir / "Data",
             help="Path to where data will be saved during training.",
         )
         parser.add_argument(
             "--resultfolder",
-            type=str,
-            default=os.path.join(temp_dir, "Results/"),
+            type=Path,
+            default=temp_dir / "Results",
             help="Path to where results will be saved during evaluation.",
         )
         parser.add_argument(
             "--modelfolder",
-            type=str,
-            default=os.path.join(temp_dir, "Experiments/"),
+            type=Path,
+            default=temp_dir / "Experiments",
             help="Path to where model weights will be saved at the end of training.",
         )
 
-        args = parser.parse_args()
-        createfolders(args)
+        args = parser.parse_args([
+            "--datafolder", temp_dir / "Data",
+            "--resultfolder", temp_dir / "Results",
+            "--modelfolder", temp_dir / "Experiments"
+        ])
+
+        createfolders(args.datafolder, args.resultfolder, args.modelfolder)
 
-    return
+        assert (temp_dir / "Data").exists()
+        assert (temp_dir / "Results").exists()
+        assert (temp_dir / "Experiments").exists()