Skip to content

Commit 862ab6a

Browse files
committed
Remove extlibs references that are no longer needed
1 parent 9329dd8 commit 862ab6a

File tree

2 files changed

+6
-44
lines changed

2 files changed

+6
-44
lines changed

tools/nuget/build.macos.sh

Lines changed: 3 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -146,39 +146,12 @@ cmake -E env \
146146
"$CSFMLDir"
147147
cmake --build . --config Release --target install
148148

149-
# ============================ #
150-
# STEP 5: Fix RPATH references #
151-
# ============================ #
152-
153-
SFMLMajorMinor="3.0"
154-
SFMLMajorMinorPatch="$SFMLMajorMinor.0"
155-
156-
# SFML's framework dependencies will always reference @rpath/../Frameworks/<depedency>
157-
# Which is not where we place the frameworks and where SFML should look for them
158-
# This this fixes the dependency with install_name_tool
159-
fixrpath()
160-
{
161-
MODULE="$1"
162-
OLD="$2"
163-
NEW="$3"
164-
165-
install_name_tool -change $OLD $NEW "$SFMLLibDir/libsfml-$MODULE.dylib"
166-
install_name_tool -change $OLD $NEW "$SFMLLibDir/libsfml-$MODULE.$SFMLMajorMinor.dylib"
167-
install_name_tool -change $OLD $NEW "$SFMLLibDir/libsfml-$MODULE.$SFMLMajorMinorPatch.dylib"
168-
}
169-
170-
fixrpath audio "@rpath/../Frameworks/vorbisenc.framework/Versions/A/vorbisenc" "@rpath/vorbisenc.framework/Versions/A/vorbisenc"
171-
fixrpath audio "@rpath/../Frameworks/vorbisfile.framework/Versions/A/vorbisfile" "@rpath/vorbisfile.framework/Versions/A/vorbisfile"
172-
fixrpath audio "@rpath/../Frameworks/vorbis.framework/Versions/A/vorbis" "@rpath/vorbis.framework/Versions/A/vorbis"
173-
fixrpath audio "@rpath/../Frameworks/ogg.framework/Versions/A/ogg" "@rpath/ogg.framework/Versions/A/ogg"
174-
fixrpath audio "@rpath/../Frameworks/FLAC.framework/Versions/A/FLAC" "@rpath/FLAC.framework/Versions/A/FLAC"
175-
176-
fixrpath graphics "@rpath/../Frameworks/freetype.framework/Versions/A/freetype" "@rpath/freetype.framework/Versions/A/freetype"
177-
178149
# ======================================== #
179-
# STEP 6: Copy result to the NuGet folders #
150+
# STEP 5: Copy result to the NuGet folders #
180151
# ======================================== #
181152

153+
SFMLMajorMinor="3.0"
154+
SFMLMajorMinorPatch="$SFMLMajorMinor.0"
182155
CSFMLMajorMinor="3.0"
183156
CSFMLMajorMinorPatch="$CSFMLMajorMinor.0"
184157

@@ -208,8 +181,6 @@ copymodule graphics
208181
copymodule system
209182
copymodule window
210183

211-
cp -R "$SFMLLibDir/lib/"*.framework "$OutDir"
212-
213184
popd # Pop CSFML
214185
popd # Pop $RID
215186
popd # Pop Build

tools/nuget/build.win.ps1

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,17 +83,9 @@ Push-Location "SFML"
8383

8484
$SFMLDir = (Get-Item .).FullName
8585

86-
switch ($RID) {
87-
'win-x86' {
88-
$SFMLExtLibs = (Get-Item ./extlibs/libs-msvc-universal/x86).FullName
89-
}
90-
'win-x64' {
91-
$SFMLExtLibs = (Get-Item ./extlibs/libs-msvc-universal/x64).FullName
92-
}
93-
Default {
94-
Write-Error "Unknown RID '$RID'"
95-
exit
96-
}
86+
IF ($RID -ne 'win-x86' -and $RID -ne 'win-x64') {
87+
Write-Error "Unknown RID '$RID'"
88+
exit
9789
}
9890

9991
Pop-Location # Pop SFML
@@ -142,7 +134,6 @@ $CSFMLLibDir = (Get-Item lib).FullName; # The directory where the final CSFML dl
142134
cmake `
143135
"-DSFML_ROOT=$SFMLInstallDir" `
144136
'-DCSFML_LINK_SFML_STATICALLY=OFF' `
145-
"-DCMAKE_LIBRARY_PATH=$SFMLExtLibs" `
146137
`
147138
"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=$CSFMLLibDir" `
148139
"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE=$CSFMLLibDir" `

0 commit comments

Comments
 (0)