Do not access properties within ToString methods for disposed objects

Author: Marioalexsan

src/SFML.Audio/Music.cs

@@ -335,6 +335,9 @@ public TimeSpan LoopPoints
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[Music]" +
                    " SampleRate(" + SampleRate + ")" +
                    " ChannelCount(" + ChannelCount + ")" +

src/SFML.Audio/Sound.cs

@@ -270,6 +270,9 @@ public float Attenuation
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[Sound]" +
                    " Status(" + Status + ")" +
                    " Loop(" + Loop + ")" +

src/SFML.Audio/SoundBuffer.cs

@@ -199,6 +199,9 @@ public short[] Samples
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[SoundBuffer]" +
                    " SampleRate(" + SampleRate + ")" +
                    " ChannelCount(" + ChannelCount + ")" +

src/SFML.Audio/SoundBufferRecorder.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 
 namespace SFML.Audio
@@ -33,6 +34,9 @@ public SoundBuffer SoundBuffer
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[SoundBufferRecorder]" +
                    " SampleRate(" + SampleRate + ")" +
                    " SoundBuffer(" + SoundBuffer + ")";

src/SFML.Audio/SoundRecorder.cs

@@ -126,6 +126,9 @@ public static bool IsAvailable
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[SoundRecorder]" + " SampleRate(" + SampleRate + ")";
         }
 

src/SFML.Audio/SoundStream.cs

@@ -237,6 +237,9 @@ public Time PlayingOffset
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[SoundStream]" +
                    " SampleRate(" + SampleRate + ")" +
                    " ChannelCount(" + ChannelCount + ")" +

src/SFML.Graphics/Image.cs

@@ -354,7 +354,13 @@ public void FlipVertically()
         /// </summary>
         /// <returns>String description of the object</returns>
         ////////////////////////////////////////////////////////////
-        public override string ToString() => $"[Image] Size({Size})";
+        public override string ToString()
+        {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
+            return $"[Image] Size({Size})";
+        }
 
         ////////////////////////////////////////////////////////////
         /// <summary>

src/SFML.Graphics/RenderTexture.cs

@@ -497,6 +497,9 @@ public void ResetGLStates()
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[RenderTexture]" +
                    " Size(" + Size + ")" +
                    " Texture(" + Texture + ")" +

src/SFML.Graphics/RenderWindow.cs

@@ -716,6 +716,9 @@ public Image Capture()
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[RenderWindow]" +
                    " Size(" + Size + ")" +
                    " Position(" + Position + ")" +
@@ -802,6 +805,8 @@ protected override void Destroy(bool disposing)
             {
                 myDefaultView.Dispose();
             }
+
+            myDefaultView = null;
         }
 
         ////////////////////////////////////////////////////////////

src/SFML.Graphics/Shader.cs

@@ -712,6 +712,9 @@ public static bool IsGeometryAvailable
         ////////////////////////////////////////////////////////////
         public override string ToString()
         {
+            if (CPointer == IntPtr.Zero)
+                return MakeDisposedObjectString();
+
             return "[Shader]";
         }