Remove explicit support for static libraries

Author: ChrisThrasher

.github/workflows/ci.yml

@@ -17,8 +17,8 @@ jobs:
         - { name: Linux Clang,    os: ubuntu-latest, flags: -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ }
         - { name: MacOS XCode,    os: macos-latest  }
         config:
-        - { name: Shared, flags: -DCMAKESFMLPROJECT_STATIC_LIBS=OFF -DBUILD_SHARED_LIBS=TRUE }
-        - { name: Static, flags: -DCMAKESFMLPROJECT_STATIC_LIBS=ON -DBUILD_SHARED_LIBS=FALSE }
+        - { name: Shared, flags: -DSFML_STATIC_LIBRARIES=OFF -DBUILD_SHARED_LIBS=TRUE }
+        - { name: Static, flags: -DSFML_STATIC_LIBRARIES=ON -DBUILD_SHARED_LIBS=FALSE }
 
     steps:
     - name: Install Linux Dependencies

CMakeLists.txt

@@ -2,10 +2,6 @@ cmake_minimum_required(VERSION 3.15)
 
 project(CMakeSFMLProject LANGUAGES CXX)
 
-# Set options
-option(CMAKESFMLPROJECT_STATIC_LIBS "Link SFML libraries statically?" OFF)
-option(CMAKESFMLPROJECT_STATIC_STD_LIBS "Use statically linked standard/runtime libraries? This option must match the one used for SFML." OFF)
-
 # Find all source files
 file(GLOB_RECURSE SOURCE_FILES CONFIGURE_DEPENDS ${PROJECT_SOURCE_DIR}/src/*.cpp ${PROJECT_SOURCE_DIR}/src/*.hpp)
 
@@ -16,24 +12,6 @@ add_executable(${PROJECT_NAME} ${SOURCE_FILES})
 target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17)
 set_target_properties(${PROJECT_NAME} PROPERTIES CXX_EXTENSIONS NO CXX_STANDARD_REQUIRED YES)
 
-# Make sure that the runtime library gets linked statically
-if(CMAKESFMLPROJECT_STATIC_STD_LIBS)
-    if(NOT CMAKESFMLPROJECT_STATIC_LIBS)
-        message("\n-> If you check CMAKESFMLPROJECT_STATIC_STD_LIBS, you also need to check CMAKESFMLPROJECT_STATIC_LIBS.")
-        message("-> It would lead to multiple runtime environments which results in undefined behavior.\n")
-    elseif(WIN32 AND MSVC)
-        set_property(TARGET ${PROJECT_NAME} PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
-    elseif(CMAKE_COMPILER_IS_GNUCXX)
-        # Note: Doesn't work for TDM compiler, since it's compiling the runtime libs statically by default
-        target_compile_options(${PROJECT_NAME} PRIVATE -static)
-    endif()
-endif()
-
-# Request static SFML libraries when building statically
-if(CMAKESFMLPROJECT_STATIC_LIBS)
-    set(SFML_STATIC_LIBRARIES TRUE)
-endif()
-
 # Find SFML
 find_package(SFML 2.5 COMPONENTS graphics REQUIRED)
 

README.md

@@ -6,8 +6,6 @@ Thanks to [GitHub's nature of templates](https://docs.github.com/en/repositories
 The template starts out very basic, but might receive additional features over time:
 
 - Basic CMake script to build your project and link SFML
-- Support for linking SFML statically or as shared library
-- Support for linking the C runtime statically
 - Basic [GitHub Actions](https://github.com/features/actions) script for all major platforms
 
 ## License