fix(web): remove eslint errors

Author: mikonse

tools/nx-python/package.json

@@ -2,9 +2,9 @@
   "name": "@sftkit/nx-python",
   "version": "0.0.1",
   "dependencies": {
-    "@nx/devkit": "^19.2.2",
+    "@nx/devkit": "^20.3.0",
     "tslib": "^2.3.0",
-    "nx": "^19.2.2",
+    "nx": "^20.3.0",
     "semver": "^7.6.2",
     "@ltd/j-toml": "^1.38.0"
   },

tools/nx-python/src/executors/release-publish/executor.ts

@@ -11,7 +11,15 @@ export default async function runExecutor(options: ReleaseExecutorSchema, contex
    */
   const isDryRun = process.env.NX_DRY_RUN === "true" || options.dryRun || false;
 
-  const projectConfig = context.projectsConfigurations!.projects[context.projectName!]!;
+  if (!context.projectName) {
+    throw new Error("project name is empty");
+  }
+
+  const projectConfig = context.projectsConfigurations?.projects[context.projectName];
+
+  if (!projectConfig) {
+    throw new Error("could not find a project config");
+  }
 
   const packageRoot = joinPathFragments(context.root, options.packageRoot ?? projectConfig.root);
 
@@ -35,7 +43,8 @@ export default async function runExecutor(options: ReleaseExecutorSchema, contex
     return {
       success: true,
     };
-  } catch (err: any) {
+  } catch (err) {
+    output.logSingleLine(`Error running pdm publish: ${err}`);
     return {
       success: false,
     };

tools/nx-python/src/generators/release-version/generator.ts

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {
   formatFiles,
   joinPathFragments,
@@ -203,8 +205,8 @@ To fix this you will either need to add a pyproject.toml file at that location,
             const previousVersionRef = latestMatchingGitTag
               ? latestMatchingGitTag.tag
               : options.fallbackCurrentVersionResolver === "disk"
-              ? await getFirstGitCommit()
-              : undefined;
+                ? await getFirstGitCommit()
+                : undefined;
 
             if (!previousVersionRef) {
               // This should never happen since the checks above should catch if the current version couldn't be resolved
@@ -481,8 +483,8 @@ function resolveLocalPackageDependencies(
       const dependencyCollection: "dependencies" | "dev-dependencies" | null = dependencies[depProject.name]
         ? "dependencies"
         : devDependencies[depProject.name]
-        ? "dev-dependencies"
-        : null;
+          ? "dev-dependencies"
+          : null;
       if (!dependencyCollection) {
         throw new Error(
           `The project "${projectNode.name}" does not have a local dependency on "${depProject.name}" in its Cargo.toml`

tools/nx-python/src/graph.ts

@@ -13,8 +13,12 @@ export const createNodes: CreateNodesV2 = [
         const root = dirname(projectFile);
         const pyproject = loadPyprojectToml(projectFile);
 
+        if (!pyproject.project?.name) {
+          throw new Error("No name configured in pyproject.toml");
+        }
+
         const pythonPackage = {
-          name: pyproject.project!.name!,
+          name: pyproject.project.name,
           pyprojectToml: pyproject,
           projectRoot: dirname(projectFile),
         };

tools/nx-python/src/utils/pyproject-toml.ts

@@ -1,5 +1,6 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { logger, Tree } from "@nx/devkit";
-import TOML from '@ltd/j-toml';
+import TOML from "@ltd/j-toml";
 import * as fs from "fs";
 
 export interface BuildSystem {
@@ -36,12 +37,12 @@ export interface Project {
   classifiers?: string[];
   urls?: Record<string, string>;
   requires_python?: string;
-  dependencies?: string[],
-  optional_dependencies?: string[],
+  dependencies?: string[];
+  optional_dependencies?: string[];
   scripts?: Record<string, string>;
   gui_scripts?: Record<string, string>;
   entry_points?: Record<string, Record<string, string>>;
-  dynamic?: string[]
+  dynamic?: string[];
 }
 
 export interface PyprojectToml {
@@ -67,20 +68,20 @@ export function loadPyprojectToml(pyprojectTomlPath: string): PyprojectToml {
 }
 
 export function parsePyprojectToml(pyprojectString: string) {
-    return TOML.parse(pyprojectString, {
+  return TOML.parse(pyprojectString, {
     x: { comment: true },
   }) as unknown as PyprojectToml;
 }
 
 export function stringifyPyprojectToml(pyprojectToml: PyprojectToml) {
   const tomlString = TOML.stringify(pyprojectToml, {
-    newlineAround: 'section',
+    newlineAround: "section",
     indent: 4,
   });
   // the following is a very, very dirty hack for dealing with j-toml not being able to configure the type of quotation
 
   if (Array.isArray(tomlString)) {
-    return tomlString.join('\n').replace(/'/g, '"');
+    return tomlString.join("\n").replace(/'/g, '"');
   }
 
   return tomlString.toString().replace(/'/g, '"');
@@ -94,19 +95,14 @@ export function modifyPyprojectToml(
 ) {
   toml[section] ??= TOML.Section({});
   toml[section][key] =
-    typeof value === 'object' && !Array.isArray(value)
+    typeof value === "object" && !Array.isArray(value)
       ? TOML.inline(value as any)
-      : typeof value === 'function'
-      ? value()
-      : value;
+      : typeof value === "function"
+        ? value()
+        : value;
 }
 
-export function modifyCargoNestedTable(
-  toml: PyprojectToml,
-  section: string,
-  key: string,
-  value: object
-) {
+export function modifyCargoNestedTable(toml: PyprojectToml, section: string, key: string, value: object) {
   toml[section] ??= {};
   toml[section][key] = TOML.Section(value as any);
 }