Skip to content

Conversation

@portablebanker
Copy link

This is my first PR. I took the option to start on the end event. This page can be completed over time.

@twisti-dev twisti-dev requested a review from Copilot May 5, 2025 19:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces documentation for a new event, describing details such as event rules, teleportation commands, and voice chat setup.

  • Added a new markdown file with details on the Nether event (though the file name and PR title mention "end event").
  • Provides instructions on in-game commands, rules, and troubleshooting tips for players.
Files not reviewed (1)
  • Writerside/ccs.tree: Language not supported
Comments suppressed due to low confidence (2)

Writerside/topics/event-server/events/end-event.md:5

  • The document title 'Nether Event' does not match the file name 'end-event.md' and the PR title 'end event'. Consider aligning these names for clarity.
# Nether Event

Writerside/topics/event-server/events/end-event.md:63

  • [nitpick] There is an inconsistent naming style between 'Chestprotect' (used in the section header) and 'ChestProtect' in the instruction. Use a consistent naming convention.
> Ihr könnt das automatische Sichern von Kisten im ChestProtect Menu ein- und ausschalten.

@twisti-dev

This comment was marked as outdated.

@twisti-dev twisti-dev closed this May 5, 2025
@twisti-dev twisti-dev reopened this May 5, 2025
@TheBjoRedCraft
Copy link
Member

In english please

@portablebanker
Copy link
Author

Excuse me.

@JoField08
Copy link
Contributor

Usually you write in the title of the pull request that this is a draft. Then it is immediately obvious to everyone.

@portablebanker portablebanker marked this pull request as ready for review May 6, 2025 14:34
@JoField08
Copy link
Contributor

JoField08 commented May 6, 2025

9c60399 this should be pushed as refactor and not as feat..

@JoField08
Copy link
Contributor

the branch you want to merge into the master branch has confilcts that must be resolved

@portablebanker
Copy link
Author

How can I fix it?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the initial documentation for the End Event in the event-server, providing an overview of the event rules, features, and FAQs.

  • Added a markdown page detailing the End Event description, rules, teleportation instructions, voicechat usage, chest protection commands, and a Q&A section.
  • Included event-specific labels and styling hints for clarifying the event status and rules.
Files not reviewed (4)
  • .idea/vcs.xml: Language not supported
  • Writerside/ccs.tree: Language not supported
  • Writerside/labels.list: Language not supported
  • Writerside/topics/event-server/event-server.topic: Language not supported

@portablebanker
Copy link
Author

Is it now okay? I dont now, what JoField mean. can somebody explain me mabye?

@JoField08
Copy link
Contributor

JoField08 commented May 9, 2025

Your branch you want to merge from into the master branch here is 34 commits behind master

@mergify
Copy link
Contributor

mergify bot commented May 24, 2025

👋 portablebanker your PR is conflicting and needs to be updated to be merged

@mergify mergify bot added the conflict label May 24, 2025
@mergify mergify bot requested a review from a team May 24, 2025 10:01
@JoField08
Copy link
Contributor

duplicate #284

@JoField08 JoField08 closed this Jun 14, 2025
@mergify mergify bot removed the conflict label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants