-
Notifications
You must be signed in to change notification settings - Fork 13
feat(docs): start adding end event #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): start adding end event #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces documentation for a new event, describing details such as event rules, teleportation commands, and voice chat setup.
- Added a new markdown file with details on the Nether event (though the file name and PR title mention "end event").
- Provides instructions on in-game commands, rules, and troubleshooting tips for players.
Files not reviewed (1)
- Writerside/ccs.tree: Language not supported
Comments suppressed due to low confidence (2)
Writerside/topics/event-server/events/end-event.md:5
- The document title 'Nether Event' does not match the file name 'end-event.md' and the PR title 'end event'. Consider aligning these names for clarity.
# Nether Event
Writerside/topics/event-server/events/end-event.md:63
- [nitpick] There is an inconsistent naming style between 'Chestprotect' (used in the section header) and 'ChestProtect' in the instruction. Use a consistent naming convention.
> Ihr könnt das automatische Sichern von Kisten im ChestProtect Menu ein- und ausschalten.
This comment was marked as outdated.
This comment was marked as outdated.
|
In english please |
|
Excuse me. |
|
Usually you write in the title of the pull request that this is a draft. Then it is immediately obvious to everyone. |
Co-authored-by: Jo_field <[email protected]>
Co-authored-by: Jo_field <[email protected]>
Co-authored-by: Jo_field <[email protected]>
Co-authored-by: Jo_field <[email protected]>
Co-authored-by: Jo_field <[email protected]>
Co-authored-by: Jo_field <[email protected]>
|
9c60399 this should be pushed as refactor and not as feat.. |
|
the branch you want to merge into the master branch has confilcts that must be resolved |
|
How can I fix it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the initial documentation for the End Event in the event-server, providing an overview of the event rules, features, and FAQs.
- Added a markdown page detailing the End Event description, rules, teleportation instructions, voicechat usage, chest protection commands, and a Q&A section.
- Included event-specific labels and styling hints for clarifying the event status and rules.
Files not reviewed (4)
- .idea/vcs.xml: Language not supported
- Writerside/ccs.tree: Language not supported
- Writerside/labels.list: Language not supported
- Writerside/topics/event-server/event-server.topic: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Is it now okay? I dont now, what JoField mean. can somebody explain me mabye? |
|
Your branch you want to merge from into the master branch here is 34 commits behind master |
|
👋 portablebanker your PR is conflicting and needs to be updated to be merged |
|
duplicate #284 |
This is my first PR. I took the option to start on the end event. This page can be completed over time.