feat: implement SystemChatPacket support and version bump

- Added `SystemChatPacket` interface with `content` and `overlay` properties.
- Introduced `ClientboundSystemChatPacketImpl` for handling clientbound system chat packets.
- Updated `PacketRegistry` to support `ClientboundSystemChatPacket`.
- Adjusted parameter variance for `NmsPacketImpl` and `NmsClientboundPacketImpl`.
- Bumped version to 1.21.8-2.35.0.

Author: twisti-dev

gradle.properties

@@ -7,6 +7,6 @@ org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
 javaVersion=21
 mcVersion=1.21.8
 group=dev.slne.surf
-version=1.21.8-2.34.1
+version=1.21.8-2.35.0
 relocationPrefix=dev.slne.surf.surfapi.libs
 snapshot=true

surf-api-bukkit/surf-api-bukkit-api/api/surf-api-bukkit-api.api

@@ -1990,6 +1990,13 @@ public abstract interface class dev/slne/surf/surfapi/bukkit/api/nms/listener/pa
 public abstract interface class dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/clientbound/NmsClientboundPacket : dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/NmsPacket {
 }
 
+public abstract interface class dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/clientbound/SystemChatPacket : dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/clientbound/NmsClientboundPacket {
+	public abstract fun getContent ()Lnet/kyori/adventure/text/Component;
+	public abstract fun getOverlay ()Z
+	public abstract fun setContent (Lnet/kyori/adventure/text/Component;)V
+	public abstract fun setOverlay (Z)V
+}
+
 public abstract interface class dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/serverbound/CommandSuggestionPacket : dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/serverbound/NmsServerboundPacket {
 	public abstract fun getCommand ()Ljava/lang/String;
 	public abstract fun getCompletionId ()I

surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/clientbound/SystemChatPacket.kt

@@ -0,0 +1,10 @@
+package dev.slne.surf.surfapi.bukkit.api.nms.listener.packets.clientbound
+
+import dev.slne.surf.surfapi.bukkit.api.nms.NmsUseWithCaution
+import net.kyori.adventure.text.Component
+
+@NmsUseWithCaution
+interface SystemChatPacket : NmsClientboundPacket {
+    var content: Component
+    var overlay: Boolean
+}

surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/NmsPacketImpl.kt

@@ -6,7 +6,7 @@ import net.minecraft.network.PacketListener
 import net.minecraft.network.protocol.Packet
 
 @NmsUseWithCaution
-abstract class NmsPacketImpl<Nms : Packet<Listener>, Listener : PacketListener>(val nmsPacket: Nms) :
+abstract class NmsPacketImpl<Nms : Packet<out Listener>, Listener : PacketListener>(var nmsPacket: Nms) :
     NmsPacket {
     val nmsClass = nmsPacket.javaClass as Class<Nms>
     override val packetClass =

surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/PacketRegistry.kt

@@ -4,17 +4,15 @@ import dev.slne.surf.surfapi.bukkit.api.nms.NmsUseWithCaution
 import dev.slne.surf.surfapi.bukkit.api.nms.listener.packets.clientbound.NmsClientboundPacket
 import dev.slne.surf.surfapi.bukkit.api.nms.listener.packets.serverbound.NmsServerboundPacket
 import dev.slne.surf.surfapi.bukkit.server.impl.nms.listener.packets.clientbound.ClientboundDisconnectPacketImpl
+import dev.slne.surf.surfapi.bukkit.server.impl.nms.listener.packets.clientbound.ClientboundSystemChatPacketImpl
 import dev.slne.surf.surfapi.bukkit.server.impl.nms.listener.packets.serverbound.CommandSuggestionPacketImpl
 import dev.slne.surf.surfapi.bukkit.server.impl.nms.listener.packets.serverbound.RenameItemPacketImpl
 import dev.slne.surf.surfapi.bukkit.server.impl.nms.listener.packets.serverbound.SignUpdatePacketImpl
 import dev.slne.surf.surfapi.core.api.util.mutableObject2ObjectMapOf
 import net.minecraft.network.protocol.Packet
 import net.minecraft.network.protocol.common.ClientCommonPacketListener
 import net.minecraft.network.protocol.common.ClientboundDisconnectPacket
-import net.minecraft.network.protocol.game.ServerGamePacketListener
-import net.minecraft.network.protocol.game.ServerboundCommandSuggestionPacket
-import net.minecraft.network.protocol.game.ServerboundRenameItemPacket
-import net.minecraft.network.protocol.game.ServerboundSignUpdatePacket
+import net.minecraft.network.protocol.game.*
 import kotlin.reflect.KClass
 
 @OptIn(NmsUseWithCaution::class)
@@ -33,6 +31,7 @@ object PacketRegistry {
 
         // Clientbound packets
         registerClientboundPacket(ClientboundDisconnectPacket::class) { ClientboundDisconnectPacketImpl(it) }
+        registerClientboundPacket(ClientboundSystemChatPacket::class) { ClientboundSystemChatPacketImpl(it) }
         // @formatter:on
     }
 
@@ -48,7 +47,7 @@ object PacketRegistry {
         return factory?.create(packet)
     }
 
-    private fun <Nms : Packet<ClientCommonPacketListener>, Api : NmsClientboundPacket> registerClientboundPacket(
+    private fun <Nms : Packet<out ClientCommonPacketListener>, Api : NmsClientboundPacket> registerClientboundPacket(
         nms: KClass<Nms>,
         factory: ClientboundPacketFactory<Nms, Api>,
     ) {

surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/clientbound/ClientboundSystemChatPacketImpl.kt

@@ -0,0 +1,23 @@
+package dev.slne.surf.surfapi.bukkit.server.impl.nms.listener.packets.clientbound
+
+import dev.slne.surf.surfapi.bukkit.api.nms.NmsUseWithCaution
+import dev.slne.surf.surfapi.bukkit.api.nms.listener.packets.clientbound.SystemChatPacket
+import dev.slne.surf.surfapi.bukkit.server.nms.toBukkit
+import net.kyori.adventure.text.Component
+import net.minecraft.network.protocol.game.ClientboundSystemChatPacket
+
+@NmsUseWithCaution
+class ClientboundSystemChatPacketImpl(nmsPacket: ClientboundSystemChatPacket) :
+    NmsClientboundPacketImpl<ClientboundSystemChatPacket>(nmsPacket), SystemChatPacket {
+    override var content: Component
+        get() = nmsPacket.content().toBukkit()
+        set(value) {
+            nmsPacket = ClientboundSystemChatPacket(value, nmsPacket.overlay)
+        }
+
+    override var overlay: Boolean
+        get() = nmsPacket.overlay()
+        set(value) {
+            nmsPacket = ClientboundSystemChatPacket(nmsPacket.content(), value)
+        }
+}

surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/clientbound/NmsClientboundPacketImpl.kt

@@ -6,5 +6,5 @@ import net.minecraft.network.protocol.Packet
 import net.minecraft.network.protocol.common.ClientCommonPacketListener
 
 @NmsUseWithCaution
-abstract class NmsClientboundPacketImpl<Nms : Packet<ClientCommonPacketListener>>(nmsPacket: Nms) :
+abstract class NmsClientboundPacketImpl<Nms : Packet<out ClientCommonPacketListener>>(nmsPacket: Nms) :
     NmsPacketImpl<Nms, ClientCommonPacketListener>(nmsPacket)