fix: update parameter names and formatting in packet operation methods

Author: Keviro

surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/bridges/packets/PacketOperationImpl.kt

@@ -39,10 +39,10 @@ class PacketOperationImpl : PacketOperation {
         connection.send(ClientboundBundlePacket(packets))
     }
 
-    override fun add(other: PacketOperation): PacketOperationImpl {
-        require(other is PacketOperationImpl) { "operation must be an instance of PacketOperationImpl" }
+    override fun add(operation: PacketOperation): PacketOperationImpl {
+        require(operation is PacketOperationImpl) { "operation must be an instance of PacketOperationImpl" }
 
-        this.operation = this.operation.andThen(other.operation)
+        this.operation = this.operation.andThen(operation.operation)
         return this
     }
 
@@ -54,7 +54,7 @@ class PacketOperationImpl : PacketOperation {
     fun interface Operation {
         fun apply(
             player: Player,
-            packets: LinkedList<Packet<in ClientGamePacketListener>>
+            packets: LinkedList<Packet<in ClientGamePacketListener>>,
         ): LinkedList<Packet<in ClientGamePacketListener>>
 
         fun andThen(after: Operation): Operation {
@@ -68,13 +68,13 @@ class PacketOperationImpl : PacketOperation {
         }
     }
 
-    class EmptyOperation: Operation {
+    class EmptyOperation : Operation {
         var empty: Boolean = true
             private set
 
         override fun apply(
             player: Player,
-            packets: LinkedList<Packet<in ClientGamePacketListener>>
+            packets: LinkedList<Packet<in ClientGamePacketListener>>,
         ): LinkedList<Packet<in ClientGamePacketListener>> {
             return packets
         }

surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/bridges/packets/entity/SurfBukkitNmsSpawnPacketsImpl.kt

@@ -37,8 +37,8 @@ class SurfBukkitNmsSpawnPacketsImpl : SurfBukkitNmsSpawnPackets {
     override fun despawn(entityIds: IntList) =
         PacketOperationImpl.simple { ClientboundRemoveEntitiesPacket(entityIds) }
 
-    override fun despawn(vararg entityIds: Int) =
-        PacketOperationImpl.simple { ClientboundRemoveEntitiesPacket(*entityIds) }
+    override fun despawn(vararg entityId: Int) =
+        PacketOperationImpl.simple { ClientboundRemoveEntitiesPacket(*entityId) }
 
 
     override fun spawnItemDisplay(
@@ -142,7 +142,7 @@ class SurfBukkitNmsSpawnPacketsImpl : SurfBukkitNmsSpawnPackets {
         yaw: Float,
         pitch: Float,
         deltaMovement: FinePosition?,
-        onGround: Boolean
+        onGround: Boolean,
     ) = PacketOperationImpl.simple {
         ClientboundTeleportEntityPacket.teleport(
             entityId,

surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/PacketRegistry.kt

@@ -37,11 +37,12 @@ object PacketRegistry {
 
     private fun <Nms : Packet<ServerGamePacketListener>, Api : NmsServerboundPacket> registerServerboundPacket(
         nms: KClass<Nms>,
-        factory: ServerboundPacketFactory<Nms, Api>
+        factory: ServerboundPacketFactory<Nms, Api>,
     ) {
         SERVERBOUND_PACKETS.put(nms.java, factory)
     }
 
+    @Suppress("UNCHECKED_CAST")
     fun <Nms : Packet<*>> createServerboundPacketOrNull(packet: Nms): NmsServerboundPacket? {
         val factory = SERVERBOUND_PACKETS[packet.javaClass] as? ServerboundPacketFactory<Nms, *>
         return factory?.create(packet)
@@ -54,6 +55,7 @@ object PacketRegistry {
         CLIENTBOUND_PACKETS.put(nms.java, factory)
     }
 
+    @Suppress("UNCHECKED_CAST")
     fun <Nms : Packet<*>> createClientboundPacketOrNull(packet: Nms): NmsClientboundPacket? {
         val factory = CLIENTBOUND_PACKETS[packet.javaClass] as? ClientboundPacketFactory<Nms, *>
         return factory?.create(packet)